Received-SPF: pass (google.com: domain of linux-nfs+bounces-675-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 16 Dec 2023 11:45:42 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Ahelenia =?utf-8?Q?Ziemia=C5=84ska?= <nabijaczleweli@nabijaczleweli.xyz>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jeff Layton <jlayton@kernel.org>,
        Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <Dai.Ngo@oracle.com>,
        Tom Talpey <tom@talpey.com>, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-nfs@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sunrpc: sizeof('\0') is 4, not 1
Message-ID: <ZX3UNrHBYoPaPRWd@tissot.1015granger.net>
References: <170270083607.12910.2219100479356858889@noble.neil.brown.name>
 <ikgsiev777wvypqueii5mcshrdeftme22stfvztonxbvcrf35l@tarta.nabijaczleweli.xyz>
 <170270600360.12910.7954602598238459243@noble.neil.brown.name>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <170270600360.12910.7954602598238459243@noble.neil.brown.name>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?ZTBjTDNwQXZSSlFtT215QkVlL01JTHJMc0wxMVFObjdoS2UyVnUwUFR5UHFO?=
 =?utf-8?B?QlMycXJVZVI3eHZielVteEJuejV5Y0F6UzV3N1RBZ2FsajlsMEVYVkJHakw2?=
 =?utf-8?B?bVJ2cXEwQkI4U1VBRWJDeVpSNDlTTFM4b1BBODcwdDB3NHVSaDZPY1N5V25z?=
 =?utf-8?B?eW5RZzNCZFk2NlBkd0xQUnVVVERRN3F0d3RTYklUNXQzSXdFdmhFbzV4WWRN?=
 =?utf-8?B?dUg5eVlHekhwUUExaVlNRWJqUU0yRUlXZG9TcVAvRnAvM0lzVENNNXoxNDhi?=
 =?utf-8?B?cFFtditDN1c2cWk4UWNGNUJ6TEZSVnhlaE91MjNUQVhkRU9PUnErejFMTXBH?=
 =?utf-8?B?SEtnMzI4UEE5TFVTY1ZXeHU2OFdrc2RLZWpiN1dqNHNCKzlQN3B2NnFHM3FG?=
 =?utf-8?B?QTVCREVUZCs3dVRaOCtkSnlzQm5Ea3UxUEFtdk1oV1p1dk9mNzFQZktpV0hr?=
 =?utf-8?B?ZFZUbVU2UmMxeHBtdUpDNjYyOUxKejFkVUlqVlFZSUlIa1R0MExTL0pNVVNw?=
 =?utf-8?B?UTh5TmlDVW0rU29WMGsvaUFTTGJiTEUzd3VzbmVqdW5ydG0xSWJ3ZkhSY2ds?=
 =?utf-8?B?cEhCTWNnL1YzZEVla0RXanR4bmx2Q0pkUk82YjlwdC9KMk5Cd1ppMG1hSXJz?=
 =?utf-8?B?NDFCN3h3YlFoR1cwaHZPdmR4WmlyQURzUEdnWVE3aTNNRlN6S0cyR3cyOWZQ?=
 =?utf-8?B?ZlBXK1duZnBqWFNVdWR0T2pwZ2lzanNuNGRUdDE1aEs3dEM4NUM4UHArTmM2?=
 =?utf-8?B?R25veUllR09PWHFaVEI4dmxhdjZKNlhRMDkvZHpZdUF1MXgwcjVnSjZDa1ll?=
 =?utf-8?B?bDl2aDBqUFdXRHRDeXhhMnNONnFvUkZoUzg3NEhFYzJjbUhGQzVUQzZVMUhs?=
 =?utf-8?B?azZ3YW9hOGJLNzJrTHlsMnFGbFg3VmxiV1Bta3NqQnp6Z3VGMVBxcVV5UVhH?=
 =?utf-8?B?MURlTVJWK0pkb2FPLzR2di8wSXd5dEpHcXpURFo2WDNZVWJYR0VpVjgvQzFq?=
 =?utf-8?B?aE1UcTRBVk9KaHlpSXZ0RDRzRWQ0T2xzb29TV1NiNmFUdHQ2cXdoay9XY3Vz?=
 =?utf-8?B?TTBOQ0M3eHBIWGVCS2lYdE1pWFBqd1Jpa0FpVFF6VGJUTFVwYTlzWS9lZ05Z?=
 =?utf-8?B?bWxMcTNUaXhDamovb0g5aUNjRGkyRDg2b3UvUGhWM1pGcmF0Mnk1NVg2L2J6?=
 =?utf-8?B?MzVBRmthenc2SUpFK3RKRXoxTmw1c0Y5UGh6cXg3NHZndVFDZEczYklXUGh1?=
 =?utf-8?B?R29OWDN4TS9NeFNoR09aZDJZVmNvVnltM1A0SDFMa1NRV0VIODhUeXprSU96?=
 =?utf-8?B?eVRON2hneW5JRFU3YUgxcU15VDBjZkV1dFd5M093c1ZOY05HRW14Qzg0cHM0?=
 =?utf-8?B?b2ZiVjVEcGRzclBmaW5yOWNFZ1kydDlyNVhhZSswelA5U2ZZbkRIS2VDWEM4?=
 =?utf-8?B?bHpYcHpmc3d3MUtvczJ4N0RxdG13KzFnZFo0VnhrTFhnRnpJbGRjL3RHZTBF?=
 =?utf-8?B?UXhZSjQ4c1JFcEt3SmhPUDdTNXg4TjRTUXZib3pVNjVXZEJTQk5wZ2dsNWtW?=
 =?utf-8?B?TWFTL2FwNFVtT0RDWElkT0JZRFVEaGZkZ3k0QXZoT0QvaTN3Z1dKNHp2U3A0?=
 =?utf-8?B?MCtRVURHai9BdE1RdWxXVkJlcWZrMU5jdmZZT05rMlJBVkRIR0pQbmxCS0t6?=
 =?utf-8?B?MEVmMWFyRjArTzBGaTBRZ2pzcWFUYkVVT3pJN2JvYkcwb3h6YWhOVFR2Z0tK?=
 =?utf-8?B?Wmc3S3pod0x3bFcwUGxQRURlQkx6Q055TFNreWcyVWlNMkVyb2plT1RpdWp1?=
 =?utf-8?B?SHVGaUlqdklpZXRXWUJLblVBNjVRK056ZlRTdW1DWk5jOVY5dHcydEZOM0tN?=
 =?utf-8?B?TXdqUk8vSW83Wnc2S25DblVvV2tFRkVaa1VzSm92Zk91RnZZVDhQaDQvL0FX?=
 =?utf-8?B?SWF4NzNVcWMySFFTNUxtZ3Ewbi8yZ3pEbHRJVDhpRTc3Z2pUVmtOVWgwSTF6?=
 =?utf-8?B?YngvOWVuK25GbkFIZTZ4L04zWEhYM0Q4UTNoTWhhOEYrMEcwUkM0S0Z4bjZp?=
 =?utf-8?B?L3VCWWVxbzRENFhwU3cxcFFKbGFZQVNNL09od0J4UTFQODgyRjRGQVJUV3JP?=
 =?utf-8?B?c1ljb0dXVWR1OWs0a0k0WUg5bzluSzlPdWVWS0RjbzVOQlBaT2lrTkFONG12?=
 =?utf-8?B?Umc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	vfDfKqxP62DN1fyJsbBp/s/kJTFWslksh6LffSFOT23z7aCuiH9eWa51DRY6Rz4rvIc0tT4Pdwu1AFX5BNIL7GJVkqdYtg3fdt9KFo4cqPJjRY1dEiHZNEx38IAv9hLfN9Gv2uAtKKXo6JYCaId9tdD3+K9o8T0d8UnAKRhPPcGVLAAYut/u7c4l3F805OFU8bcUanYoP++OLEo3qEKKCpcUVn3jfdzqHf03kilTVTDKs0BOLLVMbBAbsKijY1IOM/iAWhJ6y1jCzQb3O3Dx4OXp4YE8/SwxDm3ntz1nnpjNEkRXrXEVzjJ1ufobcuw9C6qaaBSvIAclFSZjeiarXFWODAFGqWfmXdaQM8JzPCi1zxMhY71IVwRM32F96pqLriRm6rpk/IrcKakKF7AD0wOSM23Ym8QiUTMgt3k7eVnCyT5Q0UR6iAKSfhmhUwEmdA90VAnZQT6L/j2vfUrmExr45y99FmV0QyvoUvBYnn13pxtWEHfUBLntB54lhii08RYPgf1M9o9O6i0NZ1H1xu537Z8ZNny88hDKQk8a3tbeWVN1H7U0aCPXMw1ig8YqWhAyLn8onYKhVonx6LjkdqgzHAfA5TELl9jSRQyrG/k=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2acf3f29-50fa-4295-af21-08dbfe567316
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2023 16:45:45.5896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p5peMbU1GCqidlnlwBEpdWLHeL7oVrOXzI0Uon0pjxc8IKtMrJXd678M+cd5Sl/C4Fq2WaI6OlVvcCUOsVpqsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR10MB7041
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-16_13,2023-12-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0
 mlxlogscore=925 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312160129
X-Proofpoint-ORIG-GUID: dAozHRWWJwOIIZ7BIQu9nI-HF-zZSeRn
X-Proofpoint-GUID: dAozHRWWJwOIIZ7BIQu9nI-HF-zZSeRn

On Sat, Dec 16, 2023 at 04:53:23PM +1100, NeilBrown wrote:
> On Sat, 16 Dec 2023, Ahelenia Ziemiańska wrote:
> > On Sat, Dec 16, 2023 at 03:27:16PM +1100, NeilBrown wrote:
> > > On Sat, 16 Dec 2023, Ahelenia Ziemiańska wrote:
> > > > To make it self-documenting, the referenced commit added the space
> > > > for the null terminator as sizeof('\0'). The message elaborates on
> > > > why only one byte is needed, so this is clearly a mistake.
> > > > Spell it as 1 /* NUL */ instead.
> > > > 
> > > > Fixes: commit 1e360a60b24a ("SUNRPC: Address  buffer overrun in
> > > >  rpc_uaddr2sockaddr()")
> > > It isn't clear to me that "Fixes" is appropriate as that patch isn't
> > > harmful, just confused and sub-optimal.
> > I definitely agree, I don't like Fixes here at all,
> > but I don't really see another trailer in the documentation
> > or in the log that could be used for this.
> > 
> 
> Make up a new Trailer? 
> 
> I would probably just write
> 
>  To make it self-documenting,
>    commit 1e360a60b24a ("SUNRPC: Address  buffer overrun in rpc_uaddr2sockaddr()")
>  added the space for the null terminator as sizeof('\0') which is 4.  The commit
>  elaborates on  why only one byte is needed, so this is clearly a mistake.
>  Spell it as 1 /* NUL */ instead.

Agreed; if Fixes: is overkill, simply spell out the commit that
introduced the issue in the patch description as Neil does here.


-- 
Chuck Lever