Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp547373rdh; Tue, 19 Dec 2023 06:48:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAZs11JQiG/yvg8tNXLqz3B8XwRTDozjI6s1/1IK4aRm/h/k145+8iVd3iuwPb/qxIWbw3 X-Received: by 2002:a05:6a00:2992:b0:6d6:4ffd:8dc with SMTP id cj18-20020a056a00299200b006d64ffd08dcmr2453177pfb.62.1702997325565; Tue, 19 Dec 2023 06:48:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702997325; cv=none; d=google.com; s=arc-20160816; b=ocX2hVI1FvWZctK3Wl8a0NowjDhzMIQIM6yqHtoFl1JBpiu9VUzNbY1azt94tjhK9p MRfg2R630bOiTS6uqugF1AfrmQfZuEDjnkjxH9ayh09jMRmOrgDCWAGNh6g2nrB56lky y00c27oY6qWywOvdQNRfIJpU+Vd/w6bXnzTiHxf4s9+bqgcg/6w4mIckKOio3o1NiCIo TSCZotklhXyrDlNUYmRO8fTwvKo65/kZ94hL9W9rgkBHMw5wS3K7yMRahvVrQ38Bp5pf 2wcl4ZSnwvNhknsO15WzczSmUnq3Aw67rFJWLs9ZoCDzFbXVyGfq5ikVkxl0B9FLxlps pRnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:cc:to:references :in-reply-to:from:organization:dkim-signature; bh=UWtsZhR3mqpEo9xJldP9MDyJRchqzHme83vu4hlTHKQ=; fh=oTSheoojIQWE85h15wIbFV5tdQ792s9VwZPsELvSY7c=; b=lu5TkdKkYVllh1S950ry0zc8dOFkCTVuKWFpfox4cHCi7qD35cbpDtxek61DQBrAs0 jv9/XB6BQOJNeAtIFr3q395VygxcipdSNk2vYIIiQQgmyVa+0r9WwoJqI2UePNNUOIVN YPR1duhHDJhqbPVuVaPHu5DPR8vulsGWONCtmyXAIuneJTPf8U/RnNhLIGbMvEDSCR7P Ovyy0p000TkNkhLByymyVIPzED5F3oLIy6U8VpEnKNDax1Oa4iqtmUdoJx/a28YwhE6I sRuDzvxKHbBacjE6KrS222KB83uUyNcWFzSR1L1Mm+aDBp2aFj2rjhIR9rDa7V7KFuHA mv9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AWdQBVBT; spf=pass (google.com: domain of linux-nfs+bounces-708-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-nfs+bounces-708-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i186-20020a636dc3000000b005cd786d8e3asi6239866pgc.133.2023.12.19.06.48.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 06:48:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-708-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AWdQBVBT; spf=pass (google.com: domain of linux-nfs+bounces-708-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-nfs+bounces-708-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3C1F1290078 for ; Tue, 19 Dec 2023 14:48:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA8BC1C29D; Tue, 19 Dec 2023 14:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AWdQBVBT" X-Original-To: linux-nfs@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 596641BDDE for ; Tue, 19 Dec 2023 14:48:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702997315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UWtsZhR3mqpEo9xJldP9MDyJRchqzHme83vu4hlTHKQ=; b=AWdQBVBTR5YucDsOiCosCy/2z/Ro1QR1Fdth0EJPk7WvPANriYDhxMrGeT57wfj6t8VWQc EkuEjh1DILZNwMTvQ79uiXovK2ZTUX0WuKL9UmmFGzDY7JXLIR9lWfhSrFRbuo8Er/yGqv h+5DYN71eU0UxIjgze095ieaQ9ORF5c= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-Vp4WzdsaO4ChcYxqYCX88g-1; Tue, 19 Dec 2023 09:48:32 -0500 X-MC-Unique: Vp4WzdsaO4ChcYxqYCX88g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5FC511C0513E; Tue, 19 Dec 2023 14:48:31 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.195.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 936FD1121306; Tue, 19 Dec 2023 14:48:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <488867.1702996927@warthog.procyon.org.uk> References: <488867.1702996927@warthog.procyon.org.uk> <6f8c3f22f77e9e0154f4131260559c39d6740678.camel@kernel.org> <20231213152350.431591-1-dhowells@redhat.com> <20231213152350.431591-19-dhowells@redhat.com> To: Jeff Layton Cc: dhowells@redhat.com, Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 18/39] netfs: Export netfs_put_subrequest() and some tracepoints Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <489636.1702997307.1@warthog.procyon.org.uk> Date: Tue, 19 Dec 2023 14:48:27 +0000 Message-ID: <489637.1702997307@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 David Howells wrote: > Jeff Layton wrote: > > > Erm...why? Are these called directly from module code in a later patch? > > Yes. I'll expand the commit message. That said, only trace_netfs_sreq() is required. The other two can be dropped. David