Received-SPF: pass (google.com: domain of linux-nfs+bounces-721-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 20 Dec 2023 09:22:59 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 18/22] nfsd: kill stale comment about simple_fill_super()
 requirements
Message-ID: <ZYL4w7Mk3ahkK8eI@tissot.1015granger.net>
References: <20231220051348.GY1674809@ZenIV>
 <20231220053013.GQ1674809@ZenIV>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231220053013.GQ1674809@ZenIV>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?5nJ2ToPFk1Q00NALCrhDytgKwcZwfJad2hIO2CtgXgdyRR8mqDDZKAq3BkMv?=
 =?us-ascii?Q?UDIiiMUKWWrP9BR+BsraPbmSlNAK2/PABaH1BQSifXE7DNtFEN99MAWBCjF4?=
 =?us-ascii?Q?CftirjdLEgb57/symU0Duxfp1pHtHyJFTDGrMYlzfNxaZK89lfsVhPp1JWne?=
 =?us-ascii?Q?nw8Uv5jFYA73Qh4p2m2CZ04CY5p9YpoXXiKS6QUKZIMbPRTQByNLaXEL97wK?=
 =?us-ascii?Q?Jo7IQLaQMhqwp4+KZMd8ThPs4KJSvrRtYXyGphjRsSqkGiktNl+mui/yDyyR?=
 =?us-ascii?Q?jbxctTPhoez19O/thnKZubGSnZmknPf5tN74vlnhquLea9OyLqm9gvd1MSrT?=
 =?us-ascii?Q?yy9CZkhTktGhf/mEpZhLsFQFkyIaLG08SmK/f8kYbsHVKtuuy/feuc5S7Tig?=
 =?us-ascii?Q?9j3vvk0SCWtJA3P0hNIjvIR6vZcAnu6KhBTOPKCOKnOPFG3JrQOPbCnsAnuL?=
 =?us-ascii?Q?BFCHpLJyKwHe71LbRD+uSo2rmXKR2wQidF8dcv6FqzjR2/TW7LpAZPiefjVT?=
 =?us-ascii?Q?eEH9h8YIjxKvZ8ECnVc1n5q8QPMfmu0I8MRBa2XJKdkC3VgTGs5mdhM7naoD?=
 =?us-ascii?Q?WFQRlTWh6Bl6uriifhwoqyEf6Pu7CPkQaUqLwWb1l50aiwX09Tm8i4mIRXL4?=
 =?us-ascii?Q?8vVZycahP8sF8uMBEw6bGn1+UqK94NKur+oB4grBi16XiSAFyEHswwMNIPjt?=
 =?us-ascii?Q?Xjj0H7lOlblxk+ALSqrmeNArU2+Ue5eVB0ceAOXrnMAcpVMN3RHlHj7vvqI2?=
 =?us-ascii?Q?N3YSjG5Vh9rw5gD98bsrN7Qz5Yua9LSI5t4J7EFX+9j7k3nQvT10HuUHnSKS?=
 =?us-ascii?Q?Zyvbg2UuTD5uXOWYpcxzdEfpT2YbrFnLa6oTl26+kjoxpQt6ctfWA1oVZDmv?=
 =?us-ascii?Q?GRwH+XHNm6ZGNR1NzDASZI8tfIltC0LoCmyo9+OrjVqybDhr8tgP+O2I8xIh?=
 =?us-ascii?Q?USHekisYjFw2dvISTg5COlRqFWPrB1Pw23xdt4tSZaqE4EIh2+wW0v6Ykwi3?=
 =?us-ascii?Q?voIuHUXWKnuej0OtqBrZ9goe76+Jw+L5vkcWAQNeLzfCFtUfQue3F4+shWeg?=
 =?us-ascii?Q?1RwPvNaovIChmoj/YX8j7ea74z3gTuvWMrSL8CT3vGCeT1eojUAW3PL+twLa?=
 =?us-ascii?Q?cV65ytjVry/1bvH5/SHNSqHpgTYQ2esVVq3CBc3CQbbpE5UvnHXZw7Jsymu2?=
 =?us-ascii?Q?R2y7zHSUR72i5XwgWrk24tg4bkdMwzAeT18A7oSnsd8hJZcGuFNe1w3+raYK?=
 =?us-ascii?Q?NCgibyQnLnsaHAkPWRjGgH48qSLjCpFeKDuZAfMkaJsNkuZdnau19dEZVuG3?=
 =?us-ascii?Q?hZooq1Zt6P/ER0mpybzh7NqC9zSXpycDVZ0Xkeg0yEwqxFls4V4dS6kozTrN?=
 =?us-ascii?Q?Gx6Ts6n6nfq4Rb1GMwk4t8+3SvqXMEEBtZSAAhZX8JFB6hrE+/ni/lLkRVH9?=
 =?us-ascii?Q?2bQt6VEwOu0yOTk9/A1viMYMIwQmh2S55AOnIXjLka+hzfljdMnDs3nW5Eq8?=
 =?us-ascii?Q?j80/ueyPS6UM/i00z9Li3w9hG1WTBV/is4ayD8PQqp/VBOG/8/LFgeNCU1uO?=
 =?us-ascii?Q?hfVU+sdZ/sThWise32ixJqFRpMWoZxy3We6JzQZomTc3oVo+PueCy5FJz2jm?=
 =?us-ascii?Q?Dw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Eyub28a8VaBTtsY2/r4D8wScE4mbiEdgVkN3kKTdCZyQ/pS4AyqtTKEKNrPLN6Bo4zmRefKtW5TA6yVOZyLiYUUAN9PAUmcWb3rEG5qjLR8y7Wi8DPuel4+J5/INMF7xZp0tCJXirRrqOHywElNK7R21zDCfoRUbqLVcS5ITwJ/uNbIbPqKoHH9vbFtRFlJGWQNmf7acbrGrzRuLxLHJG1EuYZVvE50D851iqzDOXgsVnuG3US0zFy/knllz+15zqzzBGgeiUlXV4XjOKn3lLXut0LxBwXAOYK8EvSmlISQOPJj6vSddVt6u5hZp8i40/JuEDViXb8wqKdRrwjVUkKMbY1N6V33ZqWSGGNhXIEVTqP5NWhdqLnexD4XYIAw2oogjpuyq5iH839njwtNCxnQnz7cR/uwH6HhHrOECQ8baWUwPy5TqmtCVdFbT3YFHIvmtR05zVRGXfRHg2yrekMJM5VvOzPG5Vcu3OdYqIQc8TV/9nQosyjq7HqRXQqqKHSUl/XfLz1BmFHBn1C90I0vLX7bhkBGmx9g2PWyzWpV8QH8jxL1vg003jS+Zn/QPVPGoOUgwwJJ69/a2GZlo/sujqI/ebpIZNZYOxMjj1LM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc6c4502-ee9a-45a5-f675-08dc01672cb9
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 14:23:02.5022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wsmVyBh8SROp+mn4FljdWgF0+O0bmoCMytX1e/lzMwPqtd7DijKAF0P2td65IyTH2fk1aejRJxKa3neA9E6h5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4196
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-20_07,2023-12-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0
 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=794 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312200102
X-Proofpoint-GUID: d-nt_7Io5uIqzLEQTKy1SR35fG-CcT33
X-Proofpoint-ORIG-GUID: d-nt_7Io5uIqzLEQTKy1SR35fG-CcT33

On Wed, Dec 20, 2023 at 05:30:13AM +0000, Al Viro wrote:
> That went into the tree back in 2005; the comment used to be true for
> predecessor of simple_fill_super() that happened to live in nfsd; that one
> didn't take care to skip the array entries with NULL ->name, so it could
> not tolerate any gaps.  That had been fixed in 2003 when nfsd_fill_super()
> had been abstracted into simple_fill_super(); if Neil's patch lived out
> of tree during that time, he probably replaced the name of function when
> rebasing it and didn't notice that restriction in question was no longer
> there.
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Acked-by: Chuck Lever <chuck.lever@oracle.com>


> ---
>  fs/nfsd/nfsctl.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 3e15b72f421d..26a25e40c451 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -48,10 +48,6 @@ enum {
>  	NFSD_MaxBlkSize,
>  	NFSD_MaxConnections,
>  	NFSD_Filecache,
> -	/*
> -	 * The below MUST come last.  Otherwise we leave a hole in nfsd_files[]
> -	 * with !CONFIG_NFSD_V4 and simple_fill_super() goes oops
> -	 */
>  #ifdef CONFIG_NFSD_V4
>  	NFSD_Leasetime,
>  	NFSD_Gracetime,
> -- 
> 2.39.2
> 
> 

-- 
Chuck Lever