Received-SPF: pass (google.com: domain of linux-nfs+bounces-722-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <368736f6-7eea-481d-b61c-513df246c554@oracle.com>
Date: Wed, 20 Dec 2023 08:45:59 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3 v2] SUNRPC: remove printk when back channel request
 not found
Content-Language: en-US
To: Chuck Lever III <chuck.lever@oracle.com>,
        Benjamin Coddington <bcodding@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-nfs@stwm.de" <linux-nfs@stwm.de>
References: <1702676837-31320-1-git-send-email-dai.ngo@oracle.com>
 <1702676837-31320-2-git-send-email-dai.ngo@oracle.com>
 <66BB600A-2C0D-457A-9A13-0F1D7F5E44B7@redhat.com>
 <A958C4F7-7DA4-4BA2-BAA5-9552388F5498@oracle.com>
 <689A6114-B5B2-47DF-A0D6-6901D8F52CBE@redhat.com>
 <AD542840-D60F-4446-8669-13123FF00703@oracle.com>
 <217964D3-3808-48E4-A879-37E4D5E463C6@redhat.com>
 <30058A8C-7A1B-4C48-A13B-B071424FADDC@oracle.com>
From: dai.ngo@oracle.com
In-Reply-To: <30058A8C-7A1B-4C48-A13B-B071424FADDC@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?UFdkNFpNMEhCS3dZNUg5bS9rbmJ4M1cyM1NTcktMVFUvRWdFV0dvbUhieE1E?=
 =?utf-8?B?V2tRb3N5RUMrQU9kMUJKLzlKa3hWckFSSnN5NmZCQ2h2bnlQSWhVRGZWd0hm?=
 =?utf-8?B?K1hpUVUyQytXSVhTdjJsNzZGZm4yRWRlNjliTzRIcmc5K2JucHhYbGJsOGh5?=
 =?utf-8?B?ekxOeUE3bDBVeFRFRTdFVWcrQWdLMEx0b2loTlh0eWpyQmx5S293b3BsWGNr?=
 =?utf-8?B?MWFndUM2QkZvZ3hMQ0pnaFc1Y1E5UUUvSlIzdjJlVTlnd2RsWDVCUVRiSDdZ?=
 =?utf-8?B?RUF0L1BxbTNsckQvRDUrbm8zdUZ3SGNkUXQ5eDh6S0p3RDkxbGIvamp3NW84?=
 =?utf-8?B?eGhUL01JZk9TRC9CSWsrcDVwUWZySkhyK0I4NjYyaUxqU2NVMEtieFE2TnF2?=
 =?utf-8?B?MUp0Yk93SWM1ZHJ6cGtWMkl6OVNYclgzOXVwWFRnNlNHY3AvZWpiWk14QUdD?=
 =?utf-8?B?UnRRdzNYbWhqTDB1TTl6MjFFcmlHelBZZVNYTm41RnVRVlozaDF1T0N1WHYw?=
 =?utf-8?B?U1J5UDlmcHBuNng4dUNIRFRvTmFwR2ZiVTlNRkdqQ3FoZ01ESTF5RGJvdDJ2?=
 =?utf-8?B?ekU5cHdPN0ZrSkFvYTg0Y2ExemJSMUxxL0NsM3AwTit0VGozWVFJSWRPWjFW?=
 =?utf-8?B?QkRhMnIyeVMzcHJ5MEZWL0E3YXkvNWJISnN2VWRmL3hnQ1NLbmt3a0pnNEJF?=
 =?utf-8?B?RjZZRUtnSFNQdDY5Z2tmVFFOVWxodnlWOTEwT3lxcHBnSDc1c0NJczVvYTdV?=
 =?utf-8?B?M3pad1FKalY5U01sWVJSK3JCNDFsZy9ma1RDZzN5U05jTlV5ZjZtbEErQUhL?=
 =?utf-8?B?WE1Fb2hmYmprOTNWNWQ5Q2lnbWNaUzJMWEQ5L1hJRGZZcEpZZmZ5RGt4dUlT?=
 =?utf-8?B?V0lUNXVTRUtLU0dscUw4cWdISjFRbitXSVd4amNwN0lGYVFVOXgxeXUzd2xD?=
 =?utf-8?B?ZHgxQ0RCZHVENUNqYjJFQldqK2xVQ2lWdll0NDhBdU50R0M0YlArMUF5a0tk?=
 =?utf-8?B?c2RJK1h0akorbkU3d0NLVDM0QWltcEc4dXEveWp5UUprSmd1RDE3OEZiMUh4?=
 =?utf-8?B?ejhjR2lqNm83SXFYQk5rbW1MOGhJakdUSDdUdGNNR0x4UkpzVjZPNHFGNHRz?=
 =?utf-8?B?b0htMzZtZ1pQdzEycFFZUUw3ZUJIU1V3aTNTSS9MaU5jNnZhdmVRZ1d1Wk4w?=
 =?utf-8?B?L25qdmVvOGl0LzVWMzVXUmppYkZ3Wk5VUFBFRCsrbTNSbTNVakRvWFJhTCsv?=
 =?utf-8?B?UE9hYmVUUmtrWFlYZ1pMN21Mc1NBTkJzTHJvR2VwNmcxNVdoMzFTQng4WFo1?=
 =?utf-8?B?MUo0dDcyNHpTN1ZERGs0S080Qjd4UlI1Ni95Q0lQSE5kUUx3QWY4UEo1akIw?=
 =?utf-8?B?MHlBclF1MlBYamNRSEx6a1NpRG1yVXR6cisycEN6WUtQRWxDT295ZDBCWTBM?=
 =?utf-8?B?R3ZLVXJjd2t6Y0RHUmVnR3ZmeU90c25iT2M3eXZkbEVMVVc1WVB5ZWJoRHZP?=
 =?utf-8?B?Q3QwaE8wTnoxN2FkL0FNT01pbjNvRFJWSy9tNG02U3hWb21ZcG9lQjVUY2tY?=
 =?utf-8?B?dUNHdHVIUlkzMGpqSjQxTjFyWDFqNWNQdWM3QkREUG1hUU9TdGt1QXF5bSta?=
 =?utf-8?B?YTVuMkMxRVVTVk5lVG0ySzlicHI0NzJZOG9MSGVxaG9XSS94bkhGRlFwZ2Fy?=
 =?utf-8?B?OGhuQVVZQVJyUlg0aWgySzYvYkhMQnZBRDVPTGhUR2Z3NGxhNjIrTFNhZ0Ey?=
 =?utf-8?B?RnJ3LzFQNG4xOWFQazE5bFA5a1JheC9FUmU3cnkzN3ptbTlYNXBWYXowN2tN?=
 =?utf-8?B?aGdWWFdza2tmY1dWaEpFaGRRTHRSbHIxSEc3ZVBpTW4xbThkTHZ0WUxXVDJI?=
 =?utf-8?B?Tmt4VFJCcm0vYTM1YzdCdkNGWVJDem5GSXVVaDh1aGJGR3M3cHRYSTEvUkRZ?=
 =?utf-8?B?N29DeDRaWEd0dmJsZFFEZWxwOFVEWmVGQUFJVXZkUTM1eW9BNExOaGxBMURV?=
 =?utf-8?B?eTRpTTRSS2kzL0NoT0E3UW5DOThGei9sR2x3U0R2MkQyekd2dlZBd0gySVYy?=
 =?utf-8?B?SmxkNDI3SzlxV1hZcWpxSDFBclFrMEdzeXRrMVVwSHFyM0lVNldlejhsMG5V?=
 =?utf-8?Q?lJyaA4m+uujevJI0+BjS4/GO1?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	48ORbVNT3wt/kN1RKkiT4Q2FcsR2Oa1AA7a3aLTBfd0HxerRNn8BqYxtcSAAIslzIiM+a6WeuSuaqXCen5vWVXXZc3PzcmdnYdOS/NQGOLuEVBLYSYBivuOR2crxBJ6w7G+CuRNvolNax7gheroh78XPB8f6qGT0R88NtAJLIumf0nFfeZkGgAuEmvz6+B02IF1UXAcRXOhsVUlg4T3+kmYVgzuoULgCQiu1i0Cyyh3orAFd3px/FIEPvixIZKFOjPu4sMECt5YvLr//Ea5+x2yZv5ddKvx1p+QxVvW3U7P06iw/BoOgTWPKauUwxMyqnZqwV6X7e+YpSYLXcNHNovTt2CBDWvfKWkwRpA+AnIIM1QCouHNpU/yQFFz39B1kRTW5G+UUuK2WndGUxDXUez6m8IswH9O0NeuhwFnarL0wB00csEfZjm54Nbcp4EbTWzSQSwj/cTPjCZvQtYpV3iHcXlxx1YIiH1+2FzgX300PlEJlRQ6SxTQpyneS8pEMqn4c7lIVVhoxsy6l6WqhmYKrgGdet/uRDxcO7HpAmD9b9myW24MZpE3c3OxoUQ+5QmR5pN7egbyvawbDeXnuSX9AGUGWO/xXN11kMcvenXI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebbfa667-151b-423f-e141-08dc017b25f3
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 16:46:01.1473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AuJS4fd7Cd2vH/Iytl+6YWp0rsKKNiz05D7KPkpP3xEnw2g6mCkUB1yIWcu2oo08xfWaLBd8FI4gPeXEE1A4mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4702
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-20_10,2023-12-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0
 mlxlogscore=988 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312200119
X-Proofpoint-ORIG-GUID: rIsXv6Yokh4l0kSkdGLWDKoh8V2yBujB
X-Proofpoint-GUID: rIsXv6Yokh4l0kSkdGLWDKoh8V2yBujB

Thank you Ben and Chuck,

I will add a counter in svc_stat as replacement for the printk.

-Dai

On 12/20/23 5:54 AM, Chuck Lever III wrote:
>
>> On Dec 20, 2023, at 8:04 AM, Benjamin Coddington <bcodding@redhat.com> wrote:
>>
>> On 18 Dec 2023, at 10:05, Chuck Lever III wrote:
>>
>>> If you have one or two bugs that are public I could look at,
>>> I would be really interested in what you find with this failure
>>> mode.
>> After a full-text search of bugzilla, I found only three bugs with this
>> printk -- and all three were cases of kernel memory corruption or a
>> crashed-then-restarted server.
>>
>> It's probably safe to ignore my feelings on this one. :)
> Thank you for checking!
>
>
> --
> Chuck Lever
>
>