Received-SPF: pass (google.com: domain of linux-nfs+bounces-820-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <9b5502ec-eee0-4ae7-bdc5-2bcaa3cd323b@infradead.org>
Date: Tue, 26 Dec 2023 16:10:49 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] xprtrdma: removed unnecessary headers from verbs.c
Content-Language: en-US
To: Tanzir Hasan <tanzirh@google.com>
Cc: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>,
 Neil Brown <neilb@suse.de>, Olga Kornievskaia <kolga@netapp.com>,
 Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
 Trond Myklebust <trond.myklebust@hammerspace.com>,
 Anna Schumaker <anna@kernel.org>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, linux-nfs@vger.kernel.org,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 Nick Desaulniers <nnn@google.com>, Al Viro <viro@zeniv.linux.org.uk>
References: <20231226-verbs-v1-1-3a2cecf11afd@google.com>
 <fadeaa0b-e9d2-4467-97ad-63ba8f7d8646@infradead.org>
 <CAE-cH4rc6gWNcsgm243i=dXQhaAQsC4gEz15GEWZO4HB7Vki3A@mail.gmail.com>
 <12958640-e6c0-43d3-a710-48ba7873c8f5@infradead.org>
 <CAE-cH4q2L4C6SHikUD5Le6K7T7Y39S9K1yvSFWvxCWq2crEZ3A@mail.gmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <CAE-cH4q2L4C6SHikUD5Le6K7T7Y39S9K1yvSFWvxCWq2crEZ3A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 12/26/23 16:04, Tanzir Hasan wrote:
> Hi Randy,
> 
>> Where can I find your current working list of what/how to #include?
>  Here is my current working list of what to #include.
> 
> #include <linux/bitops.h>
> #include <linux/interrupt.h>
> #include <linux/slab.h>
> #include <linux/sunrpc/addr.h>
> #include <linux/sunrpc/svc_rdma.h>
> #include <linux/log2.h>
> 
> #include <asm/barrier.h>
> 
> #include <rdma/ib_cm.h>
> 
> #include "xprt_rdma.h"
> #include <trace/events/rpcrdma.h>
> 
> There was a discussion here about when to include asm/asm-generics:
> https://lore.kernel.org/llvm/20231215210344.GA3096493@ZenIV/
> 
> If I misunderstood your question please let me know.

Yes, more the latter link for general info rather than the specific
info for this one source file.

Thanks.

-- 
#Randy