Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp3869615rdb; Thu, 28 Dec 2023 02:48:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5uJGy68tMclXpB8+KvNBU4A9IhEwyWWAPPL2RrZK67xRCSJiHZA736KTSCubqQNzu+Rg7 X-Received: by 2002:a05:620a:c52:b0:781:80eb:ab64 with SMTP id u18-20020a05620a0c5200b0078180ebab64mr220286qki.84.1703760481035; Thu, 28 Dec 2023 02:48:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703760481; cv=none; d=google.com; s=arc-20160816; b=jY4z5VJfYAyFbNohDahP9SqVCkUaoCIseV3oFDc7LccRKqNweBHNOixKGo1CDFK1yq pBr3oss/5kh4ixm3m1BFbUXte/xuqS3sBqME3XRHLPzvZudTn4xI3UkeLC03OKICW1c8 Jp0aAVuDIpOAcstORheDudxsYYlQLkVUuMYr8bRfhFdnmDOb7DyYBdd3dRan59D7DANx stSTIO7kENqFeNTpsvRgHjPZPXmcFJI0mCdusGvEgh+asDfA7q/yeEK5ThKWnVh5ikfs 8w/9Ts8iLNw31maN50PeTMYMtC75XHGWRQtkPzUU/fbfWWkj3sVfeP2yd+pL13gkYe/0 05mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5Oj5V39vAkN1/+i+CrgR3hM1xoyNKUjIkt8y2kK2itI=; fh=5Z3pfAoMZNndV1sWRwAjuHw/DG1o/3IFEtVIxqEr4BM=; b=FcdcfAJsqb6wwYlKGQYg4fWzYXNgV8wXEwQIC5rmmmanlq0UPIfh0ZvKu2R5exb0Eb jB8VUntX+x4gLE1PeIx4ZKYsmbHLZu5BlDdKMhQRk0i5VPRcSSkOQ+gZEW/9mcx+Vd3R S2AhiYDQsrU+IANelpS5Ga6LmmGRSr9i2AVqfZOT0KIsO+vVHJD/IwE0dUQKCSCMF1kJ SKF6phBRWBXoJc3u5B9USwOEQYCASJ9YekJ+NJNKC/XDC+GP+C8/1mE8+lau+FuZXLvv yxOZ2etEbBHXXT1hAjiJaWN0ZlPVW2vOFukwCggLv6aC1pz5pz96llRlYbmNyvwPoK0e G0ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=N0lbqOyo; spf=pass (google.com: domain of linux-nfs+bounces-828-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-828-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id de26-20020a05620a371a00b007815b97b448si4490473qkb.524.2023.12.28.02.48.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 02:48:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-828-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=N0lbqOyo; spf=pass (google.com: domain of linux-nfs+bounces-828-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-828-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C50501C214D8 for ; Thu, 28 Dec 2023 10:48:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AEF446ABA; Thu, 28 Dec 2023 10:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N0lbqOyo" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67AB46AA4; Thu, 28 Dec 2023 10:47:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32363C433C8; Thu, 28 Dec 2023 10:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703760473; bh=5Oj5V39vAkN1/+i+CrgR3hM1xoyNKUjIkt8y2kK2itI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N0lbqOyoJyeMAeYseh2byh6ANjb73lLSFoo/4Vf3UE84vYDk1TieZPcsFMbb0loqB J5c41nJjfroqg+lE9GGc0kOGcMTJxCy3AYauRg4GYPutMX/m+iGhLmhRqkfKY8IoEv HQ6gkkpXqpfaUSwSu7V7SK0kirgYW//TghKZrO0OFcZ8vFivTervREY8Iia7YzaARU 4nrS8pD062BAXhO50kSt3MeaqULSjKL976XU3bOxCS4tcxu9/yoI/LjuylHOVl+oXi rYFTNFdvU8qGKDS84wZ+xsCp/I0UcygpkM55NDFDntoL8POVYFgAFXl/4qpQMmPknr lSRN3+TRLr3ug== Date: Thu, 28 Dec 2023 11:47:45 +0100 From: Christian Brauner To: Nathan Chancellor Cc: David Howells , Jeff Layton , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v5 15/40] netfs: Add support for DIO buffering Message-ID: <20231228-wohlbefinden-museen-c5efad4e0d84@brauner> References: <20231221132400.1601991-1-dhowells@redhat.com> <20231221132400.1601991-16-dhowells@redhat.com> <20231226165442.GA1202197@dev-arch.thelio-3990X> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231226165442.GA1202197@dev-arch.thelio-3990X> > This will break the build with versions of clang that have support for > counted_by (as it has been reverted in main but reapplication to main is > being actively worked on) because while annotating pointers with this > attribute is a goal of the counted_by attribute, it is not ready yet. > Please consider removing this and adding a TODO to annotate it when > support is available. It's really unpleasant that we keep getting new attributes that we seemingly are encouraged to use and get sent patches for it. And then we learn a little later that that stuff isn't ready yet. It's annoying. I know it isn't your fault but it would be wise to be a little more careful. IOW, unless both clang and gcc do support that thing appropriately don't send patches to various subsystems for this. In any case, this is now fixed. I pulled an updated version from David.