Received-SPF: pass (google.com: domain of linux-nfs+bounces-878-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 3 Jan 2024 09:42:16 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Tanzir Hasan <tanzirh@google.com>
Cc: Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
        Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <dai.ngo@oracle.com>,
        Tom Talpey <tom@talpey.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Nick Desaulniers <nnn@google.com>, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2] xprtrdma: removed asm-generic headers from verbs.c
Message-ID: <ZZVySJF2rXI/qJQx@tissot.1015granger.net>
References: <20240102-verbs-v2-1-710de1867c77@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240102-verbs-v2-1-710de1867c77@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?l7+iNuyS/cBsrb7YBOE34f6rseslaRKBosHEbffUShKsppbq3bndXQOmTBx+?=
 =?us-ascii?Q?Vx3JExUMK7YRMBsi96RPYilmsA1Xvj9GInv+rQA6icSPog5bylHqUF2+BWqu?=
 =?us-ascii?Q?M5eV+X8TjI6MT1HNFaIcClms9lLTTPq8RMEJNzijQrQ16lRUYx5wyptK8YLf?=
 =?us-ascii?Q?sUy+oyFpmFLTCTN/bNQYsgEt3zlcWsUaI46XJNLUXRoFjGEsyHxg7UBTqw4L?=
 =?us-ascii?Q?X/RTr0VYOVjI6xVTwfZxVhThL6PV5BgXJw0VGQq3KUFjy0yFF8PYEHtsR5RI?=
 =?us-ascii?Q?GFm4lzXQ+rGtKSAX0XDWZ8D2tXtjY/JWsjNLiEwzYoVbw6hT96AUiO8NUo3k?=
 =?us-ascii?Q?x84pjXkQvPMPF+PBPavLw/0t1CnnZmDx6u4npOSSWsnfdtm1Q8RPFjpo8RAr?=
 =?us-ascii?Q?ZN89HDpIppRXmAthFfL2++7tW3z+U17PdGyKtlFcnu85XqfGIIrPzRY2kTEd?=
 =?us-ascii?Q?EehnQfxR6o8cVQkStsEG9+AgyDkepDzrlMsNmI2M9P1xzyLM+YmT18Ptba+8?=
 =?us-ascii?Q?qWFy/kLKACIpB9kaA6zBmbK7uJKFPF6gYrsK50w6SN0IIoqSSFF5SFSy3QF3?=
 =?us-ascii?Q?7/FDLRKzk+sKfz8P5PU/vWwvkW2tnD1NEYmLuB5k7OGOxAweczaxBCJlHq77?=
 =?us-ascii?Q?T1uvnby2ezFiDsoxMf/6SqA6nnx6WnuEeGVUVIqv/V8lrXMcdnP/rQalU881?=
 =?us-ascii?Q?g/JHHjZ4woX/MTh08N1qi47GCAPmp2zZP8jsevY0kmIETwjOy8iFG7Bz7V3M?=
 =?us-ascii?Q?YPz9LYqPazxh1TTugruIAA1Zp0A4Yuhj+iumDY9nV523D0kUt/GKr1jGZBs0?=
 =?us-ascii?Q?xuxoB8LBB2tDwW5mrc376eCLFx/O1Ae9MLBjdxO8XFA1W32M+GNvjOqBioQ3?=
 =?us-ascii?Q?XcCQfx9D9R61WzrgXsH7TIyN2I27eK00qzfSkzRjTt6qUlBowvhqRnObafhl?=
 =?us-ascii?Q?2zqcAlQzV0Le3naEQ0e8DZ3LntjWr+jgXTYGLZwWpvwLOVayRh5jyoTtxajc?=
 =?us-ascii?Q?o+QFxHoXEJOFplcrqLYeYQA2l9eMorXNu3/Yyv2D/ddyDgikeeXF/L/uUP6D?=
 =?us-ascii?Q?Hc1I+wNKY7Cjgd1TmhrXLakY4IcIAqaIrM4rytqV9ymJtfuHfq+wZGdvdWMO?=
 =?us-ascii?Q?oBhj3OxPq8rwhM2C+FZJ9F6Vb64fCuTapKCJzWM9MihVPUik7WC0tRrocejK?=
 =?us-ascii?Q?lun5lcsZ6XRlQGemuvlP0lKNoRvJ2aWUlviISjCB5XiVwAQx3kqzQ1MiFBE8?=
 =?us-ascii?Q?wWVkRzpO3RceufT6PGA0pXo/izk3t/4VrdHuED8SKkGC7PJyH7OwSaPUxOJu?=
 =?us-ascii?Q?OwmlHv9AxWcuam/ESL1UmE8IuZUJjlCaJ8JmvExmZjrcIm5V1p8FlS2lPo+x?=
 =?us-ascii?Q?ZjJqBzWXytf/0KjNfTb4lUlGhAIxP5LPfVJxpY5e+CeL6FzZzxWqKUnivWPt?=
 =?us-ascii?Q?om5aK3G9Vizaq9Y7y8NlJ7F2I2oLs6FPG9JII1fCMQ3VW77xdpsbzUeIU9P0?=
 =?us-ascii?Q?tndEPFb8dIojjMZaF4wWBMpZjJv2qWaKtvDnl8MXFCOtMsczUwgp9HNrZS8A?=
 =?us-ascii?Q?wBhp8Nw2ZfgDfKrZ67+VTPE22edbNNEeLYQBd0GQ8qvqutwQw8EjqDTSHqVy?=
 =?us-ascii?Q?HA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	kmt/fG3tzwAVEjWRQwgr7QLAmYI+sjM8C5jDUluOXK0DujDOvEJ2U0nLPBoj94MY3lawUH9rIIrOBCvwKZkdFkSqRUpVheR4vPDG4zMOHryaINiLjPh05pUjZkVQQhFq3k877omBY4u+3QK7PHw0W9CST2gvdaxB06EkAtW3NQBCrbq6HS4e3E8JP1aPLFWKECh88DZzzIR6aGCq/ezV4U8hVgVyA7iTOininCxVbch6lSNsY0Q6XoTG6ks/LFOXXTxYwqv2h9EeK9/Eil/EmydfuIKiMNqnATmLDOsOLI3nKnNp85CBcJXiWS4x3ifpJq2DfG0nSiWNOeqio/tUfzB0xiFeVy2PS7Y0/HX4auAPznqJhKaEMugCHdIMejRRYBRFDADsUeUx7KvmXLD6bojXQ0cSfp6gbCtEg88MR1RadVymBApDsZW1bFKO8ayFi0mYOtWRPYITtoVecBe4cGc8FsTQOv2GilB3ujjXdcqMgD7qJmNOgQzvJoJdAqcHt/eQyTYvNX1YfEu7soF3/O/iPIMYW4/YawS4+3KajjEJ2Tk4PRGYEibH4YpYxdmhNu64WLV1gmwkjYSJdOWg5fb0UJWunu3CufuQQKkPZ7o=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ee37611-c914-41f3-314f-08dc0c6a30c5
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 14:42:20.6778
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F6sw0Y/6GAsEWB5ksEsRXilhh87+cDayiI7UvDrmvW8oB2nIIc/KCso5btuuTVKt0mNIzPzljE2m4ryIWNWk3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7068
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-03_07,2024-01-03_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0
 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401030120
X-Proofpoint-GUID: B5ZDvTmzExakSGF31s3aWSKP9_N2OrWf
X-Proofpoint-ORIG-GUID: B5ZDvTmzExakSGF31s3aWSKP9_N2OrWf

On Tue, Jan 02, 2024 at 05:22:18PM -0500, Tanzir Hasan wrote:
> asm-generic/barrier.h and asm/bitops.h are already brought into the
> file through the header linux/sunrpc/svc_rdma.h and the file can
> still be built with their removal. They have been replaced with the
> preferred linux/bitops.h and asm/barrier.h to remove the need for the
> asm-generic header.
> 
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>

Acked-by: Chuck Lever <chuck.lever@oracle.com>


> ---
> Changes in v2:
> - Added asm/barrier.h and linux/bitops.h to not conflict with rule 1 of
>   submit-checklist
> - Link to v1: https://lore.kernel.org/r/20231226-verbs-v1-1-3a2cecf11afd@google.com
> ---
>  net/sunrpc/xprtrdma/verbs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index 28c0771c4e8c..b4c1d874fc7e 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -49,14 +49,14 @@
>   *  o buffer memory
>   */
>  
> +#include <linux/bitops.h>
>  #include <linux/interrupt.h>
>  #include <linux/slab.h>
>  #include <linux/sunrpc/addr.h>
>  #include <linux/sunrpc/svc_rdma.h>
>  #include <linux/log2.h>
>  
> -#include <asm-generic/barrier.h>
> -#include <asm/bitops.h>
> +#include <asm/barrier.h>
>  
>  #include <rdma/ib_cm.h>
>  
> 
> ---
> base-commit: fbafc3e621c3f4ded43720fdb1d6ce1728ec664e
> change-id: 20231226-verbs-30800631d3f1
> 
> Best regards,
> -- 
> Tanzir Hasan <tanzirh@google.com>
> 

-- 
Chuck Lever