Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7323329rdb; Wed, 3 Jan 2024 11:46:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcWESCrnbY5HUL+aCaDU46tQUxHm1tco7hDC8C1uIBEm7924O2dEQt0bWMjQbClDKQ0+2R X-Received: by 2002:a17:906:c2c9:b0:a23:dffc:8366 with SMTP id ch9-20020a170906c2c900b00a23dffc8366mr9107599ejb.88.1704311180822; Wed, 03 Jan 2024 11:46:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704311180; cv=none; d=google.com; s=arc-20160816; b=TOs2un5OkeZbzovYibwOviAnmU6nOq52gYG3oE63MMggYegV4ZnfxwhKtXo7qNWwNY YkK5TBZ3sG6lgstFE0NCvTRDA5pDxOs5x7UUm/ll6PeEHP3kkoOnVZ5o4SuivARAv6l7 A22VXkG59X5g0TuYwnKZ+lY1jVKLb6H+PzZxUrx/NAYMEBgEUWNryyISwp2itKjdHuTs JPq38NDbuDfY5QCrR2d8MHANyO6mlLgpTc+mFwcphYd/XmgEZORjrAjcQfzg4kSCZeLj qZjKaEVq/ORfbsC4rWIjhjb8o3WuXqeVhW1wJU0woMQ+M7S2P8KvUr03T08jKiMYgPsl OjDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=DYpAMKUEr4ZUo/A2V1G5Stqgcj7W2gBmNsNpjPAItNg=; fh=YFt8ChLYSQGlXnYiKesU5GH7dj077HEtLe3px6NEb80=; b=NSZ+RpLU/ZL0YypSQdPvdXv0mx6QYNdSLrvehJh0cblbhSsbhYR4WkpKXKslpg+jHc 0XqEsESUZ63EZCs5t9lev+lJyTguCT+1E3rog9qV8ZgmSoucgqGlcMKv1W08VLfwtHuF 3R8G9kbUk09GZrYugQoDHHSAkpLKA6HEbpTKYwsOVFcgqoulgEmAehHocigqXrEFDOZE S9o3YauGGEccF9COZwpezi495OX1frV3sohtVEmvqdbElLEUcoK+P03xS6G7deLJ/2c+ aXBvUPv4iCReXF9sd1p+IqrqNjpqJ0haGfggYq1I/8LZjAje2ebLN1vLOsVbqnxtJfSm 76tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codewreck.org header.s=2 header.b=wnu79S7k; dkim=pass header.i=@codewreck.org header.s=2 header.b="B4k+m/q8"; spf=pass (google.com: domain of linux-nfs+bounces-900-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codewreck.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id wj6-20020a170907050600b00a233dc8ebc6si11267143ejb.21.2024.01.03.11.46.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 11:46:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-900-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@codewreck.org header.s=2 header.b=wnu79S7k; dkim=pass header.i=@codewreck.org header.s=2 header.b="B4k+m/q8"; spf=pass (google.com: domain of linux-nfs+bounces-900-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codewreck.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8F1E51F2551A for ; Wed, 3 Jan 2024 19:46:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5AAE61CFBF; Wed, 3 Jan 2024 19:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codewreck.org header.i=@codewreck.org header.b="wnu79S7k"; dkim=pass (2048-bit key) header.d=codewreck.org header.i=@codewreck.org header.b="B4k+m/q8" X-Original-To: linux-nfs@vger.kernel.org Received: from nautica.notk.org (nautica.notk.org [91.121.71.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A44A1CFBB; Wed, 3 Jan 2024 19:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codewreck.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codewreck.org Received: by nautica.notk.org (Postfix, from userid 108) id 329E1C028; Wed, 3 Jan 2024 20:46:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1704311162; bh=DYpAMKUEr4ZUo/A2V1G5Stqgcj7W2gBmNsNpjPAItNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wnu79S7kdE+HWljFIVMAS7Vk67BpQzcH/o34qldo/6irXMtO+faoEAyINGHxImOXX 9GP17leT7P1W463WpEJZkyiolgk52RwUBvSDdgQYZSlPA93YktS1I4MZNigEYvKvBC Xk0YC9QAjdB9I5r1MXBi2OE/AsG90K1YZh/emHkgct2U+wc2yremZ4RwFLOcwAMujr 9sigwMmkv11kEXwB4THRJaP3J0I1fvAwnwFDvawq+X2g060DS0uESZGmYMxXT0JtuE V3hB2WyD18x19osmXaW0egTf7IMBbX/p0vKGtZImTCyeKKt18MSd4XpeBgjHEcsMVL NAdWTSCvrXIHw== X-Spam-Level: Received: from gaia (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id 13998C01A; Wed, 3 Jan 2024 20:45:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1704311161; bh=DYpAMKUEr4ZUo/A2V1G5Stqgcj7W2gBmNsNpjPAItNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B4k+m/q8vwyz1cmJjWarRzlV3PUa/4GYuScLc3MH9IP8RXLMxQgNKo26pq046ww1w IXiwt0dLInSvuNJJhA69DW/3p05amxvZHcQYMeEGw4S0aXDDnM+hfwt6n23bW8rE0j 321wZwAkYtQ2G2n2+mY3DL2D4JIsNe02StYEJsq7JutX4onPpj3vRyZbc1iQzVvJau BhSK0FEsTlhA3v6B2bG4rvREluC3TF7JpZvOXy8473obAqXXGRVKv9zNB9Ekw5yCRB P1E0WP0KYgz5HWK4aIG7D+g2rhNpqeTEVLUtzx/r4CDXibmlMLGrVTN1XCxXzGJmdX SKwuMgP0lMVHw== Received: from localhost (gaia [local]) by gaia (OpenSMTPD) with ESMTPA id 7038adea; Wed, 3 Jan 2024 19:45:51 +0000 (UTC) Date: Thu, 4 Jan 2024 04:45:36 +0900 From: Dominique Martinet To: David Howells Cc: Christian Brauner , Jeff Layton , Gao Xiang , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH 3/5] 9p: Do a couple of cleanups Message-ID: References: <20240103145935.384404-1-dhowells@redhat.com> <20240103145935.384404-4-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240103145935.384404-4-dhowells@redhat.com> David Howells wrote on Wed, Jan 03, 2024 at 02:59:27PM +0000: > Do a couple of cleanups to 9p: > > (1) Remove a couple of unused variables. > > (2) Turn a BUG_ON() into a warning, consolidate with another warning and > make the warning message include the inode number rather than > whatever's in i_private (which will get hashed anyway). > > Suggested-by: Dominique Martinet Thanks, Acked-by: Dominique Martinet -- Dominique Martinet | Asmadeus