Received-SPF: pass (google.com: domain of linux-nfs+bounces-911-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <ddc121f6-e80d-43ea-894d-2ad10cdf3051@redhat.com>
Date: Wed, 3 Jan 2024 19:42:45 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [nfs-utils PATCH] reexport.h: Include unistd.h to compile with
 musl
Content-Language: en-US
To: liezhi.yang@windriver.com, linux-nfs@vger.kernel.org
References: <20231214101206.70608-1-liezhi.yang@windriver.com>
From: Steve Dickson <steved@redhat.com>
In-Reply-To: <20231214101206.70608-1-liezhi.yang@windriver.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 12/14/23 5:12 AM, liezhi.yang@windriver.com wrote:
> From: Robert Yang <liezhi.yang@windriver.com>
> 
> Fixed error when compile with musl
> reexport.c: In function 'reexpdb_init':
> reexport.c:62:17: error: implicit declaration of function 'sleep' [-Werror=implicit-function-declaration]
>     62 |                 sleep(1);
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>   support/reexport/reexport.h | 2 ++
>   1 file changed, 2 insertions(+)
I believe this is fixed the last RC release
Please me know if that is not the case.

steved.

> 
> diff --git a/support/reexport/reexport.h b/support/reexport/reexport.h
> index 85fd59c1..02f86844 100644
> --- a/support/reexport/reexport.h
> +++ b/support/reexport/reexport.h
> @@ -1,6 +1,8 @@
>   #ifndef REEXPORT_H
>   #define REEXPORT_H
>   
> +#include <unistd.h>
> +
>   #include "nfslib.h"
>   
>   enum {