Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp193785rdd; Tue, 9 Jan 2024 00:41:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlLaAR8xi71btT9gPfwo/Nu3rUbx6zN8USkw1D8pY+ds0QDV7C81y7wXE9YHgfZbK8hwF7 X-Received: by 2002:a05:6122:8cf:b0:4b6:e33f:3e38 with SMTP id 15-20020a05612208cf00b004b6e33f3e38mr1638793vkg.32.1704789701795; Tue, 09 Jan 2024 00:41:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704789701; cv=none; d=google.com; s=arc-20160816; b=r1pMp0cUu68E7Zv6pxhB2c5czVsOyhipOjBlmW66ddQz8MAa9XXmGG/fRxjdRJ4sEg 6X8/nUeCxPk2U+h+48S4su5LwUYSNLS2h1RkH2W6rwWfG3uzFyM35NtMKKPwzHwacT8R j2/+0gkLV5vyAEOEZaieFFGIdOh0fXhgBcRlGG9O3dJnd4/scds8lUGRysvsLK9gm5bB 94mWrCx7sXTWSmcoPdua6Yg4pKBcmcm+rzFb8iB/tTMD3PTUiXUu2YxNos9R+tBOixfE cilk7axf0yutdwL2F75lRVXGAUIr3rWM/YuivNAOLn5KWW9+V6CH+Kfkzj5ym51JrPyn zpeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ceJhrDKfwTQDkSMBoGVp9fmH8KOXA4wCnrRuiRZloUM=; fh=rRBQn6UFnQKVZ0BxRwHZFR+x+WUqUQCQsbxdbrDabCE=; b=NBkCN8RmX5PKpuD+CtyAJ18eG4guEIIdcmYihk3PjFQ8bTz48KyhzUaRHq2EywC7Id LBKgMW1F+oAEIwKPXYv9WVUGAIXZblQfu7DhYzvqzyiVYpzJnoWUSUghAqIJlp+fg0kr GPUUV1hnk7AinSJWwRsDI9eC8p6px0cbSFLO5Ndi/HRdJA0taj8irseE0ti/O5iD4kny vOQumAD8hwG+rcCwm7E2ZMlk1mQfW13P5cL6mgljJUDMjrGoOgxkOnwtSqrmKNkQX7/d KP/GUF7/Yas4V7kX+TUwMqnB42Twutbbq+v2uHmR/SIhNP6G78Ce/2L/vfonFh6iTu5j gTow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hae9Vcp8; spf=pass (google.com: domain of linux-nfs+bounces-982-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-982-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id c5-20020a05620a0ce500b007816603ecb4si1525595qkj.60.2024.01.09.00.41.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 00:41:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-982-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hae9Vcp8; spf=pass (google.com: domain of linux-nfs+bounces-982-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-982-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1B0F41C25CD7 for ; Tue, 9 Jan 2024 08:40:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5BFA62C6B7; Tue, 9 Jan 2024 08:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hae9Vcp8" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C92229431; Tue, 9 Jan 2024 08:33:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 359E9C433F1; Tue, 9 Jan 2024 08:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704789185; bh=A8Hyrx8gv2NivKMAgmiyJ4RK4toNpxNWKdpezhMjsB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hae9Vcp8/kaaJWKrCD8n2rypMTJgDsf+fIUhRrlgD2zzHG1fE0pMkgVLy2Aay16i1 cyOHkhWI6T9AA0gmkJRtZt2jCOTuc/GnE/NFt35tRFGpCvFIalZbChShpHaOxn17RM sI5RHW0Ki3H0e99EmMwZ6tO0SgA6QAqR2LAPQFlkuKHdVPcV2i/aQ865CceI5/rxfK gR0HZ9dSmm6LFVOSKnwJUC2JqLjmUkL+hI52eC592xyJdoFew40D8m5YvlAVdr2EqL CHVYbJeXgyIcRIjxYeABsn7YZUkU56k8rkALLN+maFLPBr7Q+5gP4DXI0YDvuJOFww WRb5Fwe1ZVgUw== Date: Tue, 9 Jan 2024 08:32:57 +0000 From: Simon Horman To: David Howells Cc: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yiqun Leng , Jia Zhu Subject: Re: [PATCH 1/5] cachefiles: Fix __cachefiles_prepare_write() Message-ID: <20240109083257.GK132648@kernel.org> References: <20240107160916.GA129355@kernel.org> <20240103145935.384404-1-dhowells@redhat.com> <20240103145935.384404-2-dhowells@redhat.com> <1544730.1704753090@warthog.procyon.org.uk> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1544730.1704753090@warthog.procyon.org.uk> On Mon, Jan 08, 2024 at 10:31:30PM +0000, David Howells wrote: > Simon Horman wrote: > > > I realise these patches have been accepted, but I have a minor nit: > > pos is now unsigned, and so cannot be less than zero. > > Good point. How about the attached patch. Whilst I would prefer to use > unsigned long long to avoid the casts, it might Hi David, I would also prefer to avoid casts, but I agree this is a good way forward. Thanks for the quick fix. Reviewed-by: Simon Horman