Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp259319rdd; Tue, 9 Jan 2024 03:23:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFaGbPit78CjZ1BJI16WcNvWnlwXXBV+h7lpvmO27DL12WRlQaq1JYzIAIlsEcHKF4yVKMx X-Received: by 2002:a05:620a:4507:b0:781:d911:7869 with SMTP id t7-20020a05620a450700b00781d9117869mr7122496qkp.111.1704799417821; Tue, 09 Jan 2024 03:23:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704799417; cv=none; d=google.com; s=arc-20160816; b=lAZEkxiTg5W/KbCkwsezpcEVVVepUQIbKtoW1oEdu06FLDfaMEpp7vN+9ZP3kBKHAg KIFFvDO+iufjH0ZmfQGqnPs+uMt3NugkwhKjP9Nx3OvhNYV+R9yCZP3vIXDK5wmZHZ+c vuGTKuiQq4VR0HIgbce1X4SBCkYW3vz69xA1+PPCVTXL/er6QbGOPTQIQi/kLMwM6c/w MGL4ND0rT3aTlYuACPyF9mtys0NdldXgFz5Ax+HdmI/DS5LZ+8bFfw1nSXR8iWTLDDF7 WO26Kgg5KYFUKLLSGpL6Jjf2tePmLmm096tZIhzaa+u/FrbsKXwYeqwEgMjsa7daWAX9 NHgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=lTmcWwAowP4sGHH2dBxkB2CC/aMCkpFsy2ZSyWuDsbM=; fh=C4wT4o+0O6e8YiKCOcA8IWo9Yd3506P35P9sYXQJeL0=; b=AJgkcUguZdeOpOGwwcgcyk68+BIfdZ6+vsch9FftrgebakpO+DX54Qv9gB1/eFw2/E HU1wsq+GS37Nifja9nDH8vpnbMvVPUxOkTFW41136lUXnDNiUGkcxDiImTBpySd8i39B y1TBMcSLKxiNOkoNCJIZNrzEKDFRFsThq1ifBp+9wLWsMJpJmiYSDmMhYD5MLFFXNulr UMmRxASh5i4iRYxHf0s0dRM09QxSdTWRbsk3tg/IQ4BF0Qd7PJ6DX6wLPbTMK8kRpIyX exOZPfZI5Ve/WoymXXGcyonumBxbELNRWP4gbadlNLmkH8XGQ7h6IgflHEIus8TeaRYx KQMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YvZbyNVG; spf=pass (google.com: domain of linux-nfs+bounces-988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-988-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id y11-20020a05620a25cb00b00783192b7609si1970720qko.772.2024.01.09.03.23.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 03:23:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YvZbyNVG; spf=pass (google.com: domain of linux-nfs+bounces-988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-988-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 90B771C24062 for ; Tue, 9 Jan 2024 11:23:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3363D3716D; Tue, 9 Jan 2024 11:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YvZbyNVG" X-Original-To: linux-nfs@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B677539AFF for ; Tue, 9 Jan 2024 11:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704799267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lTmcWwAowP4sGHH2dBxkB2CC/aMCkpFsy2ZSyWuDsbM=; b=YvZbyNVGKCzBwREJ/gGaI1jtmaquzUVmRYzEyfvy6M0NW2uLfXJY/JhqVe4s8AkIX9TDAC DtHkRl20h9AXGky/w6HJU2qKs69wwAwdY06ATKYuC90jROOH0gKBm6kOMmShBajZeYsvx3 GUyo1al2ABOC6h4VFQjuGlwROtXQgco= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-9U04wNMdOJy50uoFoYMuDQ-1; Tue, 09 Jan 2024 06:21:03 -0500 X-MC-Unique: 9U04wNMdOJy50uoFoYMuDQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD86385A588; Tue, 9 Jan 2024 11:21:00 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0990C15E6C; Tue, 9 Jan 2024 11:20:57 +0000 (UTC) From: David Howells To: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet Cc: David Howells , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH 6/6] netfs: Fix wrong #ifdef hiding wait Date: Tue, 9 Jan 2024 11:20:23 +0000 Message-ID: <20240109112029.1572463-7-dhowells@redhat.com> In-Reply-To: <20240109112029.1572463-1-dhowells@redhat.com> References: <20240109112029.1572463-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 netfs_writepages_begin() has the wait on the fscache folio conditional on CONFIG_NETFS_FSCACHE - which doesn't exist. Fix it to be conditional on CONFIG_FSCACHE instead. Fixes: 62c3b7481b9a ("netfs: Provide a writepages implementation") Reported-by: Lukas Bulwahn Signed-off-by: David Howells cc: Matthew Wilcox cc: linux-afs@lists.infradead.org cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org Link: https://lore.kernel.org/r/20240109083257.GK132648@kernel.org/ --- fs/netfs/buffered_write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c index 0b2b7a60dabc..de517ca70d91 100644 --- a/fs/netfs/buffered_write.c +++ b/fs/netfs/buffered_write.c @@ -1076,7 +1076,7 @@ static ssize_t netfs_writepages_begin(struct address_space *mapping, folio_unlock(folio); if (wbc->sync_mode != WB_SYNC_NONE) { folio_wait_writeback(folio); -#ifdef CONFIG_NETFS_FSCACHE +#ifdef CONFIG_FSCACHE folio_wait_fscache(folio); #endif goto lock_again;