Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1130197rdd; Wed, 10 Jan 2024 09:26:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFVYTstBqa3Dc03Di83hF86g6t/4f2ysu1GQ3yVVgqaQHjhXnzFX11FGiZOC+bskKmWHiK7 X-Received: by 2002:a05:6102:3a0e:b0:467:ef9a:51b9 with SMTP id b14-20020a0561023a0e00b00467ef9a51b9mr1176750vsu.10.1704907564651; Wed, 10 Jan 2024 09:26:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704907564; cv=none; d=google.com; s=arc-20160816; b=VWtzC3ECAUVcVA48G1J0utluNGLnFdUmwhSfXuNKThRci/UBmkcfkzdRvn/WsFasPW /kO1xEGCwvavb++FMV0ZhZ0LZrVJPV8tfeq+o8d/v2qa9Ni4x1jPS7wp3q6yb8MQbPxI icyNcC2IVmfasAK9WWc5lqaYMKP8h93hB2i9IGSRoh2ILAc9BsTOpydeRi7i4tks7i0i Xttpug+WrPCFLp+ZAw1o52PGHBH0qIr9/KLnJAJRvIWVb6a0XqmQKzVe0sA/U4apX47f oLGQWg4dhXDHsRuomyosFpE3avhJA3N12UbwMxNlMuKOi8Xyq/FAuExXk9RTIsghBUbq 7p/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:subject:cc:to:from:date:message-id :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence; bh=IekxBvl4GzXpFxV1vIvwGpgw1AZ0DwMNq4Ckjy6RaQg=; fh=ln/5CECLJ/j/NA9f5f2F7U575fu35WSMm4Q8rKm8VlU=; b=uip07Y8Cko2bTuFP89Fx/KlFX687P9iA2DW14PdwXKd9B3JQkbMceQFUQ1GcMAPZzp WM4ZHQ2A5REUXIx8w2WlUDUBlB5oj3kM1/GzR6P3EQelNSTFmHj9yV/pPy3sWhXa2cJv gpaIqqFm2/boU79hrYSoJrjOIA1OU23g6B6Zi+EoI+sVzq9LxfevW/sdNbwEF1rDK0Mf +yj63lUm8R6vHPxyGrbJpBPYkV9Omu+6XepnvvhQjg91WbigEkuVteaQWbxaJLDUkzou TdvQ5Ei7eDPu5wSWWzfILEfD+Cmt/wOR1BtiFjm59dUzwV1kMnDzgHtO/IDaQv9hdDu0 D6Zg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs+bounces-1014-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1014-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=stoffel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id e15-20020ac84e4f000000b00429a21c4983si4524702qtw.562.2024.01.10.09.26.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 09:26:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-1014-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs+bounces-1014-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1014-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=stoffel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 574DF1C22422 for ; Wed, 10 Jan 2024 17:26:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 577AB4D10D; Wed, 10 Jan 2024 17:25:15 +0000 (UTC) X-Original-To: linux-nfs@vger.kernel.org Received: from mail.stoffel.org (mail.stoffel.org [172.104.24.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC79E4CE12; Wed, 10 Jan 2024 17:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=stoffel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=stoffel.org Received: from quad.stoffel.org (097-095-183-072.res.spectrum.com [97.95.183.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.stoffel.org (Postfix) with ESMTPSA id 17DD91E12E; Wed, 10 Jan 2024 12:25:07 -0500 (EST) Received: by quad.stoffel.org (Postfix, from userid 1000) id A9991A8E30; Wed, 10 Jan 2024 12:25:06 -0500 (EST) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <26014.54002.663705.978220@quad.stoffel.home> Date: Wed, 10 Jan 2024 12:25:06 -0500 From: "John Stoffel" To: David Howells Cc: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] netfs: Don't use certain internal folio_*() functions In-Reply-To: <20240109180117.1669008-2-dhowells@redhat.com> References: <20240109180117.1669008-1-dhowells@redhat.com> <20240109180117.1669008-2-dhowells@redhat.com> X-Mailer: VM 8.2.0b under 28.2 (x86_64-pc-linux-gnu) >>>>> "David" == David Howells writes: > Filesystems should not be using folio->index not folio_index(folio) ^^^ I think you have an extra 'not' in all four patch comments. > and folio-> mapping, not folio_mapping() or folio_file_mapping() in > filesystem code.