Received-SPF: pass (google.com: domain of linux-nfs+bounces-1019-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Jeff Layton <jlayton@kernel.org>
Date: Wed, 10 Jan 2024 13:27:28 -0500
Subject: [PATCH fstests 2/2] generic/732: don't run it on NFS
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240110-fixes-v1-2-69f5ddd95656@kernel.org>
References: <20240110-fixes-v1-0-69f5ddd95656@kernel.org>
In-Reply-To: <20240110-fixes-v1-0-69f5ddd95656@kernel.org>
To: Anna Schumaker <anna@kernel.org>, 
 Trond Myklebust <trondmy@hammerspace.com>, 
 Chuck Lever <chuck.lever@oracle.com>, Yongcheng Yang <yoyang@redhat.com>, 
 linux-nfs@vger.kernel.org, fstests@vger.kernel.org, 
 Jeff Layton <jlayton@kernel.org>

This test sets up two independent superblocks with the same backend
server, and then does RENAMES of the same files in the two servers. This
is basically trying to simulate the case where two clients are competing
to rename files in the same directory on the same server.

This test would usually pass vs. an NFSv4 server that doesn't have
dfdd2630a7398 ("nfsd: fix change_info in NFSv4 RENAME replies"), because
the client would end up improperly invalidating the dcache for the whole
dir after most RENAMEs.

However, this test doesn't (and shouldn't) pass on NFS, because the
client has no idea that a rename has happened on the second mount. The
expected behavior for the NFS client is for it to use the cache timeouts
in this case, which is what it now does with the above server bug fixed.

Exempt NFS from running this test, since we don't expect it to pass.

Cc: Yongcheng Yang <yoyang@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 tests/generic/732 | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/generic/732 b/tests/generic/732
index 785aac58f361..5b5087d5accd 100755
--- a/tests/generic/732
+++ b/tests/generic/732
@@ -22,9 +22,7 @@ _cleanup()
 }
 
 # real QA test starts here
-_supported_fs generic
-[ "$FSTYP" = "nfs" ] && _fixed_by_kernel_commit fdd2630a739819 \
-	"nfsd: fix change_info in NFSv4 RENAME replies"
+_supported_fs ^nfs
 
 _require_test
 _require_scratch

-- 
2.43.0