Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2520563rdd; Fri, 12 Jan 2024 12:01:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEuCdlQTUdb2Y3fcsE0irtcUqua0liaQJ0TuisuvalfFuriAsqVqXyxkR2rwZ3Y8P+zXkrr X-Received: by 2002:ac2:546c:0:b0:50e:2737:f603 with SMTP id e12-20020ac2546c000000b0050e2737f603mr828350lfn.48.1705089697295; Fri, 12 Jan 2024 12:01:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705089697; cv=none; d=google.com; s=arc-20160816; b=iJI5XIxG7ylJu6xgWTwwMBBuPhbz+IYWBaahZNgo9BVFBi/JhlPZAftWYXeLWW3qDv ZkvWb7RyWCCGI7XvYlJruVYKDtGAtChSqrmspzyKsM67f9r5oPt1Y7di0+V2pPsvpx/S 6Tf3aei8mgOvLH1M8/Wxa3y4iCmbRw8s+cboT5+ZBkF4LsIf5jDfxXUn5lYc0UsHhrUu Bkac3UyX4JzRpmI2jn3JLUhfHl8mufLA3OugHKXXu1I6MNZhQzlD6ZB/f14cQICLfQNl 8OCypvO00m3XimkBl3lWGE1xWf+VSrHwwlkDvT9xdFCDJfZ48b7Ykl/rCD/AQT9lK9B0 k3hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=6uxPzdAyw9lWg6GsTg7dkdadZqmiNB4xd1weMjRklyo=; fh=gcRtaeDVvlHhepZV9HZxFsIm+MWA074fRnmB85R22Ro=; b=kXEg1/g3ysCnnwUea9Va6jg30GdIiy2w4zrHOpu092Xa2Xdot+tgY8cOwXk3Ry/ifY N0nNAJpd1zY7tkfzkoiEgHQYbX3tDV09Rr4C/pP/hn5thuYX+TxK+bqZu5Oe4KBxjlEq Jn3hEbhU5GuFcZX4NFs2TGAUtgKqePKOchBMLde7BCSvvgaDxZxl5Nbk94owWJQ8K71e ba75BFuTkYYZtFu/J6bh3Oy+1BdC1/EA00FefiEZrWFGkTK76UFHsMlvzzRDsVSQlJFR or3pMCPOOxMl45AP7GOtakf78svI5sfuznw4oggkY3dkq59CSAxBt6zJEBC0C7jiuV3z Ku/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=btEuZUNQ; spf=pass (google.com: domain of linux-nfs+bounces-1064-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1064-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id by18-20020a170906a2d200b00a2877da8ed4si1588075ejb.584.2024.01.12.12.01.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 12:01:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-1064-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=btEuZUNQ; spf=pass (google.com: domain of linux-nfs+bounces-1064-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1064-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4CA391F23882 for ; Fri, 12 Jan 2024 20:01:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5F0CD15AFE; Fri, 12 Jan 2024 20:01:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="btEuZUNQ" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39A6215EB2; Fri, 12 Jan 2024 20:01:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19ABCC433C7; Fri, 12 Jan 2024 20:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705089688; bh=7uJMXaQV5alFCbUKlnhGLawxsYt6JRPXMzaCcU9fPJM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=btEuZUNQy9RXXCnyQ7qE0OoT3ueMKlV3XaeGNnbtz4sjay+iRKa8mn3My3x3p8JOU AdJGRkctwTI9ctAIQ0wm5uUXq03eN9Wt2prvIY7dleAnyGAedwjxfRSXAr51do4t7i y8aOGiW9Wd7ttbDRVlrnpymNL0YN0F9CJaoaruL2XJrqwUYpEyKAcikexVbxffkzWR sLvTV3ICYL6yyACwGJAKxAWsfF9jQI0TKoQu0QgUi0XNzCIwkIfGo4f7iWxBhlEwJO TVgWX56t+Q9TSZ+Xq142LIS01secEzr4KNEIcWPzO+JUSoOAGDOxZT1wl69AO8h6oV Rj6U7C36DDKSA== Date: Fri, 12 Jan 2024 12:01:27 -0800 From: Jakub Kicinski To: Chuck Lever III Cc: Zhipeng Lu , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simo Sorce , Steve Dickson , Kevin Coffman , Linux NFS Mailing List , "open list:NETWORKING [GENERAL]" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] [v2] SUNRPC: fix a memleak in gss_import_v2_context Message-ID: <20240112120127.5eee94f2@kernel.org> In-Reply-To: <824EC6A8-24EA-4998-B1CB-8E54FBB51129@oracle.com> References: <20240112084540.3729001-1-alexious@zju.edu.cn> <20240112112454.0840bcf3@kernel.org> <824EC6A8-24EA-4998-B1CB-8E54FBB51129@oracle.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 12 Jan 2024 19:27:40 +0000 Chuck Lever III wrote: > > cocci says: > > > > net/sunrpc/auth_gss/gss_krb5_mech.c:458:2-3: Unneeded semicolon > > I planned to take this patch via NFSD's "for v6.9" branch. > I can remove that semicolon. Thanks! Sorry for the lack of clarity, I wasn't intending to take it. The patch did get into our checking machinery and the warning was reported, so I figured why not say so on the list. I'll mention the intentions more clearly next time!