Received-SPF: pass (google.com: domain of linux-nfs+bounces-1115-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <feef41c7-b640-4616-908f-9d8eb97904aa@oracle.com>
Date: Mon, 15 Jan 2024 13:05:37 -0800
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: dai.ngo@oracle.com
To: brauner@kernel.org, Jorge Mora <Jorge.Mora@netapp.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: nfstest_posix failed with 6.7 kernel (resend)
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?OUdCTUVhYlBYWlFTMS94bHNjWUJkeUlScjEzM3NjYmFmTVBQbFNOaTQvU1VY?=
 =?utf-8?B?WGtoWndPUWNHT2J1ck1veVRQa0xiR1g1b0VtZUpYU24reDFOaS94Z1FGVGxj?=
 =?utf-8?B?aGl6RFZIeUVYa05VaDNRS29QakJ3WVZEK1pwR3VxcUp3SHBheDdIRFhjTTcy?=
 =?utf-8?B?TG9nOWFBcWtiY1JFY0NvZk54MkpXU1Z6dWZjZFczcEhBYkNVQ0dod09TUjFR?=
 =?utf-8?B?K28xTDdaWHJyWXA1SVVxM2c0RDQxdi83NXVSd0hieVBSeTB4SUd5NjdFQ3Az?=
 =?utf-8?B?UllZa0wwMitpNjdnV2xBZkM3bUJBU2R4K0dGalp1dFJSNHFsNm5EdG0vRG14?=
 =?utf-8?B?ejc5a0plSEZQUHBlS2VJSHc3NUpQYk1wNFdNZUFWZFQyTFJ6V3VVdnR2ZFpF?=
 =?utf-8?B?YU43YzlId0lLbFA0RVlSY3FBeHpSQzd2K09UcjNFRDh1U1VKRVoxL3FuOVN2?=
 =?utf-8?B?N0pYcmtzUXRQanZ2YWpMRmxrMDh5aDAzZWdXanAzcVlzc1ZOSzRHbE1rNGlS?=
 =?utf-8?B?ZmJFVWd4dEwzUERwNWNlbnMySzJrWVRoMmQrUlV0SWZMTDJYeStOT1JwSjJ4?=
 =?utf-8?B?VENhMHpJUTRGREM1dFkwK1EzNWhyTjFORlRXUkIrNlpIWFZ1bWRsUGMrcmpU?=
 =?utf-8?B?bHRkSCszZWRCbjhJaGFzRC8zaTNTNnNFSDVxWngwclllK2ZDVVp4R2dDU3dv?=
 =?utf-8?B?clRHQ1dnbjNMdFlvLzl6SlQ3bW94ZkxjYlREK3c5bWZ4aVFyeEZOaE56Z0JF?=
 =?utf-8?B?UitXaWVPSHY0dUdzT3ZkNzVob21mM3lnMytodWVpaU5EUUdkL1RMbnVpOVNi?=
 =?utf-8?B?dElnOEFLRzhLaU54MzZGdmVYK2tobCs0ME93N0dYVml4VWg2cXdKS0JuNi9o?=
 =?utf-8?B?VWZGYUtad2o0bHZaRnJrNXBMd050bWhXZVZtK3ZTUHpkSUM1ZS9rck9mc0NF?=
 =?utf-8?B?dEVHelYrWTNZTzBwamFKT0hzVGl2SnF5c0ZBWWh5aXJvSmdDbk8xeGM4bzFr?=
 =?utf-8?B?dXRLZzRaYlNyVG9RTUVnOGdwZVpmVjZIVEFkNzM4VnpxeWcyMisyMDNHNjYw?=
 =?utf-8?B?RWx1ZG83SlUvNmZtaFMra1VpaDd1VjBKa0Y4YlM0QnlNSW5NRHdCYm1WaXRO?=
 =?utf-8?B?Y2E4Vk9ZR2JZZjhIQTNQRUtnWVBlMnlQRC9keWo4cWIrSDJoaFR5ZFVyWTFH?=
 =?utf-8?B?Q2xsZnFxZEp1SUVGZlN6SWk3QmZxOS96RzdSNGxyZ3J3Q0lVdnZ0cHR0VTJN?=
 =?utf-8?B?aGlQYTBZSkYrT0pPTUZ0UjgrcWxCWFN3VHZTR1Z2NnhSZ0J5VGpZK25EZFpR?=
 =?utf-8?B?TXFoSGVKWUo4RjNvMktrRXFGMUlJdTZxVGlQNzJ5N1pTUGFKOXBhN1NwOE45?=
 =?utf-8?B?aEJTNlpxWjA0d3BTTFBIKzV6VFlVRlZqSjd2bThxL0Y1OUt3eXVzc1djRk02?=
 =?utf-8?B?eFluTUp4S3pJQ3BkRmJpMVJlM3RiemlzQzdvM2F2STBOdlBDalZLVDBmM29K?=
 =?utf-8?B?OEJlS0Noalg5MEV5OStJVlhqMlNlL0xzMVIrTUIvd1ZEdC91bThMV2VNdjlQ?=
 =?utf-8?B?b1RUOEFlNDR3VlA3WGxtU3FWUTVVZllvRC8rYWF2bUNRdmphMWdNa2VFNTMv?=
 =?utf-8?B?dHM0S2NsYWRKNEZSTUJ6Z3R0RW13UFZ5SE10cDdXdzhGTzZ6SkF6TnM5QlpJ?=
 =?utf-8?B?RW9jRUppZkhaV1hlMGpJRlN4bEJQMjRwamNER0NjK2VuVkJoazJ0alpuNVVD?=
 =?utf-8?B?QUxvQ2VoalBRNnowbTJZZkhnYmc1UTVITmdJUk5Lb1RYcXQ5ZVJ5SGdHSXI4?=
 =?utf-8?B?OUlna1ZYbWRMRUJMcXNyL1UwbUhORXdXRHRjcXJoNFE2b1dJdnBSNDdxYnF1?=
 =?utf-8?B?Slh5M1psb3BGRmx3L28vek1zN1BKMTlaS2NjYXRod0tyVU4rYlkwMXp4VTFn?=
 =?utf-8?B?SndwUlJyVkZJYm5WRytad1R3NzBDbmM2dm9Ld3c3S1pHRU9lb0xmZ3V6NGZB?=
 =?utf-8?B?KzlTK3N4Zi9HcTJFKzhSeWxzRkxlVkhZSEgxRnR1ejk5VGVsdmxtT3NTdDRv?=
 =?utf-8?B?Nkh0bTZSRXk0ZjFtR1RGd21aUWc4RXdWMjNHQkI4TG1sWXBrVzZsVE04dVVj?=
 =?utf-8?Q?oOs7ctD+jGN/ldPB2pFOWVd3t?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ZBERIhhgdWQ3nQB0h7q2tAbJPNcolrREyPyvZl2ywPKJRktnpsTFcFNqgB5xif/nEu/eVk/NFWZNJzeWZ/5T0YrVLHG4fLjjqkGHKYwPwrAe8AN4LqK3yQhhJf/OQ0dWDkb9fMNiQGz5b12sVH5lUMHr1N3YUh4bNVm/LR2QuWxJrwoFm2c9OZkFNjAvW+cgICv+yOIdi0VaamTRNkOf5ZorBfO1KWA0tWoq7Qb78n2a4d+IRMEebshsxEviNEO0PogX7J1f+J95UPjr3E+q9uxUpRXL+QZvBh96SJ6ADU98vP0zeFmDT8KflcsE7NkY7FXWHP5WgNCX62W6cQVNfa5OGyMAoHE7J/aV9dq7W3tZaL5nKI48vIljA3gbYbsgIneLKo19ccENWbU0+pjKeNEoj8mUtkip2+Y1+gMTDjgMtrIS1kxEdJVI6q/vQCVkBPrZKGx5J+9GazvMa/O+NeydGIYXyJJRe9s65hq3blvgj20Gk32CRMgR5s9NZA56puscNqWW32XymHeWYIED30yi6OPEU1aYG/8vC+wH6UxOD0JRGjsL7pL8PCOJS/8tDaUofWRkwZXNh+g+Lwzf72G5rU7LGB8Lh0e+0ktSYkQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2037b83a-a0db-4973-a57b-08dc160dbaf3
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 21:05:40.7622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g2AtzQITJvFCOlX/qOyRN5MWWhqxk1WtfMnp0gUuvoTBGd5WmygS01Go5l5++YpComhLVUTNpHrF3bmTrP03YQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4790
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-15_14,2024-01-15_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 malwarescore=0 adultscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401150156
X-Proofpoint-GUID: YsqwMbsBYbBVIsnksOHuWBaL_ySr6hIb
X-Proofpoint-ORIG-GUID: YsqwMbsBYbBVIsnksOHuWBaL_ySr6hIb

(resend with correct Jorge Mora address)

The 'open' tests of nfstest_posix failed with 6.7 kernel with these errors:

     FAIL: open - opening existent file should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
     FAIL: open - opening symbolic link should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)

The problem can be reproduced with both client and server running
6.7 kernel.

Bisecting points to commit 43b450632676:
43b450632676: open: return EINVAL for O_DIRECTORY | O_CREAT

This commit was introduced in 6.4-rc1 and back ported to LTS kernels.
I'm not sure if the fix for this should be in the fs or in nfstest_posix.
The commit 43b450632676 makes sense to me. No one should expect open(2)
to create the directory so the error returned should be EINVAL instead of
EEXIST as nfstest_posix expects.

-Dai