Received-SPF: pass (google.com: domain of linux-nfs+bounces-1165-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <3623c810-32a0-4f13-83a7-ad0ca4b41205@oracle.com>
Date: Tue, 16 Jan 2024 12:51:35 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: nfstest_posix failed with 6.7 kernel (resend)
Content-Language: en-US
To: Jorge Mora <Jorge.Mora@netapp.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Christian Brauner <brauner@kernel.org>
References: <feef41c7-b640-4616-908f-9d8eb97904aa@oracle.com>
 <20240116-hauch-unpraktisch-8bb7760c04ef@brauner>
From: dai.ngo@oracle.com
In-Reply-To: <20240116-hauch-unpraktisch-8bb7760c04ef@brauner>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?YllkdmxmMU5CUTErQTdsKzJTRWJSQkVwdElJd1RJSXZXNG9IYnd0d3lVUFFv?=
 =?utf-8?B?dDZkeEswRFkvZFZtcUg0NWg1dEQ0TCs1V2Uyc1MyK1JIZk1xNVBYYkR4bjMx?=
 =?utf-8?B?MzEzUzhkQk53Y29NQW9mTnJjU28rZERmTUZpajNUSmVTNllsY0VCWFJ0azBo?=
 =?utf-8?B?cVBOYmt1RlZaT01DcGVVRngzSWZNeWVtallqQWttVXR6eGg3dGZIalovaE9q?=
 =?utf-8?B?K1VPLzNWbCtOeXFLSGRoRmtnSFd1MWNmUTJMN2VoTVpRc1FNQklqQm43Yy92?=
 =?utf-8?B?VXlBdWpPaE85MHQ4dUQza2dSaWpHZWg5eDJzL00vNzVucEpGSVd6cXF0NG9h?=
 =?utf-8?B?a1liUGIrVVlWYzIxbS9BYWpGU0QzOC9XS2pZbXduZVY4a1R5WlpWRGxjbENU?=
 =?utf-8?B?dWl1QjBzWTFrZmZzQkFWSElqOW5NYllWNlpDdEZkZFo1S1R5VHJLMEVWOXgy?=
 =?utf-8?B?WVFuNjBmUzNLSlduNHkya2MrMzNIN2FQMUU3dWYrQkFvNWh1L3VoNCtkb0c0?=
 =?utf-8?B?TTZ3ODI2c3hlN1NLSVA1OWYveGNvUERHLzkrYzdQZDFjZUw1ZUl4Y0ptZ01n?=
 =?utf-8?B?NXRQaWVxWllwNEdYcUZEOElHK29KdjVRdWVzREltQ0szajVZK0NwTEdqMnQ3?=
 =?utf-8?B?NnQweEc3V0RUOGxETzVUc2MzV0pEZG1zZnp4VGlxL2xkWE1pbWZ0bXh2Umhz?=
 =?utf-8?B?QVozMHplVllrU2JsZDFqbHdoZlFpekVSUGhGd0w4b1lQRFBmbGsxY21yeVRj?=
 =?utf-8?B?a3FXNFAwZlREWlFZdW42ZzZJeS9sQ2g5cE44VlYwZm1XNnRCcStDWjloWHph?=
 =?utf-8?B?SmYvdjduaGdESW1jc1BYZGlndTZYTkFUOWRQcTQrUUQrcURzRHpSVkVFSnBy?=
 =?utf-8?B?QnRGMHRZOHIyeGRyUDgvL09Fdi9jYTNjUFJNTzV2WnRRdS9tbjlsZFhxcUoz?=
 =?utf-8?B?YklTcVhCdUxXKzJJYVIyNTMwYVVjM1pQUW0waWxmZzB3WGhJZVp2YVllZHVC?=
 =?utf-8?B?dVhuMENSTXpQVm9qZXJ2ak5seGdmMmFYT0lOcCtJWkRJMms3ZStyOHhnT05O?=
 =?utf-8?B?Q1RuSm92bGM1VUZkWDVPd3MxU1U0U216VGw1VkVyU2ZrV09zTHpjYlEwT2E3?=
 =?utf-8?B?YWcybHkwS21ZaGxtc2hsWEp5aVBMU3VTVjVvam14L1NyNThWa3k3ckNUVUQr?=
 =?utf-8?B?N0loczhaUmV5WlRhMlNPUEswNEltVjlCOU5ENDNPcHNWRnhyVERrM25FcGNV?=
 =?utf-8?B?YU42NmdKc0FVQi9GOHZ4NHdvT003K0YwWUtXd2IrSjVhMDNKQ2M2SWJndHd6?=
 =?utf-8?B?bVdxUlN5MG5vZXVDQ1BnTnRZdG50bExPMW1XeENxOTEyQlpQOXJFT2xkTFJp?=
 =?utf-8?B?c3pscjY5cWNMcnlmUnlhR1pvUytrdWQ1VEZNcVp4ZG01WEp0Q1cyMEdPYS9E?=
 =?utf-8?B?TjU4ZkpCS2dCU2J5WUJkYndhZnNKZ3N5TmhVbHNucmtZV2diSlVndk9lRS9s?=
 =?utf-8?B?OFozaCtNN0ZWZGtuNUdmNWxPRW54My9CL053c051ajVEOE1GeUJybGJPc2xp?=
 =?utf-8?B?RVVzalY3NHRvVnNzaWhTcjBRYUk5Y3BxbmRvTVRrRGY2dVh1YjNMUjlpajBr?=
 =?utf-8?B?SWEzM0RnOHRnUXJEQWYwclJ3WnZLZStIckFSaVdSQXRMTHhJK1IycEx4T0pD?=
 =?utf-8?B?SU9DOFp0c21MUFlzU09rNDRhOGFRdGJYbzgzVkRvVHdPcHlaRWIzVzZWTWhq?=
 =?utf-8?B?MXQvT3Bqc3Z0Wjg3RTNtQzkwbUhaYVhJN0FqdDVjVmdLQk9IWTV3bzltZ0JG?=
 =?utf-8?B?NEtvQzZOMUFiVWlTVFJOZVh4MVR0RFBPVSsyMGhOeFp6TGdBWlp3TStBZXNz?=
 =?utf-8?B?SWR6RVg5TjdRWEdpYWEyQmdsUkozVDJrOVF3ZlZycWpSUGNpQm5YMWM5Sk8w?=
 =?utf-8?B?UFdmWWVUb3ZhVWFNTVB6MlVPcDBkWlJDRmZrTi9rNW51czBUN3JXeEhTZUF0?=
 =?utf-8?B?ckE2d1YySUdUeHJ3bUJxaHRLR3MrbVRzZ0NUYm9FaThSdThLQ0pjeFM1NW5K?=
 =?utf-8?B?ZGpyV0k3MndlYmozY3Jud1dteFZOdzNKRWlid1N2QU8zUmc3SW9YTzBLeENZ?=
 =?utf-8?Q?BkoAiMH7WoO7BT1I7F93XOBtA?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	KuXAdmowA/T+0ICypFnRteRU/KpnhFzwOJZ3KJsFBnMEIE5D31Ej07esgOVSjpElD5jdBejAB+7jNFFW+mKN1XXWyXeWcqEaZyxVf+hgaKOkdECRaPaKRDpXV702JhYbhD0/3ftACcs9fZ/tSQ89YnNB+zfaHJOO1thP5a+s7XwF31RLkmiwTBdwcqYMBsqNg1n0ka9dZ0xxR4Zn89BCeLS3ykT/JkaNeE0jcsdJFrrWcNgnCfyrWUW6yrSCYHEUeE6DBLy+N4ZbZAesuKiTltqK4psVaFGrPSV/urmT9lUc3eeAKXoRB51bKZh7VYFpws3gx6MMGiIho9N8q41UrgdYI1/kxjgxE5C6XUpLUk8U4zcfrDkdrmu+rvgx5iIOm8aExrzPTU+eRMZIlkVMohmJhW9gW4k49CqnKq7SqVGB9zWW/KhfGAV7pfMgjxee0h08NQJipmFw/pTbAbVF6gisKrqiB1tg7DpuyaDnwxP3VR2ynRMlmBZc3VbfH9TCDH31bglViTKGhg/BW+fhlEybBrEc/O9M1dEouFkLh5wJG/UkLUaM6HdREkxOI1TdFKQuuAsI/aCTJgkfwIJXf1ZdXCbv+G7drBxSdI9bn24=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4744574-9503-427b-4dc3-08dc16d4ef9a
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 20:51:39.1404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0HQewpXzCyx22K0OEnauU3n7rCy1Abu7El7NztwDJYHLh7Oi12fLAB8NqdEodsWbtnpB/gEhCAYdCacZ518D3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6270
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-16_12,2024-01-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 bulkscore=0
 spamscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401160164
X-Proofpoint-GUID: DlBlDIQrLP3luH31W2nCL1y_lLtu7Xsp
X-Proofpoint-ORIG-GUID: DlBlDIQrLP3luH31W2nCL1y_lLtu7Xsp


On 1/16/24 1:25 AM, Christian Brauner wrote:
> On Mon, Jan 15, 2024 at 01:05:37PM -0800, dai.ngo@oracle.com wrote:
>> (resend with correct Jorge Mora address)
>>
>> The 'open' tests of nfstest_posix failed with 6.7 kernel with these errors:
>>
>>      FAIL: open - opening existent file should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
>>      FAIL: open - opening symbolic link should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
>>
>> The problem can be reproduced with both client and server running
>> 6.7 kernel.
>>
>> Bisecting points to commit 43b450632676:
>> 43b450632676: open: return EINVAL for O_DIRECTORY | O_CREAT
>>
>> This commit was introduced in 6.4-rc1 and back ported to LTS kernels.
>> I'm not sure if the fix for this should be in the fs or in nfstest_posix.
>> The commit 43b450632676 makes sense to me. No one should expect open(2)
>> to create the directory so the error returned should be EINVAL instead of
>> EEXIST as nfstest_posix expects.
> Please change the test. The EINVAL fix for open is a really important
> fix to the general vfs api.

Jorge, can you help fixing the nfstest_posix to work with commit 43b450632676?

Thanks,
-Dai

>
> Christian