Received-SPF: pass (google.com: domain of linux-nfs+bounces-1194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 17 Jan 2024 17:03:06 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
        Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <Dai.Ngo@oracle.com>,
        Tom Talpey <tom@talpey.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, linux-nfs@vger.kernel.org,
        netdev@vger.kernel.org, kernel@pengutronix.de,
        patchwork-lst@pengutronix.de
Subject: Re: [PATCH] SUNRPC: use request size to initialize bio_vec in
 svc_udp_sendto()
Message-ID: <ZahOmmMZxHcK8Amn@tissot.1015granger.net>
References: <20240117210628.1534046-1-l.stach@pengutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240117210628.1534046-1-l.stach@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?rb8tJzEjFdanSIYlaKtgyKNnhSwSBt/BuMLKhWFL/tITCrqCp6xvYjOCPnpJ?=
 =?us-ascii?Q?bhc44HjrzHFXNKVsULJ5p6xh3NMyq6RCCIQ0m0Y7uclYokSu9b064gyn6dke?=
 =?us-ascii?Q?SgjSn6MDa2pzJvj8TtdOV+IkYVYwAfQrnTvy/dAu3au8Y1q4ihcTqKbZOtpq?=
 =?us-ascii?Q?AiawNcTvaOcLSXtOwsBaLhmD5oOpq/l7jAChvvZEXqDE4vIqlDZIJladcr5N?=
 =?us-ascii?Q?05N9e1kAQWl7+9e2kwuyVUzZVAKqVFJ2drWG/okssOWRsoeiT8i1tNLddklm?=
 =?us-ascii?Q?UvxSn+kGMmbfzw+/y2xmxvdj6LX8wR5fUteLclRDBueusSO38fdUlYASe/zo?=
 =?us-ascii?Q?cKoQczLncitq82aNXmj3fcqpwCJUOyGSUAx0gsTZBc/IDNlW/xbya99lLFdd?=
 =?us-ascii?Q?N4ZRT0Au+fHVTwVRn5SF8s7Pop565B3+HNbwlMZRhYddKos3qlRRUoLyK95p?=
 =?us-ascii?Q?gaaWz/IC4Vh8tFvvH4lDQ/2Lx6k08eUEbS8xwjbWssTRirdUZemyYRIBwDfO?=
 =?us-ascii?Q?4ceov/foj1a3d9PGucUDOBoonB+xcrH5V0IkpDVjmUtAqQoiBbKfMaeTt7md?=
 =?us-ascii?Q?M9rktyvQT4dmbqosX6Nu0qxh5JQtGS7KZUr8rCvDfTTvSSd+t5p7V8MfHgRk?=
 =?us-ascii?Q?bxXAVDvqjSmU3k1id1DG6av/q6LuJm8S22RVxiMfgB+muocm1+6MYbEi6mYi?=
 =?us-ascii?Q?zlcqPuz85JDw+av74v6mkjOXBTbO/mZ8LUrVPM0WYRbYjy8R2gzXvAkbpBa9?=
 =?us-ascii?Q?fdLcqwXfQKVOwQymTNygLKfhyY4eP9HfDSMhyCpv2DKFNESQOQIzY8MIJFbc?=
 =?us-ascii?Q?WfzDq6m2oob2kohkdLwF8O/E5CsQS7+nGn4nqXGxp57q5MhgeMcOwUBpMfaS?=
 =?us-ascii?Q?zgiEViU/uX0+9mq5ZKVpeSOql/6arVRK3I+3XbVkfXhwbJWGpuMTT/Eik9zE?=
 =?us-ascii?Q?MwA5mFAX8rjH/GawLNNESnCpmtL8iRTVkEgcyl+gBk2npFrijKZkTMH3vtKz?=
 =?us-ascii?Q?XVPm6P/jn/Nq5Iy3rjwlLuG1SvNi5GS+00ZQABvnbQOt2YIw1eL2pNXL5Bmj?=
 =?us-ascii?Q?Xzbx39xQWALeIKYFUcQB06VIpmnBocnvBPXA6Jgq2BqPRP8EHfmJmEBm30Iw?=
 =?us-ascii?Q?03LzXL0UoFNyMjOCR1s8HMH7WkkbCP8ff8TLGcW1gRqWtvKOHGtA9lWzO8Ap?=
 =?us-ascii?Q?ExmT7vt4twXVNjaMYgiwbw6AktGxZU7gBQDLGxy95EbHxniAniwoUQmsnsrG?=
 =?us-ascii?Q?iZNcrntaQUdZCVdlPbd8awN3W/npKEf5GdQcg7aukUN6BqA8L6y1l9hZnFd5?=
 =?us-ascii?Q?fncaUisQtdz+Jh9SiY/hVLIYJcMqaGebJ/pMNYKyB/+9AoAG7Jc0GTogrSkd?=
 =?us-ascii?Q?G8kktx7loiPBHt/DRUKIIKR5pF8++xYHrHnCpKZ2zRNbmOFVL1hLk7ilfZN7?=
 =?us-ascii?Q?k8M1N7xbsiS+5uGtKZlB9f0hcgpWzMV6G4wPrxrakHWJFP3mwucVYkb6CMA1?=
 =?us-ascii?Q?ICGNfMq+roweS4BdmKherLXWUPMxMhBLLe5TDdsq9HiLWik4Spu1GXdAaMxA?=
 =?us-ascii?Q?zZW80rU3udD702DPGMv+aZ2SeVg0QK4pMGIZxaRXUfjVbIqg+F6/n4Cj+LYm?=
 =?us-ascii?Q?GA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	WXmfHjDnGiaESCJ9Y37yHwB1osM/JcZ+01hsJczMZmKiG+zcQD2IbIAnMX+O6IFTwxZEE3C9A4YhNau9+yt36rlZxrmaTKUr41vC1oEdFYx2Il8rBnVRimkW2NV53wPn7CcCc389ayNa6BOxfKHZIYiRY9IJQwh+B0gF66vD/ROBBtRZCoE69dNMdGyVKzXJKmH6nIwwRgChA2eKKNaU1/kSzVdC8m9zmgDJe7Y27RgAWHfRZsIh8u88ionk7tWhwA2dMYM6WIq6q4De9Q4hP3ArBbuMuTJProWA5Ba9cu9XoQIXf4mL/8AfaJ1rzpj6VRVqqEIPXzIiRHHkOQY4ndfEfTM4LdzVNIFMwuJ+YUM2KzPHb+mGjDNKcJjx0RIHv2T6hXk98tXdO9ApKkg7S+avE51zg8smfRdjFR/HxOuiF8nS2JpG+XYWManm2QHryiDGnStnLFhukR3hCxGfZG+gWjdZkGSjghoTwp5E1QVk+x7E1/wn6ZvQAbI+TQCuYYNgh+282B4aQVZw4KDzSFjSKC6HNyngrF9eQuJ4wRicsS5yMyfUTXheO5X50TKfhN0+30DtTxFGQpLz7dpfSZ5ueJ/kBR/2A12GRdMGUXc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34aa22bf-8e42-4cb7-5f47-08dc17a817af
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 22:03:11.1603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5RQ2qBE4Kmb8CPfPZqrJRTzALAjvxH8QFSImi6B16SLU3WUTqa+wUe2DPSuXgzbxKaC438Wz/qqvFVGUp0KRng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5554
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-17_12,2024-01-17_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 suspectscore=0
 phishscore=0 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401170157
X-Proofpoint-GUID: TBkASv73nCLxUWmQIPeAwI889Z2gGf4g
X-Proofpoint-ORIG-GUID: TBkASv73nCLxUWmQIPeAwI889Z2gGf4g

On Wed, Jan 17, 2024 at 10:06:28PM +0100, Lucas Stach wrote:
> Use the proper size when setting up the bio_vec, as otherwise only
> zero-length UDP packets will be sent.
> 
> Fixes: baabf59c2414 ("SUNRPC: Convert svc_udp_sendto() to use the per-socket bio_vec array")
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  net/sunrpc/svcsock.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index 998687421fa6..e0ce4276274b 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -717,12 +717,12 @@ static int svc_udp_sendto(struct svc_rqst *rqstp)
>  				ARRAY_SIZE(rqstp->rq_bvec), xdr);
>  
>  	iov_iter_bvec(&msg.msg_iter, ITER_SOURCE, rqstp->rq_bvec,
> -		      count, 0);
> +		      count, rqstp->rq_res.len);
>  	err = sock_sendmsg(svsk->sk_sock, &msg);
>  	if (err == -ECONNREFUSED) {
>  		/* ICMP error on earlier request. */
>  		iov_iter_bvec(&msg.msg_iter, ITER_SOURCE, rqstp->rq_bvec,
> -			      count, 0);
> +			      count, rqstp->rq_res.len);
>  		err = sock_sendmsg(svsk->sk_sock, &msg);
>  	}
>  
> -- 
> 2.43.0
> 

I can't fathom why I would have chosen zero for the @count argument.

We currently have zero test coverage for UDP. I'll look into that.

I've applied this to the nfsd-fixes branch. It should appear in
v6.8-rc if I can get it tested.


-- 
Chuck Lever