Received-SPF: pass (google.com: domain of linux-nfs+bounces-1200-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 18 Jan 2024 15:39:06 +0100
From: Christian Brauner <brauner@kernel.org>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: Jorge.Mora@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] nfstest_posix: add check for EINVAL when open(2)
 called with O_DIRECTORY|O_CREAT
Message-ID: <20240118-karierte-dortig-ee53d1a49abc@brauner>
References: <1705514501-2098-1-git-send-email-dai.ngo@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1705514501-2098-1-git-send-email-dai.ngo@oracle.com>

On Wed, Jan 17, 2024 at 10:01:41AM -0800, Dai Ngo wrote:
> The 'open' tests of nfstest_posix failed with 6.7 kernel with these errors:
> 
> FAIL: open - opening existent file should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
> FAIL: open - opening symbolic link should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
> 
> These tests failed due to the commit 43b450632676 that fixes problems
> with VFS API:
> 
> 43b450632676: open: return EINVAL for O_DIRECTORY | O_CREAT
> 
> This patch fixes the problem by adding a check for EINVAL when the
> open(2) was called with O_DIRECTORY | O_CREAT.
> 
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---

Thank you!