Received-SPF: pass (google.com: domain of linux-nfs+bounces-1272-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <bdd760d9-9900-43ef-8000-0e9ce0aa8b3e@oracle.com>
Date: Mon, 22 Jan 2024 14:44:44 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [External] : Re: [PATCH 1/1] NFSv4.1: Assign retries to
 timeout.to_retries instead of timeout.to_initval
Content-Language: en-US
To: Benjamin Coddington <bcodding@redhat.com>
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org
References: <20240122172353.2859254-1-samasth.norway.ananda@oracle.com>
 <995F0BB9-C709-4C3A-92F3-5EB9710A47F5@redhat.com>
From: samasth.norway.ananda@oracle.com
In-Reply-To: <995F0BB9-C709-4C3A-92F3-5EB9710A47F5@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SlZ5WnVLMkhaN1lqZE5ITlBndzMxdjBPb0lEUTZsRHVYOWFhY1dUVlB0VmRh?=
 =?utf-8?B?elcrSkxJS2s4ekZPejI0bVZsd3A2QWZkTHI1eUZ6amNONUZEU0NMVVg0azBG?=
 =?utf-8?B?dWdYM201RnVDcElZL3NKUk9qS1lqYklBVFFaWDNkTVRaNlVpMnVuYndqWW5y?=
 =?utf-8?B?eDNQVy90WTQ1WDQvaWJBWW9DcnpNR3FKTmdNNG1BSXJva0FCQWRxUXBkVDRX?=
 =?utf-8?B?SXJQaU11YVdMdEFXRkVVN1FPRC9pYTNwRmsvV0lZVnpHcG1Hb0VrTUVQSFVq?=
 =?utf-8?B?NmUzVUhBQlFJbUc0SGNZRmk5dis3YzNZaFpPaTJ2WTFXQ2VxTGovUGpOK3J2?=
 =?utf-8?B?Q2Q4ZGt2eE9uRHZzRFZtVHBEWFdsVFE0Q0U1cUpoNjhaaVZzb3JHTVhMaU1R?=
 =?utf-8?B?WitILzZndkpwQ3NBaGZGUEE1TTlYZ1ErSFFVRmJSc0ZSY05FMUdUakZyMkRN?=
 =?utf-8?B?eS9nRkp1TW9FTGJQOHRCVnQ0SU5VNCtkQ21IZkJCUGFUdUhMQ0RiTElQU0ZF?=
 =?utf-8?B?emxNcXhJWlloZXg1NEV6NFQzOGNwQ1d5bm5SNEdJUVkwNHQ2OHVOWkxzNTJ6?=
 =?utf-8?B?R1BpeTJPK3NUSExtNmxlYU1qUWN4aWQyVDJXZVVWWUhreWhpMGNsUGI1SkFH?=
 =?utf-8?B?aUFqNHdsMXVVRDgzQ05HUTg4ZUk0bTUzOWltZndJZUxURG9PS0JpR01CNkNB?=
 =?utf-8?B?VHlNRWREVHdkb1g4bGdsRFJVOUwxdndOdmNvUlFlN1JQcExFVHVaQXJDeWdh?=
 =?utf-8?B?dVlSaHFGbks4eHgzQ21ZNlVLWUVnQTc5SkF3U0NyZ2hUT0djSkVPcERxMDZo?=
 =?utf-8?B?UTVEOG85bHo3NXd1QXIwR3ptQ251V2NyNDczajBkd3hoalM1Z1I0aFQ4K0Np?=
 =?utf-8?B?dXFkaHRmWFovNjIxV3JGSEloMnAvTkY3VTZpVDRPcS9XY0NScTBpMG1pMHNR?=
 =?utf-8?B?SDJmQkpUbmNyZmlUZTNrMm0vajR4Y21nSm9MRXc4TGQ1aXRTaEtEVStZVG9D?=
 =?utf-8?B?MnNQTUxMR2VyZUxDeGU2NG9VWlloTzBqYytXU1hwakJpWjRtTjF2dE9pNW9h?=
 =?utf-8?B?VzgzTVA5Rk1NUUlMYUZNUVJDbi9PdjdTdW8rVWVaQlQ4Y05sNzIwRk85UVdw?=
 =?utf-8?B?bVZOWmJkUCtYTmlqRGwyUVdpalFOS0lnYjkvMmErSG1FK0xEY2JnbmR0QmRp?=
 =?utf-8?B?UExJYzZ0bjhabzFkazZxYnBTVHRybFZ6NWlnZmdXMHFKNEpTN1p3SGVoZXBJ?=
 =?utf-8?B?cWhqbXhZa2xOcldRbnZjRmt5ckIzbEpsUGUyb1k0N2lTVkJtNzZ6NjJ4U1Vz?=
 =?utf-8?B?MERDanlFNUo3bzRQSFdXRXlaUEFWaXFrM3pnV00zMnNzc3RCN2d1Y2hKNG5l?=
 =?utf-8?B?anJIejgxNk1LbXdVMEI1TzJJcEtxYUg1YnF6bUxkeHEvZlIxN3hhdjNNSk1I?=
 =?utf-8?B?SU9KbCtvYXdQcmZYNjRHazdETXg4Z20xQW5wVFRnNWNxS1NWMHpGb0ZQYjJz?=
 =?utf-8?B?WXN2blhBL1Baa1h5MDFUWkcrT1BJTGRZTmtIdkk2dFNSWXVvMCs4TVVVTWRY?=
 =?utf-8?B?cG1SOXJxVGg3VGREY3JIZXZUV2lOYkUxM1BUZzNqZVJKbXZteUhUVzNrQklG?=
 =?utf-8?B?UVdXdWU4MnRiY1NRVTJQeUJaYkVzYjJxcEh4WjhUNW85TUtGZGpxWjR2c054?=
 =?utf-8?B?TitlTVIvSzMrbWVvbkgwcVJWL2laaWNQNDNHU0pST29ibGJIVkpvZ3dURmx6?=
 =?utf-8?B?V0FCendmSWZWZWV3aFhaeDFSR01CMGFGemd1L3NTUlVWeml2UlMwd0pGQnZR?=
 =?utf-8?B?TFQ0ZURWc2U4STRQekhJMWFTNVZvVDMySm1qWVFJUHpWUTJWSGwrM21ZSThx?=
 =?utf-8?B?MkZyWEJzNEYrTFdrdDkvMjdRazdDS1hJZ2VjMkdTUlR3NVlpSTNpWDhza2tP?=
 =?utf-8?B?NENsNFNDdGgwZEZELzE5b25xMGhoUHNpK1JJL3huOFd2TUNFd3kvMkJRTTYx?=
 =?utf-8?B?NUJOd3hYZGFkN3FyaEpyNElxQUtkamR0K0picXhSOHRBZmJ4VzBPNjZURFZI?=
 =?utf-8?B?RDVmend1Ky9kREpqdnIxc1JIQkNvMjBGcGdYK2UycVdScThjWVBXZlBXdzRN?=
 =?utf-8?B?enNXci9qeE41VldTK3plUlBLaTZnbGdvclhodXhwOWZWUnFZUlFJK3F4cXg4?=
 =?utf-8?Q?OxwOcajYOigVxAKMl7sZQKA=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	VJe2yQ6kXlqhxy/Deb9rpk6nFUtUQO8GPJ7x004n8GvxTqKFOl5tbjYf8pNd5fziWt84BrXpSvGzqlVze51WRD9e+UP/X5OqArmDNP/xLOFgqCSjtSD47wVf16+juq3Zetll9G3YUJpQ6b+KO1UMjkV7mViBYVn4h81R+RpJQrCtKvaiFyt+TGZ7gaFh3/wEVa5s68M6akg5JwTHUmuHdyf+4DMpLaKS7KjvdKSh4+xOj0HGZ6572HpAKOUkRWM0C4WcaAz08uS5bjB4TmbLoM6DKQspJ+6b97sWV8Uz5OFs20TuY2zh5ZaHXcEjtfbogGzTeYkgEI1yliFi+t74yY+c0kj6iTnpPlUssJ1CB4esyrc7J0yP9U8+T7XLRgjedXs3z9FSgSQJ8XMvOXZF1MKhfMq8XaP+meNpaZrGUFIGbDGVBx/TWVFraqGBEurfycHn8tdSWfpBalFMcpOAWJUiPrSVKIOkmtZcFyRd0AdHc2egXNPIiknFYsjTfqExjEhmKyACVV+Kc6hTwn5JslQCJDTy9ZEwLmxFm1cEardEh+k+a+cgcNZ2tF6fFWQLXIxwcGJepI3gpfRIW6CA26QY6swsQPt/SlmPz2kHHTw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ad292cc-2c83-4088-a54c-08dc1b9bbe1d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3817.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2024 22:44:50.5506
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fNaAuzwNBJsXDi/457TKBZ6ydkuD7I9rWfnLdeiRf1jdHmN7P6odLUCyU5BE3ChydL5n0zWGsPDGxNMIRAVlUSWJRIVLXfsuJrsrSsr5NemLzQ8+k/qbS/rAGNSJKmYb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6471
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-22_12,2024-01-22_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0
 mlxlogscore=999 mlxscore=0 phishscore=0 adultscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401220162
X-Proofpoint-ORIG-GUID: zCvAFIHG-KAPazqyerUubWp8HLAuq5tI
X-Proofpoint-GUID: zCvAFIHG-KAPazqyerUubWp8HLAuq5tI


On 1/22/24 2:41 PM, Benjamin Coddington wrote:
> On 22 Jan 2024, at 12:23, Samasth Norway Ananda wrote:
> 
>> In the else block we are assigning the req->rq_xprt->timeout->to_retries
>> value to timeout.to_initval, whereas it should have been assigned to
>> timeout.to_retries instead.
>>
>> Fixes: 57331a59ac0d (“NFSv4.1: Use the nfs_client's rpc timeouts for backchannel")
>> Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
>> ---
>> Hi,
>>
>> I came across the patch 57331a59ac0d (“NFSv4.1: Use the nfs_client's rpc
>> timeouts for backchannel") which assigns value to same variable in the
>> else block.  Can I please get your input on the patch?
> 
> Oh yes, this a good fix.  Usually the maintainers won't pick up a patch
> that's only sent to the list, rather the patch should be addressed to them
> directly and copied to the list.  Can you re-send this patch to:
> 
> Trond Myklebust <trond.myklebust@hammerspace.com>,Anna Schumaker <anna@kernel.org>
> 
> and copy linux-nfs@vger.kernel.org?  You can also add my:
> 
> Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Sure, I will do that. Thanks for the review.

Samasth.

> 
> Ben
>