Received-SPF: pass (google.com: domain of linux-nfs+bounces-1289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 23 Jan 2024 10:59:04 +0100
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: NeilBrown <neilb@suse.de>, Jeff Layton <jlayton@kernel.org>,
	linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com,
	kuba@kernel.org, horms@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v6 3/3] NFSD: add write_ports to netlink command
Message-ID: <Za-N6BxOMXTGyxmW@lore-desk>
References: <cover.1705771400.git.lorenzo@kernel.org>
 <f7c42dae2b232b3b06e54ceb3f00725893973e02.1705771400.git.lorenzo@kernel.org>
 <9e3ae337dcf168c60c4cfd51aa0b2fc7b24bcbfb.camel@kernel.org>
 <170595930799.23031.17998490973211605470@noble.neil.brown.name>
 <Za7zHvPJdei/vWm4@tissot.1015granger.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GyC0Sk66xPHsCCpt"
Content-Disposition: inline
In-Reply-To: <Za7zHvPJdei/vWm4@tissot.1015granger.net>


--GyC0Sk66xPHsCCpt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Tue, Jan 23, 2024 at 08:35:07AM +1100, NeilBrown wrote:
> > On Tue, 23 Jan 2024, Jeff Layton wrote:
> > > On Sat, 2024-01-20 at 18:33 +0100, Lorenzo Bianconi wrote:
> > > > Introduce write_ports netlink command. For listener-set, userspace =
is
> > > > expected to provide a NFS listeners list it wants to enable (all the
> > > > other ports will be closed).
> > > >=20
> > >=20
> > > Ditto here. This is a change to a declarative interface, which I think
> > > is a better way to handle this, but we should be aware of the change.
> >=20
> > I agree it is better, and thanks for highlighting the change.
> >=20
> > > > +	/* 2- remove stale listeners */
> > >=20
> > >=20
> > > The old portlist interface was weird, in that it was only additive. Y=
ou
> > > couldn't use it to close a listening socket (AFAICT). We may be able =
to
> > > support that now with this interface, but we'll need to test that case
> > > carefully.
> >=20
> > Do we ever want/need to remove listening sockets?
>=20
> I think that might be an interesting use case. Disabling RDMA, for
> example, should kill the RDMA listening endpoints but leave
> listening sockets in place.
>=20
> But for now, our socket listeners are "any". Wondering how net
> namespaces play into this.
>=20
>=20
> > Normal practice when making any changes is to stop and restart where
> > "stop" removes all sockets, unexports all filesystems, disables all
> > versions.
> > I don't exactly object to supporting fine-grained changes, but I suspect
> > anything that is not used by normal service start will hardly ever be
> > used in practice, so will not be tested.
>=20
> Well, there is that. I guess until we have test coverage for NFSD
> administrative interfaces, we should leave well enough alone.

So to summarize it:
- we will allow to remove enabled versions (as it is in patch v6 2/3)
- we will allow to add new listening sockets but we will not allow to remove
  them (the user/admin will need to stop/start the server).

Agree? If so I will work on it and post v7.

Regards,
Lorenzo

>=20
>=20
> > So if it is easiest to support reverting previous configuration (as it
> > probably is for version setting), then do so.  But if there is any
> > complexity (as maybe there is with listening sockets), then don't
> > add complexity that won't be used.
> >=20
> > Thanks,
> > NeilBrown
>=20
> --=20
> Chuck Lever

--GyC0Sk66xPHsCCpt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZa+N6AAKCRA6cBh0uS2t
rEN0AP9CEZYRtw1HCZkVIlYZMNwhz/H6OyqLVzwuj3PnVvPvsQEA3tSDCr3d/R/8
VUhT41xnz7h80ztViAXIKgNavp04TgI=
=6b+o
-----END PGP SIGNATURE-----

--GyC0Sk66xPHsCCpt--