Received-SPF: pass (google.com: domain of linux-nfs+bounces-1292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 23 Jan 2024 09:04:33 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
Cc: trond.myklebust@hammerspace.com, anna@kernel.org, bcodding@redhat.com,
        linux-nfs@vger.kernel.org
Subject: Re: [PATCH  1/1] NFSv4.1: Assign the right value for initval and
 retries for rpc timeout
Message-ID: <Za/HcfyiuUi/Wpyf@tissot.1015granger.net>
References: <20240123053509.3592653-1-samasth.norway.ananda@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240123053509.3592653-1-samasth.norway.ananda@oracle.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?7uU0f2HKiGy5c29+YG/A97tfNjI/+rapYBQ8q9g09KmlfpCTZHcOY0RSUY1l?=
 =?us-ascii?Q?+V0+dNBaalbHRgS1HWCgzfPVFI0BQ9Pu32uC0O0a2xzkeDRVQtBtFSibX8ZZ?=
 =?us-ascii?Q?ic2q02V7hUNVk6QX0TUzwrN1kaG7fd2vjQs51ZqvXrCZG4cquL1rfyzs5q1S?=
 =?us-ascii?Q?h8Qkb5cX52mTUAIZXXfETnVCVN+WbWAiIyLKg5zdEoaMobJv0iLTF/l5Cm5Y?=
 =?us-ascii?Q?Fh8GsAZNDYnyhpk1Nm7QB+jMhOI+bUhndquEe/rtzmB/hyTbN5VJstSfGA4y?=
 =?us-ascii?Q?Js39ufBW+AfnAyAFZ7H3+vQYQj+rl+SxG72tC5EryaUrItygkQ1TeaqxHVb6?=
 =?us-ascii?Q?XJlW18EAyH81gtOELWME6yVU2ki+6Fiy3KiSJ/rJP7BhBCVtckyEtD0Xi/u9?=
 =?us-ascii?Q?Bg4wCWKlsR8dUlh2P4Da0G9aoiX6mc77P3Q5qQoxIgI+icBbkkBiF+17y570?=
 =?us-ascii?Q?N5rD+/VgLTHy8CZEW9Yr7toCtDKywQhnGBvno6FweOXh0ybPbplORj5Q80FV?=
 =?us-ascii?Q?6T7g4qP33GIZpoBPwL6RFtTbBJMS3WHKTaOHdB7FsvsPAflsfM+AHrFx7B26?=
 =?us-ascii?Q?Na38gq0z+VB58Pf7zET2AdYQmM/yuNiLu+rT+nhWorGZOVS/suck5qb57oT7?=
 =?us-ascii?Q?zDpbna1GezJvJR2bnxZxpE+vFozQ5f4rinSJ/GCv9Ay2/fG00KZHYH5tf9qM?=
 =?us-ascii?Q?5eMRBbvGFH1nDKu74V9ENIeedoMZhV2eK7zzqWX2phtNUFhBZkRxvslO3jF6?=
 =?us-ascii?Q?fM5zrYXWGTri7aTBbWEPmWY6zWKQECpIw+0+1nWDpkexUEBqZYRD788Cxdy2?=
 =?us-ascii?Q?iyEFsalb3VW612dpsxb4A+CARokNfCCak8rjPLmiishDtObxNpHUbAbZPUlM?=
 =?us-ascii?Q?ZJlBdJLdHg3Wh6WI8V+JYpOVdt6Nnp1raqq4y7cqY26woIsIkat6wy9PYU6A?=
 =?us-ascii?Q?2PerG9Q+J+9gJLd9k3hOSYh4Q9MhmV4bTLF53r9s2nTuYGYZQH+OfB6eTCju?=
 =?us-ascii?Q?1r2sk6IK4R+qbMhWxdGzrYb8Q0BtRuoN04IEBv09hephXk/oe+jc4QzErB6f?=
 =?us-ascii?Q?wld0BcinvX85KysltKboD6jQmt+DvVT1We3hRYzeOYtMPiYSrQaZpeVIaoGQ?=
 =?us-ascii?Q?XaQqydXJsmmqb3Hm/gFpP15KwuckpTqYSCf2FJUtjWLrAhrXM4uvJc6Dh3Hs?=
 =?us-ascii?Q?jm77ulbdO2CuvMC791a5Smj8SOyWuobGiivxFG8AJRVzZ3MhoneTWgN9rEYg?=
 =?us-ascii?Q?9bYsjyTwduJ9ftE1QGb87M2/zJGXuMvMsySzVhw7GKNO+E2ygJzWraBRnyNI?=
 =?us-ascii?Q?vCBek6ZdLzyG7D/At/efw76Dsv7f/+9K0r6OFWUl3mNJAgLpen9w9dI6OWuE?=
 =?us-ascii?Q?0A1lqfrGECuagEMQh3AqNgc8jchh0g+5TNx4gNFMM6xne/M+vDhJ3t94OGA8?=
 =?us-ascii?Q?bDjo2at4gz4JBETBrmBMhR+tKA9ZG84BZiY1auzhm9HRBX9pmwjZfaTCD6ZH?=
 =?us-ascii?Q?2C09EFaHSCqq/R6P0PgdlTFG6HDZNahIzYNes+rtvgG0gSmu2941YaZv4yP6?=
 =?us-ascii?Q?v3FBGmW9+eoapcRLRXqLMDqFUkZfoCl95JLFspiAYWNrQkK4EXq0iKoc1aHt?=
 =?us-ascii?Q?sw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	CYH6qmIAN1P6pooH2+OAzrK6+HxArpDpglNJBUVDwuPHW0RxBTSTN6RI2WOKbORPEnjKNjDpLyPdgWqBebZWzyZky1+/gQyXMFmDKSrOJwNHMIENRPveA8vgwoQetT6Z/tDkhSYmn+hXzOC1IugYS5A3p9B2Dr7qScjI2HtN5jN6AyW8vT+N7BqUbcDeUG/u/DiJ1QdEISuDxbAzF7N/ICg4ksP8jwqYkJtSxPotbzlEGeQvqGMqoZu8VqRlv2v/z5oKyAHURn0I+Yi5w5ef3nLeF7nTXSu2oFz3IzIt9yaF6wtPvH+LBpx+0lx+zZT0UF11jxOMbD/fQrAyWBV4moA2tnEQmMp4lPEoEzC2dTadRMFjGlvqEM8deTg1fZ4OcsiTGIdzcVaJr/tJpCKXMOo9I2/FegTmddUBcSlijSKIkkgIt4EKKTC2fKIxMxNto6NAIhigR0VBz9gA8K16x+tvK/cKe/f8DMd276AlsPD0UoqH2TYxllEu214nez64yfC9ZmrhzOJPM8SjWeLVTdBhN652ObgjMyrubL3rsVj3UOlo17haEzgNf96R0HLx9DhiknO0KpZLl1efMP7nZSOIYfrmJttQV7taJq+FgBs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4a775a9-7c71-40b2-1bff-08dc1c1c3b5a
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 14:04:36.3418
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Fo/9NjEzmMuFYRXY+Q7YZlHR31Y21CW0xGYdVmD66sHS9DgP7CKEsCVEg1pt9MnFdkiSL6pFbioaUqBrRZpww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5718
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-23_06,2024-01-23_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0
 mlxlogscore=999 mlxscore=0 phishscore=0 adultscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401230103
X-Proofpoint-ORIG-GUID: lwDqivusEZ8TfDjEZnz3mT-RMYEGmAaR
X-Proofpoint-GUID: lwDqivusEZ8TfDjEZnz3mT-RMYEGmAaR

On Mon, Jan 22, 2024 at 09:35:09PM -0800, Samasth Norway Ananda wrote:
> Make sure the rpc timeout was assigned with the correct value for
> initial timeout and max number of retries.
> 
> Fixes: 57331a59ac0d ("NFSv4.1: Use the nfs_client's rpc timeouts for backchannel")
> Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
> Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>


> ---
>  net/sunrpc/svc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index f60c93e5a25d..b969e505c7b7 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -1598,10 +1598,10 @@ void svc_process_bc(struct rpc_rqst *req, struct svc_rqst *rqstp)
>  	/* Finally, send the reply synchronously */
>  	if (rqstp->bc_to_initval > 0) {
>  		timeout.to_initval = rqstp->bc_to_initval;
> -		timeout.to_retries = rqstp->bc_to_initval;
> +		timeout.to_retries = rqstp->bc_to_retries;
>  	} else {
>  		timeout.to_initval = req->rq_xprt->timeout->to_initval;
> -		timeout.to_initval = req->rq_xprt->timeout->to_retries;
> +		timeout.to_retries = req->rq_xprt->timeout->to_retries;
>  	}
>  	memcpy(&req->rq_snd_buf, &rqstp->rq_res, sizeof(req->rq_snd_buf));
>  	task = rpc_run_bc_task(req, &timeout);
> -- 
> 2.42.0
> 
> 

-- 
Chuck Lever