Received-SPF: pass (google.com: domain of linux-nfs+bounces-1295-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <6206ba66-5bee-4a4f-9af6-cf10f93163d3@redhat.com>
Date: Tue, 23 Jan 2024 10:16:16 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] reexport.c: Some Distros need the following include to
 avoid the following error
Content-Language: en-US
From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20240122182909.97503-1-steved@redhat.com>
In-Reply-To: <20240122182909.97503-1-steved@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 1/22/24 1:29 PM, Steve Dickson wrote:
> reexport.c: In function ‘connect_fsid_service’:
> reexport.c:41:28: error: implicit declaration of function ‘offsetof’ [-Werror=implicit-function-declaration]
>     41 |                 addr_len = offsetof(struct sockaddr_un, sun_path) + strlen(addr.sun_path);
>        |                            ^~~~~~~~
> reexport.c:19:1: note: ‘offsetof’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’?
>     18 | #include "xlog.h"
>    +++ |+#include <stddef.h>
>     19 |
> reexport.c:41:37: error: expected expression before ‘struct’
>     41 |                 addr_len = offsetof(struct sockaddr_un, sun_path) + strlen(addr.sun_path);
>        |                                     ^~~~~~
> cc1: some warnings being treated as errors
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... (tag: nfs-utils-2-7-1-rc4)

steved.
> ---
>   support/reexport/reexport.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c
> index c7bff6a..1febf59 100644
> --- a/support/reexport/reexport.c
> +++ b/support/reexport/reexport.c
> @@ -9,6 +9,7 @@
>   #include <sys/vfs.h>
>   #include <unistd.h>
>   #include <errno.h>
> +#include <stddef.h>
>   
>   #include "nfsd_path.h"
>   #include "conffile.h"