Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1401575rdb; Wed, 24 Jan 2024 14:19:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEH4aw965QLMcMGtEdwqtzO6OFb67QkPF04j1n1Qz1LAlFI/j00C4XIiYXPp44mZnHOMohb X-Received: by 2002:ac2:510a:0:b0:510:1bc7:c51d with SMTP id q10-20020ac2510a000000b005101bc7c51dmr1061lfb.138.1706134798511; Wed, 24 Jan 2024 14:19:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706134798; cv=pass; d=google.com; s=arc-20160816; b=hJ2NkLxBDluB4Ou8U/JwGnphAXg/G/IT22QqVqPfRW87FUY4GFb8sYAEdDVPrjFaWA VCgTWeNSxrXf2jlQC5G8iMWgGXRZ04CmdziE9PTAfqUtueriBuuQh3ZpUlE2naZPCq5P pJJLvHE06HgCCW54goXstdIBJvAHxuYRF6TLWC04W1F+Jtng/gEwQyzPwbuzqYFFkgQv iTi6pflPZdTjMHNTaQ7ICPmkjCe2ZGZ1mJdl/3Ao/0ZRlrSkHVySPC/tayHClXX/lqey KoF3EWmgedJ/3S/y6IUd6Yvl3PhMPY5XqfGx+8j8SCkRoM+5jl9GxS0x4w20fwR116LY Xeyw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=c66VGh9XqmzYboRiMy9uc+ZkLRhKItXJFF89uKrOGh4=; fh=t6c1dwpAlHoondLJ2UYIth5Dpp+tyC/JRcf/+xiX3oU=; b=tz+0mRGoxRoFjxSrL30w8GSOWEA+lIlQjeJn25JnxEt+A9/ftN2kwf5HB2Uv4d3QxG NKnVZXLxDiH85GBh//tNpyWaEnepWhkNjGbtPY/crPrQ5IHL2BHkQuPAvBXkhwYuekDq iMVx0EN48AlpC4kkiKNG7tN5/Xy2ZUG1StxwzBdoqj+p74Xa4eKFBIiMz2YJEUjo0sFW 3Ag+/Gq9j0eB22g1qg0mma3KOZkht5axEGxs/6F7F1vm9qH3/yLb8rOhjg+LrcrXa7HA QJ9lJuB4V6brGW1jEJgbSnOR3VzZ2ZE/OIW74EBup+W2hTFlN/bkJKd+d1qJHeef7DFf rRdg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Ih/oWMND"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-1319-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1319-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id jp17-20020a170906f75100b00a26aa69bb75si302487ejb.936.2024.01.24.14.19.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 14:19:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-1319-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Ih/oWMND"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-1319-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1319-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 35D171F22A49 for ; Wed, 24 Jan 2024 22:19:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1F1771350DA; Wed, 24 Jan 2024 22:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ih/oWMND" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA1F051021; Wed, 24 Jan 2024 22:19:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706134795; cv=none; b=fFxqyI7nBSISiVPWrFAe/io8iY1bHdrK1eIaCXbwZnbaKwoAgGg8JIaPzqaNyX1j1TUx/dkhtfUk2c2KKVZHmp9nmLOXnajAox0DPrDNWiXw1VHU8p+aCCeErw0+dZt2BNvB6Pf+SOXDlQnS/VQCDXFg01LzLZMCi+Jsq3BXTwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706134795; c=relaxed/simple; bh=mwSyI2tFMZCy/H1eNdpdEPpOtmy2Jgy7mh2Z+8VMiPE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nsw6vjBp4Rjz+oN0dehW9sWopxrTkktftIZa4fEzr9aK2KtB5TJ1+cpd3wibiD8UIPhKCyLMDEg7eSq6ceTIlIGkoAzQCG5SU4asCxQiRTRfkQwvcObvDh0sMoic5IagH4bLxXiC8dRH1bX+zaMHR35meqkK4x7yy6zTlvmHVQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ih/oWMND; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20316C433F1; Wed, 24 Jan 2024 22:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706134794; bh=mwSyI2tFMZCy/H1eNdpdEPpOtmy2Jgy7mh2Z+8VMiPE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ih/oWMND2dnnVsMARNU6ZDphtL5GBUZdlHf/n20Qb1OSUYKxNCa2Q6pdRs4zWyRZb mWKUn/OtJlDaQoFktLMbtPnIfQAVhxzHdFZP6LU6gD9KVVjMft9/Zuv2yS6B+oTdgj udM8vSewH/zBHqx4SmocSLMqRt81U6Qn0bDKnGQ6HBYr6aGqHNsjyMN9dka+nYl7WN hm6DYs8dcxI86NJ+8a0bFqGbXsRMUgSkTFtzwhvByRlYuPaADLHyhZtKiNsKbhm2zx xLwGooJlzbNz6vNUfVEr/nJcUID3dkMg97tQbZejI9eF2oPpcT5zRxwc9ZtbFJb4R+ rQD3QDCU8q+1g== Date: Wed, 24 Jan 2024 14:19:52 -0800 From: Eric Biggers To: Chuck Lever Cc: jlayton@redhat.com, amir73il@gmail.com, trondmy@hammerspace.com, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org Subject: Re: [PATCH v5 2/2] fs: Create a generic is_dot_dotdot() utility Message-ID: <20240124221952.GE1088@sol.localdomain> References: <170575895658.22911.11462120546862746092.stgit@klimt.1015granger.net> <170575907468.22911.10976023123447238559.stgit@klimt.1015granger.net> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170575907468.22911.10976023123447238559.stgit@klimt.1015granger.net> On Sat, Jan 20, 2024 at 08:57:54AM -0500, Chuck Lever wrote: > From: Chuck Lever > > De-duplicate the same functionality in several places by hoisting > the is_dot_dotdot() utility function into linux/fs.h. > > Suggested-by: Amir Goldstein > Reviewed-by: Jeff Layton > Reviewed-by: Amir Goldstein > Signed-off-by: Chuck Lever > --- > fs/crypto/fname.c | 8 +------- > fs/ecryptfs/crypto.c | 10 ---------- > fs/exportfs/expfs.c | 10 ---------- > fs/f2fs/f2fs.h | 11 ----------- > fs/namei.c | 6 ++---- > include/linux/fs.h | 11 +++++++++++ > 6 files changed, 14 insertions(+), 42 deletions(-) Reviewed-by: Eric Biggers - Eric