Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp69408rdb; Thu, 25 Jan 2024 08:28:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUeSRbLiyz2VGx+Tc5BCe+wZB7E+mZ5krA5D+B8bEtUAJ7eakpfmNvh3ltqudcVMHZlMjr X-Received: by 2002:a17:902:9a01:b0:1d8:8e77:5bbe with SMTP id v1-20020a1709029a0100b001d88e775bbemr159220plp.34.1706200123599; Thu, 25 Jan 2024 08:28:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706200123; cv=pass; d=google.com; s=arc-20160816; b=tVVpQ1GMa59sZvhjCqC1GIHm+fcYKPvITPpSiCq9w79JdR6BNaBwIO8uP6ozA06fNU zEYym9TrLS1b16ZHisohS8cxCnPQm6bUThRe7SJgGeVRF5ThAmq9evIzMO5Kn1R7A8+d A8x3+cT1FTWyXAqtf0GBJkRJQjmqosUvL5j6p+XIc1Kdav8PXy3xgjeooqLA3uqtcjeH gfE2J6VeqAmtB00s55E+ugmxeRizlDgAyCP7ATqBa86Hdturz4dnMKfG4oYyXh+p/Qs+ ET12lckRtsfEqibR2LgjOH+bHjCoDoVmFQ/LBDttbMD3uT8qL2/C9oes3IQxsguXO0bW IEIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:message-id:date:to :from:subject:dkim-signature; bh=FPayKv/9xJObzNMmU3iyIHA2gqN8OM2jeYxYqP0Kv50=; fh=Mys3y4MwsHRytUQMpdfGBn3oGRYLcLloxNwkFYMYMmg=; b=M+AAgrfREM/TxByhKpg4TDii6hoKs608UXndIVw5jVw7vMEQqloY9a0SwNG8UrW4xt OVRjSDZRnyY0EXVOcofafHsxt3bvU2HIbjvi5vpi72JrNSMfZAfVC91JmCMBRJ6fGKQA rMcn2FvTKatfkoxKYJCCfU/QNE9ItoKdjPaz0CjO68n4UPszhmny6dTpIXYxdNJIez2r rQjyGrVknoS6uI37/pjk1qVKGVmnN/bEipEtLbdd5ssVw11Qi1KJNBJHJTdhV/lJ2v45 jBul4EWl6SBnZEqg6dOJ0G0rH6Ssb+rFLvcV7yJm9O6yl7lrxNCyNZQLh1tE9oWTVFyL j5aA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l0h7ZcX2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-1386-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1386-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i4-20020a1709026ac400b001d3a84c053esi13273245plt.247.2024.01.25.08.28.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 08:28:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-1386-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l0h7ZcX2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-1386-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1386-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B688E297C44 for ; Thu, 25 Jan 2024 16:28:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5EC977762A; Thu, 25 Jan 2024 16:28:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l0h7ZcX2" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39D7B73177 for ; Thu, 25 Jan 2024 16:28:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706200121; cv=none; b=N6IaAsl/dxemoUqVDtDDh20hRtQoVXHLF4ebcpdFddGsfdY0a6AAV8wo5a2OnYOHdlcqjOhVK1ZuB9M3caG05ALZwMITmTd1zvj3n/zjiTuKCViJDy1Al9U04wMSdqvjTsyKUPfJYNgme1m/reiyw8JZDVVNlu8yhoVojrmCn+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706200121; c=relaxed/simple; bh=i2Y6yXDRLAHbGZr1OVFW3UAwZILAyKrA1+Zl4amBkWs=; h=Subject:From:To:Date:Message-ID:MIME-Version:Content-Type; b=a7KzLOtgiuFZsaxsCdkWI0SkpaVCOamg4n1Dkrt2wTcyFPKAnUuTFaWQnkpU0Avyb2t7FuYsqip8fIGS4mX+PlH6s5TgIPDTd6HTmTW8OH9nRyMGlM4fz76BHeNqJtlfeUPlx4l5NdmU8fi9xV/+gKXLXWldlHpP+dLccGoJb6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l0h7ZcX2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACBB8C433C7 for ; Thu, 25 Jan 2024 16:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706200120; bh=i2Y6yXDRLAHbGZr1OVFW3UAwZILAyKrA1+Zl4amBkWs=; h=Subject:From:To:Date:From; b=l0h7ZcX2p1dW34+TCIT5WsyY5kPtUxYGRji36VO8r60NW+jWHVpWxmLq77D4A43N8 aTDybLA4pxSoE4UeAOdmcznP17Vl6tATqPVAmd4k1J8Aqsdn8YtQImJzM+fWJ+oipK BnqhXWFpK1NwmTBx4wtqcrl/d4ahLdWpr37GxZ7G6BIdcfbrpGz/0YZO6uQ6tDgk5O a482TnZwkI3uuJEaB7LMrql0PrMdFaAjinPe9+YV2vAPlss6WpJmIVnf5A7N13L+Bm n4wTCTGxU3ovVGYqeDe8uBLhh8MJ7eKEOxHVS1tiqu99tC+DhJYuqSmMHW/d2fhyA8 efTxoAiFdhFYA== Subject: [PATCH RFC 00/13] NFSD backchannel fixes From: Chuck Lever To: linux-nfs@vger.kernel.org Date: Thu, 25 Jan 2024 11:28:39 -0500 Message-ID: <170619984210.2833.7173004255003914651.stgit@manet.1015granger.net> User-Agent: StGit/1.5 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit The first three patches fix bugs that prevent NFSD's backchannel from reliably retransmitting after a client reconnects. These fixes might be appropriate for 6.8-rc. Following that are some new trace points that might be helpful for field troubleshooting. Then there are some minor clean-ups. I am still testing this series, and there is one msleep() call that needs some thought. Thoughts, comments, opinions, rotten fruit? You know the drill. --- Chuck Lever (13): NFSD: Reset cb_seq_status after NFS4ERR_DELAY NFSD: Reschedule CB operations when backchannel rpc_clnt is shut down NFSD: Retransmit callbacks after client reconnects NFSD: Add nfsd_seq4_status trace event NFSD: Replace dprintks in nfsd4_cb_sequence_done() NFSD: Rename nfsd_cb_state trace point NFSD: Add callback operation lifetime trace points SUNRPC: Remove EXPORT_SYMBOL_GPL for svc_process_bc() NFSD: Remove unused @reason argument NFSD: Replace comment with lockdep assertion NFSD: Remove BUG_ON in nfsd4_process_cb_update() SUNRPC: Remove stale comments NFSD: Remove redundant cb_seq_status initialization fs/nfsd/nfs4callback.c | 81 +++++++++++++------- fs/nfsd/nfs4state.c | 1 + fs/nfsd/trace.h | 162 ++++++++++++++++++++++++++++++++++++++- include/trace/misc/nfs.h | 34 ++++++++ net/sunrpc/svc.c | 1 - net/sunrpc/xprtsock.c | 9 --- 6 files changed, 250 insertions(+), 38 deletions(-) -- Chuck Lever