Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp70079rdb; Thu, 25 Jan 2024 08:30:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFA9iAEY8Y9tf1Md9XP7tO+sVfm2sVc3t7OlFgtxMzRgGdqf49Ac0aHVMBWSipDTb7HSPmQ X-Received: by 2002:a05:6122:1692:b0:4bc:1da9:dfa0 with SMTP id 18-20020a056122169200b004bc1da9dfa0mr595924vkl.21.1706200200300; Thu, 25 Jan 2024 08:30:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706200200; cv=pass; d=google.com; s=arc-20160816; b=RL6Q7512htJiDMQoH7Jctx0hkOrg7bDOk03X60JU0HjdZdLhe+cYUFv/tDvApM/1iB 0g+r2Bft0ZafILZkPjTZwy7fJ6dGxR1AmES57A4JnboBNewYak/Ie/RioS2LCrROw6/H RSgJMkLxIgTredovr8BEhM8BPNUhAFZzTEFeNjSCe0bEq431aMRMBXbHkXLtu+bkr7DQ Sdya+cjLbbuy71l6d5IG8ApAqeGu1Y5q5Zr0Mrl/Hy/k6w4NixxSj8V7noLUwhhrvnBH h0XkYeu+PPvrYnLXc4S9okKM0vTgUeRYh3l9LZTuD4SPBaa5dAfXzs94KNm7TBz/cUQ5 0IYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:references:in-reply-to :message-id:date:to:from:subject:dkim-signature; bh=8B40wVhRijWEtAIXu5qePG4IzYhxZzSJGdWsKSRH2rY=; fh=Mys3y4MwsHRytUQMpdfGBn3oGRYLcLloxNwkFYMYMmg=; b=byO9ipHs0zdw+bVXne1t/JghaA7/hlgkfju1B6hOuvzH5si/O6zdtjr7uOwRmbVDpt kGxHLZWC8cCTO20jdYOuDuWCpkmL/1SShUjjkAR2T/uTy411bkto/2AeWYjtZxLoxSSv w8ln9I7wZItn2hUs7a4OdhxMa7NlF5VMLBQvMs8N95hpNPuYyk3cFmf6bNl7qK/fCkW0 Bhrphz9PttrTJJ/k7m+C5DgEhUbUiC6GpaQ9exP235zq1wUKMLgGyJIgb5ufj//Erm+B CYMo8/JwyIrxZBHK8E/AhVgMxgrWlkxSru8tWtTVwVzIwU5AwghoVsDGFNkdC0n7KBPC I09Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MJeXNzDg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-1399-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1399-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id e3-20020a0ce3c3000000b0068179e48e97si13112878qvl.164.2024.01.25.08.30.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 08:30:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-1399-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MJeXNzDg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-1399-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1399-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 122621C2531F for ; Thu, 25 Jan 2024 16:30:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D388F129A7D; Thu, 25 Jan 2024 16:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MJeXNzDg" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0118129A70 for ; Thu, 25 Jan 2024 16:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706200197; cv=none; b=OUT32IDhiV1cmXT9KLJ2Hg8ykXe2DpGviIJ3QWuvpFI7zn26rTpTBlvtM4ZnQejq3xM9tl4HpojSwN5Kbofb2OibuPc7ODiRjqKFamL/vQavvCI+KCUs6Kdye0dZyE/sOqcs24wJp32ghmQ9GFGWUYsAoELMCaXdDhibaVKTGXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706200197; c=relaxed/simple; bh=fCulokz3BjzzNImUyQKnWwQdKoAXzN2sH7HV8gn//l4=; h=Subject:From:To:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y3CNitWs/TLj6xVIpPJJlK/cDEb3DpaeSHGCzECsJIxaQg7SEXxHbZoU7DjrIYThfVXMAmpGyX10Z7MP7d/A5fx7EIL88Je4Yemvm4jDZUw6AUrQsISXsxFRuuSDWJKOwOn/CWOqD/mCTFd6c3h4nnwhf0yO3HPz3JTI6GV9CuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MJeXNzDg; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68507C433F1 for ; Thu, 25 Jan 2024 16:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706200197; bh=fCulokz3BjzzNImUyQKnWwQdKoAXzN2sH7HV8gn//l4=; h=Subject:From:To:Date:In-Reply-To:References:From; b=MJeXNzDgl/yqC3yjexDWlTLF0gKUVvTehsvTVAED1nYOSNcwMsz6BJVQt4G9YFdsl uF3PQZI7hNiMLq1Ca4qG3fVWdKw89H1QX3goBqNxiv0mdHTlKShYQnS+eoGskx7IIe +/PX+eE7KuWnL0yU/SL6QsuCDW/svBOusoRKL/qiehhNYrQR+AjIt9BOU73/CNkIGr xKe7vUYOxpZfOZvQOm7tgqtZxAkUKSugbSzn2cMfIXVhxibcL59uv2FhiykqefjkOW ifvskCcix030cV4GqMAsPJTZOGTZDC7wnEg5dvMLIyUzGPw/hmvGIU1AoGGlrPNCRr czGgFCFOx9QdA== Subject: [PATCH RFC 12/13] SUNRPC: Remove stale comments From: Chuck Lever To: linux-nfs@vger.kernel.org Date: Thu, 25 Jan 2024 11:29:56 -0500 Message-ID: <170620019647.2833.15727263058832480637.stgit@manet.1015granger.net> In-Reply-To: <170619984210.2833.7173004255003914651.stgit@manet.1015granger.net> References: <170619984210.2833.7173004255003914651.stgit@manet.1015granger.net> User-Agent: StGit/1.5 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit From: Chuck Lever bc_close() and bc_destroy now do something, so the comments are no longer correct. Commit 6221f1d9b63f ("SUNRPC: Fix backchannel RPC soft lockups") should have removed these. Signed-off-by: Chuck Lever --- net/sunrpc/xprtsock.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 58f3dc8d0d71..d92c13e78a56 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -2987,20 +2987,11 @@ static int bc_send_request(struct rpc_rqst *req) return len; } -/* - * The close routine. Since this is client initiated, we do nothing - */ - static void bc_close(struct rpc_xprt *xprt) { xprt_disconnect_done(xprt); } -/* - * The xprt destroy routine. Again, because this connection is client - * initiated, we do nothing - */ - static void bc_destroy(struct rpc_xprt *xprt) { dprintk("RPC: bc_destroy xprt %p\n", xprt);