Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp70897rdb; Thu, 25 Jan 2024 08:31:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGn0KrZcF14QqVkVYitNgPDjpWKA8oc8v/AOAJU8Dwmx/gZ+ibRUAh6CsApoI4BAuglB3ss X-Received: by 2002:a05:620a:1a26:b0:783:bd4b:d0df with SMTP id bk38-20020a05620a1a2600b00783bd4bd0dfmr1672756qkb.99.1706200270266; Thu, 25 Jan 2024 08:31:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706200270; cv=pass; d=google.com; s=arc-20160816; b=w/kMr1hyz2LE3DdPJz116dReEaDY/L0J5TeEEta8Nw7TgUVeZFC0Sdb332nSvNcu+L snafkpYXzsTZjY2hS3VDt9TbLj7hEBoFMkfy4HLEn1YHSQixkcK4/oTq7efZAovh94fa CklsTro/O0cLlAZrF2697jiceqZDzO7RbT94YBR52wEBBf0aXbdLaaVXmN+7DSJbnHUa eIpY0l8MstkYu8pPZ4GPs4CpaSi/QYdIOhMsFoB47aPgl/GF38chsrlDoTcnslEK/ban n3TcXazKMulG8G+akHPl2hZNjODnLa3jWBSKewclBkJbm3xL+a9WMrxH14QcNrffZeQ9 3Ctg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:references:in-reply-to :message-id:date:to:from:subject:dkim-signature; bh=3UfHsO/AmIVBZY2kjpcz8k4wa2+SFotaIFDTn+Me7eU=; fh=Mys3y4MwsHRytUQMpdfGBn3oGRYLcLloxNwkFYMYMmg=; b=F+OQFMajOxopoZeQKjkTsMNz+zR9NQBZ49kyNPRsbjkLJ1Qnkd/N9a5BFAsURZ5nYv /ZXZAyHnyvpsuqdi3Iw+GJAjRQ0NY9CY/Y/cQfYD2OlkEAXqLheIjcU7bPcnCBhBfY8d OAXKugvg7QBBxJsTUjTdXF/F6fIHTWGgqIMIJrbN9PXAeVhG+xxKYOhoB8j4YTIf1OMr w27Z9bk1DwmQ+VHQJRhnkKowWSC69d87C2EwpLI05zYm2ii08yRZMBqGZPHPXdfoDKma Ggezi+PXGhvfDOugAoJrEoveYOeP2Bk6pme9kQrSrtLQj4PJv75qVqdtMRDFWNmA4LB+ byww== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MlK5ZxFu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-1400-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1400-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id y12-20020ae9f40c000000b00783b5c83466si3922049qkl.336.2024.01.25.08.31.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 08:31:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-1400-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MlK5ZxFu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-1400-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1400-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CCCCB1C20D1F for ; Thu, 25 Jan 2024 16:30:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 320D5768EE; Thu, 25 Jan 2024 16:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MlK5ZxFu" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EAF77316A for ; Thu, 25 Jan 2024 16:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706200204; cv=none; b=dl0c+dms6IatJPMiHx0pp0e3fS+MQUX5qWREs/nVXUdMgwkYtFTZBpJF2pAY2XjQUgsxjU1Yki8PgO6yMiQ5axRVnQNs8JQL6XFf6gcU18m1Ne3ekqabh/CWpoBQaaPBwOyYSC/XuOeaSBPBsWFIP+EwRus6L4/7cL+gD3V1Af0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706200204; c=relaxed/simple; bh=7l4u3xIr3J7Fi04C0U1HFphRw43b5KA1MPBxqwGcSd0=; h=Subject:From:To:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iTEzm9LX2GX9e1qDTxfXvZm5AvO9/CLn4OC6ekvVV2sxLH0nsEOQnHSG1bVw3Ms4bb7OjBSP13vm+FtVA+mcg+6bRxFEQdQ/KE3NzGjHP2yeIVSDiSkpgPmpAUmN06xvP6drycrNoKWkEeM1noCbbu5TuGIVDOWRyMMImgdh0gA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MlK5ZxFu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB7A0C433C7 for ; Thu, 25 Jan 2024 16:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706200203; bh=7l4u3xIr3J7Fi04C0U1HFphRw43b5KA1MPBxqwGcSd0=; h=Subject:From:To:Date:In-Reply-To:References:From; b=MlK5ZxFuuGwPC7GZxS75i6Ck3fe+bDVRsAgnZ/ADVBrEj6GVp8jffFQXfYAdSu8HC pGmFatHSAuAfgnt6MTKXChb6iQeggTr7kPr0yC91H/WHs+rYQyxUpKLWkgMGQ/J678 GBEaY3qWusXoSHhabowf+xh4bCXNq8/2OXiFNHYDT9kKgY4nT+xJBbyWNcMP2KC7Gk QLbNwhxbyXtSblXK9csxmmUwFtrtf1hGK4wlmMfYSFniHq5fvWa/gg4PMSwrJGxFSu oB7RjhJOsSyR0ZUtGbR3sOystfXxdsFr6fp4UYYw+sBHUZlVYESMgF/NRD8Ngrjwck 555AympTEhk0g== Subject: [PATCH RFC 13/13] NFSD: Remove redundant cb_seq_status initialization From: Chuck Lever To: linux-nfs@vger.kernel.org Date: Thu, 25 Jan 2024 11:30:02 -0500 Message-ID: <170620020276.2833.13226851823042560273.stgit@manet.1015granger.net> In-Reply-To: <170619984210.2833.7173004255003914651.stgit@manet.1015granger.net> References: <170619984210.2833.7173004255003914651.stgit@manet.1015granger.net> User-Agent: StGit/1.5 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit From: Chuck Lever As far as I can see, setting cb_seq_status in nfsd4_init_cb() is superfluous because it is set again in nfsd4_cb_prepare(). Signed-off-by: Chuck Lever --- fs/nfsd/nfs4callback.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index 46ecb3ec0f8f..e72a904f120b 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -1443,7 +1443,6 @@ void nfsd4_init_cb(struct nfsd4_callback *cb, struct nfs4_client *clp, cb->cb_msg.rpc_resp = cb; cb->cb_ops = ops; INIT_WORK(&cb->cb_work, nfsd4_run_cb_work); - cb->cb_seq_status = 1; cb->cb_status = 0; cb->cb_need_restart = false; cb->cb_holds_slot = false;