Received-SPF: pass (google.com: domain of linux-nfs+bounces-1424-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <8a7bbc05b6515109692cb88ad68374d14fc01eca.camel@kernel.org>
In-Reply-To: <8a7bbc05b6515109692cb88ad68374d14fc01eca.camel@kernel.org>
From: Cedric Blancher <cedric.blancher@gmail.com>
Date: Thu, 25 Jan 2024 20:54:40 +0100
Message-ID: <CALXu0UcV0b8OvH7_05tD7+GRgoXRcp9fd1aXuHjtF2OBDPmSJw@mail.gmail.com>
Subject: Re: Should we establish a new nfsdctl userland program?
To: Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>, Lorenzo Bianconi <lorenzo.bianconi@redhat.com>, 
	NeilBrown <neilb@suse.com>, Dai Ngo <dai.ngo@oracle.com>, 
	"olga.kornievskaia" <olga.kornievskaia@gmail.com>, Tom Talpey <tom@talpey.com>, 
	linux-nfs <linux-nfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Thu, 25 Jan 2024 at 20:41, Jeff Layton <jlayton@kernel.org> wrote:
>
> The existing rpc.nfsd program was designed during a different time, when
> we just didn't require that much control over how it behaved. It's
> klunky to work with.
>
> In a response to Chuck's recent RFC patch to add knob to disable
> READ_PLUS calls, I mentioned that it might be a good time to make a
> clean break from the past and start a new program for controlling nfsd.
>
> Here's what I'm thinking:
>
> Let's build a swiss-army-knife kind of interface like git or virsh:
>
> # nfsdctl stats                 <--- fetch the new stats that got merged
> # nfsdctl add_listener          <--- add a new listen socket, by address or hostname

Absolutely NOT "hostname". Please do not repeat the mistake AGAIN of
separating "host name" and "TCP port", as they are both required to
find the server. Every 10 or 15 years the same mistake is made by the
next generation of software engineers.

https://datatracker.ietf.org/doc/html/rfc1738 clearly defined
"hostport", and that is what should be used here.

Ced
-- 
Cedric Blancher <cedric.blancher@gmail.com>
[https://plus.google.com/u/0/+CedricBlancher/]
Institute Pasteur