Received-SPF: pass (google.com: domain of linux-nfs+bounces-1433-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 25 Jan 2024 15:53:24 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-nfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 05/13] sunrpc: add a struct rpc_stats arg to
 rpc_create_args
Message-ID: <ZbLKRC1GkiKUkK+L@tissot.1015granger.net>
References: <cover.1706212207.git.josef@toxicpanda.com>
 <4cc2a7aca55ff56ac3ced32aafa861f57f59db02.1706212208.git.josef@toxicpanda.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4cc2a7aca55ff56ac3ced32aafa861f57f59db02.1706212208.git.josef@toxicpanda.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?KfqvBDWa4p1sLYGbA/LzTfdAMXYaRtIYSctaXn3L944m2hxMaUAhVSaEL+Xo?=
 =?us-ascii?Q?9/K8an0NVmVAb13MWI0UKs+Afy4nsw23GhfFUoJNH5H/bSrRV6Ij6S58kADt?=
 =?us-ascii?Q?Xb+9EJVNIEg04lRZGwrMOUPbyaqW1UnNz4HPf5cUHmrFkHdRwipsYEGmyd49?=
 =?us-ascii?Q?b7F5WR8MSBE9F99jeqO2qu1Ymep/r2Bq6+bc4issGpQRvDUqz1bdfQsmkHXR?=
 =?us-ascii?Q?C9rCL8w4xzKZHkvYBx6Cfx/OAbCAGAz3u8v75ZGYfJ1Leeyg/nwMUCPne8vz?=
 =?us-ascii?Q?58fZkGt4pkkrhBxGJx27+MEsHGWPWcHDnDYcDwKtTViPygdmtssslmDZwlSn?=
 =?us-ascii?Q?6mqBw7Y6t/ZFeuiM3F1bN9jUWz+VPhTr/c2xYBgJoo2W7uQFXEqTE7aLDfrx?=
 =?us-ascii?Q?DIR2crloaJZloskACAzXynO5ZfhM4bnUbkTrP475j6XkxmAUHuOTd3hnfzcU?=
 =?us-ascii?Q?L2nESKhOZiw3epo9M//ZKc34WBfcw3vSF3ewDFY7VgNO2fNpjK6wKmVpC8Wb?=
 =?us-ascii?Q?0qn7qD5Fq1Rt4tVkatCdHnZy7xd3wIuIggYf3WEQxq4QOIRu6NVAokDZMwSL?=
 =?us-ascii?Q?1SDAnXUO9gdSJwip4TiJu4S6BNyWWUFvZ4d204YOPR8OW39m4jpsxOSAIeMK?=
 =?us-ascii?Q?sAdWVOgQr1CRr/C0Q4qIv+whvZJOXl3HHXkwFL7Kzx+YC9YGFglh4XB2bEjM?=
 =?us-ascii?Q?ZH1mZAApP+0dkOUYxvJSTIv02MY1aDGIwzMYKQDA+SuuLGs4+d0ptYBQYBuD?=
 =?us-ascii?Q?d+8Rd9y8xgmCs9thjaV6F2eKQyQziTxYYeK/DqNAzJkWNyv6ZoXSog+7qYvc?=
 =?us-ascii?Q?mMpXtqemm5HpFnNnsh1pfBmWxQKEkpQbmhpcEbm5Etj00378enf3SZ9xMgo4?=
 =?us-ascii?Q?WDUDKrFn88a35VZwtsPq6a2ld4UZUsPwKfxcGqqhlIGsFjxM5h1l9M4Vu9QE?=
 =?us-ascii?Q?z/UNGEl01mGdctiM+P4iDrXEhoo6l685SJcy8brv/XyGh/0TEwFAy+eoJ4s/?=
 =?us-ascii?Q?V7tY9pYpBhJ5gjfb97GuLWr9l6bSuGfAciq+2YqBNoxTOd1y1AVcF9sVqnXx?=
 =?us-ascii?Q?N1Yb6PSV+4PoSw7t6qsd10RW66BrNBgn4hkaqYUdYYez+ZtJ96Wh9WawYY0A?=
 =?us-ascii?Q?jsY9QnkQAC+vkO7l9j949eaDpDxAFMX6p3FLeCKPdmo+D+1WiWfk9+55ckdm?=
 =?us-ascii?Q?iLhh5KMY71iYcOvwkQ91LgWW7bYMA3DGaubWdMfpNwSOM5f8+ubpuTRwmgoV?=
 =?us-ascii?Q?zAAK0r4FeDotZ+zFNkdv03RhlfsKp9Ncd2gPOkpAhH9Kqa9f88A/rApJg04e?=
 =?us-ascii?Q?qY8+QcKin+NxR1pwZM2ehxPrtbLyiQcTuDGVni1M5YIonfiqvHvr1dtxUuI1?=
 =?us-ascii?Q?ig6zCWkKAmuUEx8sTOFMJVoxPrgsFhf09yspfW8hViF8+xkss97UfkzM1IEd?=
 =?us-ascii?Q?GjclNbuWqxlFI+yNp+q3XmJp558tmVVNQ/ozsEyN1rGxflG+2cVROpaYK4fH?=
 =?us-ascii?Q?D9vqHMls+cJT1h+xyKOj34J2w8CZMIa/knhJbT/br4NwJi1JhT6L37KLBnmM?=
 =?us-ascii?Q?q32D/HgNz25fuNIAJRpxbeNEl4Utu05P3unprrWiPSDUxhMrjDdqb49wps6b?=
 =?us-ascii?Q?xg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	uJuyHJLYlCkfgubFL7rj5BpVShH0lNs3z8z7JWTkgiFRm88c7x1oihzOi8jUu+JfH2XihIzybgJYw+/mflwBInapyBOceauMqP3D1u0psl6zNXxo6YvmTTCdIJ51wLJc7+M5OcNPrrHFSfGIEhqBUoj0FL/cA71hIj1LtSmvHj69HnI383pDAJrUeW+Guj30H9bjBK0WbeB/ZFiUQrxHytxHz+6do8bvR7nFIKUuYHCvFpks2SWFU4eOvGWXGVwZPOYJqhNREOrKDbN9XWY3ZufEZhBB4N+CH9Pa4NW6b4XvLcRO91nQplV0L5AB6HLKj5tEVMfJ6X2d0r+tLJfSO/feE7lmJQlKWjJhrLJ1WnFXTfJRsYtTFfuuyGFyXWXMObSsqcZV99zjfU9NC6XRo4sLWHK5Ci7oDQhP81IBYwElMPWBoAA/MeGdEkj8CiOLwDncbwkkYBbZ+Vj8Dh4DYY/0EyxLvqndpOsTItbG8cvMYfEvS0vJp8fHBGQRr2uDrr+F32gMJnLkVc8/JVPEBlF34F94Vgmzb8aFYrP8hYOg5WniI6gsYh44ATpaKOQVe8UHICrIXic7omQsbn4P/YHBQ8dADuQ9+xUcGJ/KQ/k=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c81b724-73e6-4a88-6f64-08dc1de7ad9c
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 20:53:26.8413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bWHq8Bw8wICCc0/SGnaepCnlbtrUuNbdKVlmjdSNiz4CMQ/KWMO99DcZyj6gK8Zo88qFk4dtelMtlrTvRlZlsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4298
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-25_13,2024-01-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 bulkscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401250151
X-Proofpoint-ORIG-GUID: vMGHo4i-9HjfG8bSw9_uVXJy0-TAdZJ6
X-Proofpoint-GUID: vMGHo4i-9HjfG8bSw9_uVXJy0-TAdZJ6

On Thu, Jan 25, 2024 at 02:53:15PM -0500, Josef Bacik wrote:
> We want to be able to have our rpc stats handled in a per network
> namespace manner, so add an option to rpc_create_args to specify a
> different rpc_stats struct instead of using the one on the rpc_program.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
>  fs/nfs/client.c             | 2 +-
>  include/linux/sunrpc/clnt.h | 1 +
>  net/sunrpc/clnt.c           | 2 +-
>  3 files changed, 3 insertions(+), 2 deletions(-)

I know it isn't obvious to an outside observer, but the
maintainership of the NFS server and client are separate.

NFS client patches go To: Trond and Anna, Cc: linux-nfs

NFS server patches go To: Jeff and Chuck, Cc: linux-nfs

and you can Cc: server patches on the reviewers listed in
MAINTAINERS too if you like.


> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index 44eca51b2808..590be14f182f 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -73,7 +73,7 @@ const struct rpc_program nfs_program = {
>  	.number			= NFS_PROGRAM,
>  	.nrvers			= ARRAY_SIZE(nfs_version),
>  	.version		= nfs_version,
> -	.stats			= &nfs_rpcstat,
> +	.stats                  = &nfs_rpcstat,
>  	.pipe_dir_name		= NFS_PIPE_DIRNAME,
>  };
>  
> diff --git a/include/linux/sunrpc/clnt.h b/include/linux/sunrpc/clnt.h
> index 5e9d1469c6fa..5321585c778f 100644
> --- a/include/linux/sunrpc/clnt.h
> +++ b/include/linux/sunrpc/clnt.h
> @@ -139,6 +139,7 @@ struct rpc_create_args {
>  	const char		*servername;
>  	const char		*nodename;
>  	const struct rpc_program *program;
> +	struct rpc_stat		*stats;
>  	u32			prognumber;	/* overrides program->number */
>  	u32			version;
>  	rpc_authflavor_t	authflavor;
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index cda0935a68c9..bc8c209fc0c7 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -405,7 +405,7 @@ static struct rpc_clnt * rpc_new_client(const struct rpc_create_args *args,
>  	clnt->cl_maxproc  = version->nrprocs;
>  	clnt->cl_prog     = args->prognumber ? : program->number;
>  	clnt->cl_vers     = version->number;
> -	clnt->cl_stats    = program->stats;
> +	clnt->cl_stats    = args->stats ? : program->stats;
>  	clnt->cl_metrics  = rpc_alloc_iostats(clnt);
>  	rpc_init_pipe_dir_head(&clnt->cl_pipedir_objects);
>  	err = -ENOMEM;
> -- 
> 2.43.0
> 
> 

-- 
Chuck Lever