Received-SPF: pass (google.com: domain of linux-nfs+bounces-1514-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Benjamin Coddington <bcodding@redhat.com>
To: Jorge Mora <jmora1300@gmail.com>
Cc: linux-nfs@vger.kernel.org, trond.myklebust@hammerspace.com,
 anna@kernel.org
Subject: Re: [PATCH] NFSv4.2: fix listxattr maximum XDR buffer size
Date: Sat, 27 Jan 2024 08:01:56 -0500
Message-ID: <2D2732BC-19AD-4010-9CB9-DA4C3BBBC31C@redhat.com>
In-Reply-To: <CAG7w-ioC8VkBFWqcaCw1S7YM-riNQKNUeu2-oUB4CpaimzB=7g@mail.gmail.com>
References: <20240125145128.12945-1-mora@netapp.com>
 <FE38CC90-A3BE-40CF-9365-557CA706376E@redhat.com>
 <CAG7w-ioC8VkBFWqcaCw1S7YM-riNQKNUeu2-oUB4CpaimzB=7g@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On 26 Jan 2024, at 15:37, Jorge Mora wrote:

> Thanks Ben,
>
> Do you want me to resubmit the patch using XDR_QUALEN? Something like this?
>
>  static inline u32 nfs42_listxattr_xdrsize(u32 buflen)
>  {
> -       return ((buflen / (XATTR_USER_PREFIX_LEN + 2)) * 8) + 4;
> +       u32 size = 8 * buflen / (XATTR_USER_PREFIX_LEN + 2) + 4;
> +
> +       return XDR_QUADLEN(size) << 2;

I just thought I'd mention it since it's used all over.  I think your
version is just fine.

Ben