Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp356569rdb; Mon, 29 Jan 2024 04:38:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9LEEfAtlq4cboYvYKqLLTcPyvwSChjUpyA3cOvgVoUyJXMRQQA0X+2BgrnT3OGTw3PqYE X-Received: by 2002:a05:6808:124d:b0:3bd:a811:26ca with SMTP id o13-20020a056808124d00b003bda81126camr6202845oiv.11.1706531913857; Mon, 29 Jan 2024 04:38:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706531913; cv=pass; d=google.com; s=arc-20160816; b=oJUWHX9ku08HxNbYAW2lkyVH2MJYVZnKetbE39THQ6finr4Y+ALeFz2p0eFuPGowBo Vql/R98tuw94OsKCgqeZaycI0TL0DB9Z5IQwPtPaOE4h7z4WGy3lkN4cD6PHVllF6DTq 2WGAusVKw+/TNtVKoVAf2fBl8sMADj+D9Wrf57mE4aWK70Ltx+mFwOsZuQY+Gu2Em1JJ a6tumB3hOWn9XKvHp2Thi5TI1Qh1xWb0GVSD3241Ph7kof6jvT4T5ymA7F7GpdEcSZJ8 FxzWtr9oWQewb8kuAlB+dLGAODzeKWKZPFK2EoKehVoMp+UcpJUjY1qIM7Tc7s89rbQU WhOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=Wn2jciI0olXcJZIAD7GEEd0Ivpuy4edsZV8ZIIHZMQI=; fh=uI1U6Y87+GiyEtBGkRkfQN3UyvcDClIKN6IyjML0j8g=; b=uC22e8VEL2MHaxt8Bpt8zpw6FLJJwGt1jUxtL6pldf1s4NEcnEIoYgAnAmmud8y/p9 d4gx74R9cxGmgTYCu4ZqMoolmZNO1If2WYgBhG4li6KX0kElbKLp9pzdJFvvjtC6Ce/7 WdsbzaXtJ0ldyXFj1CFjwBKzb4Iq3zsyaa8GUub4CS90X9bd+pyxOcnr79xR/lv4Sc+x XSH8KAm9qpWAgP7ZYc5LtpXsRaIQ2YmLIR6y4SNk2nBuxJ+c7TUfgeleA/voyEGZnBju fBJQ3rn0PzA++xQTxQAHTvBPwpO+fAGsp8j/oN3OEF7V1PqPa8xOAXO0Pp38PVkAy8+N 8WNw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RmjMTz79; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-1544-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1544-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id c22-20020aa78816000000b006ddc403e5b1si5522112pfo.272.2024.01.29.04.38.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 04:38:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-1544-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RmjMTz79; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-1544-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1544-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8B8A7B21221 for ; Mon, 29 Jan 2024 12:38:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1565B60EE9; Mon, 29 Jan 2024 12:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RmjMTz79" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E560A60DE4 for ; Mon, 29 Jan 2024 12:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706531908; cv=none; b=arVJ2ERmetvGcIdwE72nLqz4N1F3QqgguhBrQB2F1I8MmftCrtwolXXGsHGWTYEbyEPNQBWmvcoKk53vZIozxAVx0HFl4z4u6stUEGXjkWtF2Tfqbe8SJjVVbaW/oFoEZByaPDsH3I9sWwPBQ9A4wGTbK4BDwwFsndDnSej1sWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706531908; c=relaxed/simple; bh=C7rxMSHSFzXV6qPvAoS2jk8vZle+wdVs4JczbbueuFA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=k6z1FhLPUmGpx+Wv2BDks0EYKgADYsDidL9b8aknKA8ZY0DSeyB8WkYSfS42QfhMX9zo2yIwkTRbRWxbuzf/wWXXhLy2Il1VZ94oj6YJJljICD6N4KLMHjjy2+ZMeRd+OAHkGS1Fcy+6bxsZ7ixWRtyw8mfWFyW+WRLd7Xt7SH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RmjMTz79; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA894C433C7; Mon, 29 Jan 2024 12:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706531907; bh=C7rxMSHSFzXV6qPvAoS2jk8vZle+wdVs4JczbbueuFA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=RmjMTz79Jw0wg6Y0MtQcI3Gk5G2FvOaoreeykG+XoEmrLalAnF68M01f8PIspIiV5 n52CqU9zGdRY1GR6MJruXaHxb1eiQZYSd3RyVamfAJ1IehCjZs9/nS45/+eMsgLK8X FmePeLVEVQ/WKRbrjBZzopYkqy3VctvtHKCC/q3cFIrMwf8gF3igCwWj1/H51+I6Dr 6b991MIImkUymLVfbxeQtiT6ZoMV+T2fVDTWe3ALvOmNynWs0uDvh0HmW+J0Qo21fb vrYPhMuK1D78XG2GwljWJFXpsNeH146uwwVk092G/3zr5Kmpy++FowBX4Rm/T7OnT2 RfB3CkA84oMNA== Message-ID: <6dcd1c1395a64832b3e587d74c977f928dd06585.camel@kernel.org> Subject: Re: [PATCH 13/13] nfsd: allow layout state to be admin-revoked. From: Jeff Layton To: NeilBrown , Chuck Lever Cc: linux-nfs@vger.kernel.org, Olga Kornievskaia , Dai Ngo , Tom Talpey , Christoph Hellwig , Tom Haynes Date: Mon, 29 Jan 2024 07:38:25 -0500 In-Reply-To: <20240129033637.2133-14-neilb@suse.de> References: <20240129033637.2133-1-neilb@suse.de> <20240129033637.2133-14-neilb@suse.de> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxwn8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1WvegyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqVT2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtVYrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8snVluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQcDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQfCBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sELZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/ r0kmR/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2BrQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRIONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZWf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQOlDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7RjiR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27XiQQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBMYXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9qLqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoac8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3FLpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx 3bri75n1TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y+jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5dHxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBMBAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4hN9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPepnaQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQRERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8EewP8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0XzhaKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyA nLqRgDgR+wTQT6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7hdMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjruymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItuAXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfDFOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbosZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDvqrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51asjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qGIcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbLUO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0 b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSUapy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5ddhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7eflPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7BAKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuac BOTtmOdz4ZN2tdvNgozzuxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9JDfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRDCHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1gYy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVVAaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJOaEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhpf8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+mQZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65ke5Ag0ETpXRPAEQAJkVmzCmF+IEenf9a2nZRXMluJohnfl2wCMmw5qNzyk0f+mYuTwTCpw7BE2H0yXk4ZfAuA+xdj14K0A1Dj52j/fKRuDqoNAhQe0b6ipo85Sz98G+XnmQOMeFVp5G1Z7r/QP/nus3mXvtFsu9lLSjMA0cam2NLDt7vx3l9kUYlQBhyIE7/DkKg+3fdqRg7qJoMHNcODtQY+n3hMyaVpplJ/l0DdQDbRSZi5AzDM3DWZEShhuP6/E2LN4O3xWnZukEiz688d1ppl7vBZO9wBql6Ft9Og74diZrTN6lXGGjEWRvO55h6ijMsLCLNDRAVehPhZvSlPldtUuvhZLAjdWpwmzbRIwgoQcO51aWeKthpcpj8feDdKdlVjvJO9fgFD5kqZ QiErRVPpB7VzA/pYV5Mdy7GMbPjmO0IpoL0tVZ8JvUzUZXB3ErS/dJflvboAAQeLpLCkQjqZiQ/DCmgJCrBJst9Xc7YsKKS379Tc3GU33HNSpaOxs2NwfzoesyjKU+P35czvXWTtj7KVVSj3SgzzFk+gLx8y2Nvt9iESdZ1Ustv8tipDsGcvIZ43MQwqU9YbLg8k4V9ch+Mo8SE+C0jyZYDCE2ZGf3OztvtSYMsTnF6/luzVyej1AFVYjKHORzNoTwdHUeC+9/07GO0bMYTPXYvJ/vxBFm3oniXyhgb5FtABEBAAGJAh8EGAECAAkFAk6V0TwCGwwACgkQAA5oQRlWghXhZRAAyycZ2DDyXh2bMYvI8uHgCbeXfL3QCvcw2XoZTH2l2umPiTzrCsDJhgwZfG9BDyOHaYhPasd5qgrUBtjjUiNKjVM+Cx1DnieR0dZWafnqGv682avPblfi70XXr2juRE/fSZoZkyZhm+nsLuIcXTnzY4D572JGrpRMTpNpGmitBdh1l/9O7Fb64uLOtA5Qj5jcHHOjL0DZpjmFWYKlSAHmURHrE8M0qRryQXvlhoQxlJR4nvQrjOPMsqWD5F9mcRyowOzr8amasLv43w92rD2nHoBK6rbFE/qC7AAjABEsZq8+TQmueN0maIXUQu7TBzejsEbV0i29z+kkrjU2NmK5pcxgAtehVxpZJ14LqmN6E0suTtzjNT1eMoqOPrMSx+6vOCIuvJ/MVYnQgHhjtPPnU86mebTY5Loy9YfJAC2EVpxtcCbx2KiwErTndEyWL+GL53LuScUD7tW8vYbGIp4RlnUgPLbqpgssq2gwYO9m75FGuKuB2+2bCGajqalid5nzeq9v7cYLLRgArJfOIBWZrHy2m0C+pFu9DSuV6SNr2dvMQUv1V58h0FaSOxHVQnJdnoHn13g/CKKvyg2EMrMt/EfcXgvDwQbnG9we4xJiWOIOcsvrWcB6C6lWBDA+In7w7SXnnok kZWuOsJdJQdmwlWC5L5ln9xgfr/4mOY38B0U= Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2024-01-29 at 14:29 +1100, NeilBrown wrote: > When there is layout state on a filesystem that is being "unlocked" that > is now revoked, which involves closing the nfsd_file and releasing the > vfs lease. >=20 > To avoid races, ->ls_file can now be accessed either: > - under ->fi_lock for the state's sc_file or > - under rcu_read_lock() if nfsd_file_get() is used. > To support this, ->fence_client and nfsd4_cb_layout_fail() now take a > second argument being the nfsd_file. >=20 > Signed-off-by: NeilBrown > --- > fs/nfsd/blocklayout.c | 4 ++-- > fs/nfsd/nfs4layouts.c | 43 ++++++++++++++++++++++++++++++++----------- > fs/nfsd/nfs4state.c | 11 +++++++++-- > fs/nfsd/pnfs.h | 8 +++++++- > 4 files changed, 50 insertions(+), 16 deletions(-) >=20 > diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c > index 46fd74d91ea9..3c040c81c77d 100644 > --- a/fs/nfsd/blocklayout.c > +++ b/fs/nfsd/blocklayout.c > @@ -328,10 +328,10 @@ nfsd4_scsi_proc_layoutcommit(struct inode *inode, > } > =20 > static void > -nfsd4_scsi_fence_client(struct nfs4_layout_stateid *ls) > +nfsd4_scsi_fence_client(struct nfs4_layout_stateid *ls, struct nfsd_file= *file) > { > struct nfs4_client *clp =3D ls->ls_stid.sc_client; > - struct block_device *bdev =3D ls->ls_file->nf_file->f_path.mnt->mnt_sb-= >s_bdev; > + struct block_device *bdev =3D file->nf_file->f_path.mnt->mnt_sb->s_bdev= ; > =20 > bdev->bd_disk->fops->pr_ops->pr_preempt(bdev, NFSD_MDS_PR_KEY, > nfsd4_scsi_pr_key(clp), 0, true); > diff --git a/fs/nfsd/nfs4layouts.c b/fs/nfsd/nfs4layouts.c > index 857b822450b4..1cfd61db2472 100644 > --- a/fs/nfsd/nfs4layouts.c > +++ b/fs/nfsd/nfs4layouts.c > @@ -152,6 +152,23 @@ void nfsd4_setup_layout_type(struct svc_export *exp) > #endif > } > =20 > +void nfsd4_close_layout(struct nfs4_layout_stateid *ls) > +{ > + struct nfsd_file *fl; > + > + spin_lock(&ls->ls_stid.sc_file->fi_lock); > + fl =3D ls->ls_file; > + ls->ls_file =3D NULL; > + spin_unlock(&ls->ls_stid.sc_file->fi_lock); > + > + if (fl) { > + if (!nfsd4_layout_ops[ls->ls_layout_type]->disable_recalls) > + vfs_setlease(fl->nf_file, F_UNLCK, NULL, > + (void **)&ls); > + nfsd_file_put(fl); > + } > +} > + > static void > nfsd4_free_layout_stateid(struct nfs4_stid *stid) > { > @@ -169,9 +186,7 @@ nfsd4_free_layout_stateid(struct nfs4_stid *stid) > list_del_init(&ls->ls_perfile); > spin_unlock(&fp->fi_lock); > =20 > - if (!nfsd4_layout_ops[ls->ls_layout_type]->disable_recalls) > - vfs_setlease(ls->ls_file->nf_file, F_UNLCK, NULL, (void **)&ls); > - nfsd_file_put(ls->ls_file); > + nfsd4_close_layout(ls); > =20 > if (ls->ls_recalled) > atomic_dec(&ls->ls_stid.sc_file->fi_lo_recalls); > @@ -605,7 +620,7 @@ nfsd4_return_all_file_layouts(struct nfs4_client *clp= , struct nfs4_file *fp) > } > =20 > static void > -nfsd4_cb_layout_fail(struct nfs4_layout_stateid *ls) > +nfsd4_cb_layout_fail(struct nfs4_layout_stateid *ls, struct nfsd_file *f= ile) > { > struct nfs4_client *clp =3D ls->ls_stid.sc_client; > char addr_str[INET6_ADDRSTRLEN]; > @@ -627,7 +642,7 @@ nfsd4_cb_layout_fail(struct nfs4_layout_stateid *ls) > =20 > argv[0] =3D (char *)nfsd_recall_failed; > argv[1] =3D addr_str; > - argv[2] =3D ls->ls_file->nf_file->f_path.mnt->mnt_sb->s_id; > + argv[2] =3D file->nf_file->f_path.mnt->mnt_sb->s_id; > argv[3] =3D NULL; > =20 > error =3D call_usermodehelper(nfsd_recall_failed, argv, envp, > @@ -657,6 +672,7 @@ nfsd4_cb_layout_done(struct nfsd4_callback *cb, struc= t rpc_task *task) > struct nfsd_net *nn; > ktime_t now, cutoff; > const struct nfsd4_layout_ops *ops; > + struct nfsd_file *fl; > =20 > trace_nfsd_cb_layout_done(&ls->ls_stid.sc_stateid, task); > switch (task->tk_status) { > @@ -688,12 +704,17 @@ nfsd4_cb_layout_done(struct nfsd4_callback *cb, str= uct rpc_task *task) > * Unknown error or non-responding client, we'll need to fence. > */ > trace_nfsd_layout_recall_fail(&ls->ls_stid.sc_stateid); > - > - ops =3D nfsd4_layout_ops[ls->ls_layout_type]; > - if (ops->fence_client) > - ops->fence_client(ls); > - else > - nfsd4_cb_layout_fail(ls); > + rcu_read_lock(); > + fl =3D nfsd_file_get(ls->ls_file); > + rcu_read_unlock(); What is the rcu_read_lock protecting here? AFAICT, you don't need it since you hold a reference to "ls". > + if (fl) { > + ops =3D nfsd4_layout_ops[ls->ls_layout_type]; > + if (ops->fence_client) > + ops->fence_client(ls, fl); > + else > + nfsd4_cb_layout_fail(ls, fl); > + nfsd_file_put(fl); > + } > return 1; > case -NFS4ERR_NOMATCHING_LAYOUT: > trace_nfsd_layout_recall_done(&ls->ls_stid.sc_stateid); > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index e749d5c0e23a..268b47a6f3b6 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -1721,7 +1721,7 @@ void nfsd4_revoke_states(struct net *net, struct su= per_block *sb) > unsigned int idhashval; > unsigned int sc_types; > =20 > - sc_types =3D SC_TYPE_OPEN | SC_TYPE_LOCK | SC_TYPE_DELEG; > + sc_types =3D SC_TYPE_OPEN | SC_TYPE_LOCK | SC_TYPE_DELEG | SC_TYPE_LAYO= UT; > =20 > spin_lock(&nn->client_lock); > for (idhashval =3D 0; idhashval < CLIENT_HASH_MASK; idhashval++) { > @@ -1734,6 +1734,7 @@ void nfsd4_revoke_states(struct net *net, struct su= per_block *sb) > if (stid) { > struct nfs4_ol_stateid *stp; > struct nfs4_delegation *dp; > + struct nfs4_layout_stateid *ls; > =20 > spin_unlock(&nn->client_lock); > switch (stid->sc_type) { > @@ -1789,6 +1790,10 @@ void nfsd4_revoke_states(struct net *net, struct s= uper_block *sb) > if (dp) > revoke_delegation(dp); > break; > + case SC_TYPE_LAYOUT: > + ls =3D layoutstateid(stid); > + nfsd4_close_layout(ls); > + break; > } > nfs4_put_stid(stid); > spin_lock(&nn->client_lock); > @@ -2868,7 +2873,6 @@ static int nfs4_show_layout(struct seq_file *s, str= uct nfs4_stid *st) > struct nfsd_file *file; > =20 > ls =3D container_of(st, struct nfs4_layout_stateid, ls_stid); > - file =3D ls->ls_file; > =20 > seq_puts(s, "- "); > nfs4_show_stateid(s, &st->sc_stateid); > @@ -2876,12 +2880,15 @@ static int nfs4_show_layout(struct seq_file *s, s= truct nfs4_stid *st) > =20 > /* XXX: What else would be useful? */ > =20 > + spin_lock(&ls->ls_stid.sc_file->fi_lock); > + file =3D ls->ls_file; > if (file) { > seq_puts(s, ", "); > nfs4_show_superblock(s, file); > seq_puts(s, ", "); > nfs4_show_fname(s, file); > } > + spin_unlock(&ls->ls_stid.sc_file->fi_lock); > if (st->sc_status & SC_STATUS_ADMIN_REVOKED) > seq_puts(s, ", admin-revoked"); > seq_puts(s, " }\n"); > diff --git a/fs/nfsd/pnfs.h b/fs/nfsd/pnfs.h > index de1e0dfed06a..925817f66917 100644 > --- a/fs/nfsd/pnfs.h > +++ b/fs/nfsd/pnfs.h > @@ -37,7 +37,8 @@ struct nfsd4_layout_ops { > __be32 (*proc_layoutcommit)(struct inode *inode, > struct nfsd4_layoutcommit *lcp); > =20 > - void (*fence_client)(struct nfs4_layout_stateid *ls); > + void (*fence_client)(struct nfs4_layout_stateid *ls, > + struct nfsd_file *file); > }; > =20 > extern const struct nfsd4_layout_ops *nfsd4_layout_ops[]; > @@ -72,11 +73,13 @@ void nfsd4_setup_layout_type(struct svc_export *exp); > void nfsd4_return_all_client_layouts(struct nfs4_client *); > void nfsd4_return_all_file_layouts(struct nfs4_client *clp, > struct nfs4_file *fp); > +void nfsd4_close_layout(struct nfs4_layout_stateid *ls); > int nfsd4_init_pnfs(void); > void nfsd4_exit_pnfs(void); > #else > struct nfs4_client; > struct nfs4_file; > +struct nfs4_layout_stateid; > =20 > static inline void nfsd4_setup_layout_type(struct svc_export *exp) > { > @@ -89,6 +92,9 @@ static inline void nfsd4_return_all_file_layouts(struct= nfs4_client *clp, > struct nfs4_file *fp) > { > } > +static inline void nfsd4_close_layout(struct nfs4_layout_stateid *ls) > +{ > +} > static inline void nfsd4_exit_pnfs(void) > { > } --=20 Jeff Layton