Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp510901rdb; Mon, 29 Jan 2024 08:59:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYE+RFFNl9YIyC10dmXCJNijZuUIdBvPhf9Kror/AZqWJ/2pB8JLqDLFLmNOW1Od9u3bzG X-Received: by 2002:a05:622a:174a:b0:42a:a5eb:c202 with SMTP id l10-20020a05622a174a00b0042aa5ebc202mr2927311qtk.99.1706547598079; Mon, 29 Jan 2024 08:59:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706547598; cv=pass; d=google.com; s=arc-20160816; b=Ku8QDv7vAl+iurfSBdIyQ2x1KrA6oBM7goF9j6L77LTZcFo4WwrDqjVJhwOt9KRwPi dLemKoj4qxhrUdMphKeYZuroO+aJKRw9yPnUEHIjW6cBqf2jy9ML2pd/qO80Dr9jjs6G s96foKJZL3p1Ce9LoXgl4+6EEgG+udUq2VOPeSbeZJeDHucWRXnKQCT25UWWIIQoMLsP vOpASLL7wNCrQtUaFX+/3+VoL4VA8UZo0mNBALoX3i8zsLjWnYBnGy+aCGQcBVowh4OT MqWzJPIv3v/a92i67fiIBlhr3SXLCo64cOke5WyydiRhlFCFsos9OuBev3kndF5ZFI59 T72Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=qQDUUKvTK8zOkwQ8G6lXq76uar0XYKdo4f+/T4ifrR0=; fh=LUvrxPTGJY/xMM9Z3S9jsK/DYE1UJ/WWSWB1eeNIxnk=; b=Fl4zR+5+fHL7mcufIFX83wqLpR2r9jU/SkyrTecrHo4nUOzKTxKX5U2htEUIc40nZQ jLeKuDblF8jD6sKfTpRePZ7u0GNI6TFi+hGBWIa3qyLp0QsXwasOecnhmAeAljD3fP8q FO5D6XPHobyHFS8ANFbJ9kTC7gGFFWbWjQJ6qvgXOcwXDibs6GxPCiXdLzxTITklCxDd 2Oz4l09957A/H2IGnGHy9iZrf9d2rIH+y1DXWKjGzTsVU13d9/K28QXUhR86qx3zLhfn ceHWQuOIBZjRiCihoVUaSFSIzOmCVv0J3MCPvF77czFr0V+RpyjsuRwpsxI8sI4qYyXh H6Lg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QT8QTCti; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-nfs+bounces-1570-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1570-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id t14-20020a05622a01ce00b0042a7e98a003si5097170qtw.376.2024.01.29.08.59.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 08:59:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-1570-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QT8QTCti; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-nfs+bounces-1570-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1570-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D077C1C23949 for ; Mon, 29 Jan 2024 16:59:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 081B015699F; Mon, 29 Jan 2024 16:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QT8QTCti" X-Original-To: linux-nfs@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 547ED157028 for ; Mon, 29 Jan 2024 16:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706547588; cv=none; b=G04bsyOfCe18l28K89tIf7ZE/SxfWU85hWdH/L7d7/jQBSMjbvnW2Ng9iQjJTcwU9CTabZeg9gca2o2PFaVRRIoTxNdO/xkYLYHGIjjUb9f6pVtmiIt9ozJjA5U386hekvovZXhQQic+8XFsJ3zqZVcZgcHY8eobqIuLwqBmXno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706547588; c=relaxed/simple; bh=HNdAx47dFFQ/G2/0oVGCNwabyUK7Ga4m+kOyhpAmjvQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Sv8Dw2kZgu7zZnfNm/3tyw2EttoWwVZ0ZzrcXmEGj8QNEwIgLU1V90IBZt+vlz69uyKilfI1AYJqBxn9fMz3YhdpnQocrYm33O/MBiWhPcvf5+kZcQh8gkRKV0f6YxhDm8qmwZNSWt2LrHqCLWHHP9u1awwcVj8pqzWVJwtz90o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QT8QTCti; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706547586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qQDUUKvTK8zOkwQ8G6lXq76uar0XYKdo4f+/T4ifrR0=; b=QT8QTCtiyBgntJZ2KoMWFWfrrnoyHUJERdd+rCT4Ub+A9mMIJSMndsL/HagY8ieeMb6Giz EU1jY9JX+3aRn3cKQdkxj7B8Rkx92Th0u43gewE6KALwW41PXADUaxfYpyUGk0mYG6lcNS r46pcte+QQNYvkR7na/1OH3ZaKD2swo= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-uhan2oCONqqTFR7Jor7SVQ-1; Mon, 29 Jan 2024 11:59:43 -0500 X-MC-Unique: uhan2oCONqqTFR7Jor7SVQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 10B7628B72E2; Mon, 29 Jan 2024 16:59:42 +0000 (UTC) Received: from [192.168.37.1] (ovpn-0-9.rdu2.redhat.com [10.22.0.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 48F531121306; Mon, 29 Jan 2024 16:59:39 +0000 (UTC) From: Benjamin Coddington To: Chuck Lever III Cc: Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Anna Schumaker , Linux NFS Mailing List , "open list:NETWORKING [GENERAL]" , linux-kernel@vger.kernel.org, Alexander Aring Subject: Re: [PATCH] sunrpc: fix assignment of to_retries in svc_process_bc Date: Mon, 29 Jan 2024 11:59:37 -0500 Message-ID: <54456569-284D-4294-BD75-6AD3F68BB5A8@redhat.com> In-Reply-To: References: <20240129-nfsd-fixes-v1-1-49a3a45bd750@kernel.org> <7E6930D1-14BC-4CBC-9833-531BF6F5D874@redhat.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 On 29 Jan 2024, at 11:55, Chuck Lever III wrote: >> On Jan 29, 2024, at 11:52=E2=80=AFAM, Benjamin Coddington wrote: >> >> On 29 Jan 2024, at 11:43, Jeff Layton wrote: >> >>> Alex reported seeing this: >>> >>> [ 18.238266] ------------[ cut here ]------------ >>> ... >> >> This one got fixed already, just waiting for a maintainer to send it a= long: >> >> https://lore.kernel.org/linux-nfs/20240123053509.3592653-1-samasth.nor= way.ananda@oracle.com/ > > Ah. That touches net/sunrpc/svc.c, but it was sent to the client mainta= iners. > > Do you want me to take it through the nfsd tree? Oh yeah if you like, not sure how you want to sort it between the because= even though its in svc.c, its a client fix; this code is specific for the= client's backchannel. Note the version on this thread misses the 2nd typo. Ben