Received-SPF: pass (google.com: domain of linux-nfs+bounces-1573-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20240129154750.1245317-1-dwysocha@redhat.com>
References: <20240129154750.1245317-1-dwysocha@redhat.com>
To: Dave Wysochanski <dwysocha@redhat.com>
Cc: dhowells@redhat.com, Anna Schumaker <anna.schumaker@netapp.com>,
    Trond Myklebust <trond.myklebust@hammerspace.com>,
    Jeff Layton <jlayton@kernel.org>, linux-nfs@vger.kernel.org,
    linux-cachefs@redhat.com
Subject: Re: [PATCH] NFS: Fix nfs_netfs_issue_read() xarray locking for writeback interrupt
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1526806.1706548521.1@warthog.procyon.org.uk>
Date: Mon, 29 Jan 2024 17:15:21 +0000
Message-ID: <1526807.1706548521@warthog.procyon.org.uk>

Dave Wysochanski <dwysocha@redhat.com> wrote:

> -	xas_lock(&xas);
> +	xas_lock_irqsave(&xas, flags);
>  	xas_for_each(&xas, page, last) {

You probably want to use RCU, not xas_lock().  The pages are locked and so
cannot be evicted from the xarray.

David