Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2689879rdb; Mon, 12 Feb 2024 13:06:38 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXyu60mKCLRYxsHbEzo8895EvQACMFlBSAx4jq8ARUqVST6lhjItHItX9SFuZkH81fm3xC+KGOgJAwJyN2CmuWQTubLeK53yiZTgsRKHQ== X-Google-Smtp-Source: AGHT+IFTmudPFx4HxAGTFPxCTdj4OljyS570HdN22Vx86edPAGZu1eeItItQts/NV1U5SP5U3wBN X-Received: by 2002:a05:620a:24d6:b0:785:3887:de32 with SMTP id m22-20020a05620a24d600b007853887de32mr11321295qkn.20.1707771998111; Mon, 12 Feb 2024 13:06:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707771998; cv=pass; d=google.com; s=arc-20160816; b=ktAlbetpW/QsShdMY/gV/O40WoKP4dPA8wFJm/jRw7dxkCSO+0KOFKMIGWd19+nQj6 a6+xzTAbhwkIA/Hcn8tvUN/OIM0D/NpqRq547dV5vStRCxwLRY6wj8w+Z3sTYYdzxYDC nDZFYBTObcZsI1u/mPZDWIG9Kt5ed2XOBhmlBed2aKNvzM0O8Hd9/U0D98lMltdS2JTk DqlrlYJmDnRAqx139HDrLH6KznbnFOUtaoeNKR5lNbKhaKUzvFQe3YSOjfj/riTZZM+O MH+EF0e7Gaz71SiECu+IBUFVu79jciIo/UNmxdqVrxHMyjyC6R/j4OjpLjR+iPShUM45 Q80w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:date:cc:to :from:subject:message-id:dkim-signature; bh=hyjD0aJ8LyZ5qPFArghXLMKuTGD3SIZmoUaIuuQVY9Y=; fh=5a0QAJmS/8H/bgqw64vb9/wlp0k1KErTXm8jKRgBGuc=; b=jMinQpx/V3TEoay4GAXHTQ6hIlfhQqqJEIR85KNI15V2rfIftEKyoGin+qITn9+BFo NZEvJFPW2DzGPK4ZdO9moRG6SuUljYn2Y85qro9I0hIIqU3qvqBq2qaCCTBdritQEAe8 O91k3S0VbiWEQqe1tIOTOFtqF3DylxNnGlcOEblAcBqWyQD0oNnc7S325WOO5AeWrMBO u9JR4k8yOVvD185Ii6O3m3u6Z48pGZadrwZuZKLcIuc6vw6zy1iFNC7ISzOTlH7OPH7G eA26AbY0qVdMu94DwYgs1YXVgeXsxUoYvRTXPuXRECL2kYnR8zaSno4CPA7hTyh7WQDe irJA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Fnn3m8Qp; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-nfs+bounces-1904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1904-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com X-Forwarded-Encrypted: i=2; AJvYcCWzqzMlpfIfQ0SqJ1bvyNIhT9kkHCUw2o+6DiU9vLyOMsXoXEL2urpzisxsF9uei+KliM6ZIceTI5uxDP7xzBGLVBvVm8mHqHvbyhDZCw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id g5-20020a05620a40c500b00783e5c0ae73si7743306qko.180.2024.02.12.13.06.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 13:06:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-1904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Fnn3m8Qp; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-nfs+bounces-1904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-1904-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D22EE1C21E97 for ; Mon, 12 Feb 2024 21:06:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1E984B5A6; Mon, 12 Feb 2024 21:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Fnn3m8Qp" X-Original-To: linux-nfs@vger.kernel.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9763B4BAA6; Mon, 12 Feb 2024 21:06:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707771994; cv=none; b=AdkmaG4Y3EcIeuXOdlty2Bti5IpvNkRt0gIF4c2AQZfbgRCwJENu5iMx+irJZOe331O5mQrOLbenpkEwpc7//BwShejaaA/lXtbrBOmrSBOKcH2C8etaoNN4KezxgMTHRV81rroIzlFZSj7rQMohZviliN7BACgS24adIm7rUr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707771994; c=relaxed/simple; bh=WOCaTXiHT/gTBKz8I905kYg3HZ4wKewbyQbmdauMPR8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:Mime-Version; b=k+uDoxtIvLomulUUUoTj21svYeudqWgku6nS99ZXDHlnOYPOIKn5Uc/0QdraIWnEZwnGpzmXbEkYcR1tZZocGeOnIQHFgFiwAx8w5Z+sO8PIXSEThJo91rB0h17eX82VBO7VhDxKMRmFdI/oYT9uB/vNYEswTjT56mDVIW2CBOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Fnn3m8Qp; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41CL2bq3016465; Mon, 12 Feb 2024 21:05:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=hyjD0aJ8LyZ5qPFArghXLMKuTGD3SIZmoUaIuuQVY9Y=; b=Fnn3m8QpmWYfZumwDcGlFwlCTkbm3uOga+Y0pr/VZ1wIMh+axHs0qNanh5jDtTH/60hm 323acb9ir0gM8WKwFDZUS3mUKb9gWf7tMJJykMIYh/yBDV9bNWX0aLABX0OfVpX6ClMR /XUHD/McWWyHWXsDsU/k2BQw37x3U/NCOMFTmgVvNOaPS4TptgBsZPc7wAxGmTsYXa/P JUedqpZf8rimyuDdnnladbQ7br+s9saqc0zSIsnJd7TMsQ1rw1Mi/y68EI2lFlkF9UJY cEeb/FVJ9EstukwOvscPc1vLBwoOXsdKo3StYCDpbl2D5KOxAVFIJ2vrtmk90dg8Jlo8 dg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w7tw9g47v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Feb 2024 21:05:57 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 41CL3iEC019822; Mon, 12 Feb 2024 21:05:56 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w7tw9g470-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Feb 2024 21:05:56 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41CJGmgo024878; Mon, 12 Feb 2024 21:00:55 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3w6mfp34p1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Feb 2024 21:00:55 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41CL0qYl28181202 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Feb 2024 21:00:54 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6524358076; Mon, 12 Feb 2024 21:00:52 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB5725805C; Mon, 12 Feb 2024 21:00:50 +0000 (GMT) Received: from li-5cd3c5cc-21f9-11b2-a85c-a4381f30c2f3.ibm.com (unknown [9.61.73.237]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 12 Feb 2024 21:00:50 +0000 (GMT) Message-ID: <305cd1291a73d788c497fe8f78b574d771b8ba41.camel@linux.ibm.com> Subject: Re: [PATCH v9 12/25] security: Introduce file_post_open hook From: Mimi Zohar To: Roberto Sassu , viro@zeniv.linux.org.uk, brauner@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, dhowells@redhat.com, jarkko@kernel.org, stephen.smalley.work@gmail.com, eparis@parisplace.org, casey@schaufler-ca.com, shuah@kernel.org, mic@digikod.net Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, Roberto Sassu , Stefan Berger Date: Mon, 12 Feb 2024 16:00:50 -0500 In-Reply-To: <20240115181809.885385-13-roberto.sassu@huaweicloud.com> References: <20240115181809.885385-1-roberto.sassu@huaweicloud.com> <20240115181809.885385-13-roberto.sassu@huaweicloud.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: fwTq-ORuY4eUEMDSmtEUx3WTaqBFlsH8 X-Proofpoint-ORIG-GUID: ixco56Pb_Pr-9e5H6t8K6WSdAPs_nZUT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-12_16,2024-02-12_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 bulkscore=0 clxscore=1011 spamscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402120163 Hi Roberto, > diff --git a/security/security.c b/security/security.c > index d9d2636104db..f3d92bffd02f 100644 > --- a/security/security.c > +++ b/security/security.c > @@ -2972,6 +2972,23 @@ int security_file_open(struct file *file) > return fsnotify_perm(file, MAY_OPEN); <=== Conflict Replace with "return fsnotify_open_perm(file);" > } > The patch set doesn't apply cleaning to 6.8-rcX without this change. Unless there are other issues, I can make the change. thanks, Mimi