Received-SPF: pass (google.com: domain of linux-nfs+bounces-1991-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 16 Feb 2024 08:36:43 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: jlayton@kernel.org, linux-nfs@vger.kernel.org
Subject: Re: PATCH [v3 0/2] NFSD: use CB_GETATTR to handle GETATTR conflict
 with write delegation
Message-ID: <Zc9k61io6bzOxPqQ@tissot.1015granger.net>
References: <1708034722-15329-1-git-send-email-dai.ngo@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1708034722-15329-1-git-send-email-dai.ngo@oracle.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?pIwQO22SLGjxSsx+SfwZXifFSoOBH/URGYXFeAW9xQQlXU6AbDlLvYbX89Ox?=
 =?us-ascii?Q?Hm3TQCh8xdxe8dDuYfRUkMmOsk6nDxY1s5vcl2jKoSxXkmbtG8BHPKFpUmpL?=
 =?us-ascii?Q?WNiM+tOiJXVdI+jN2CzocRDooFwkfJhkutt1G8kjtV5BGTDDy4qMkdVZlyou?=
 =?us-ascii?Q?1VRJg5+TfISfZmaSbl6yShYPRv1ypHIrrJLabS0PP5QdyrUAp1l3BMzjjBCa?=
 =?us-ascii?Q?AzY2rViRUqXcz5sRhMaUU6eaGp5epv9mLtGG6GK/PPQMSbPNCPqs8iNJWyA1?=
 =?us-ascii?Q?5f/6Bu5WOOQfLzfSTFpRGVpi2T0eiyG7CUuqCXOGVRsiUniCZkJUOPClvPAh?=
 =?us-ascii?Q?iBI+TeB0IIYgHbn4JPU74puIc3I64PloGXgKcRjdKlvFiEncD8XUvMHoMHd8?=
 =?us-ascii?Q?Vios1eKbDI8YRSGTlZ44zhIXN6vPreyhVchmuIQALgiUxi3DA9+32qF2mrR2?=
 =?us-ascii?Q?UZbBdGByiuBs7qqQLsMVQ8aaoqMP2Jw2krt3LRP3ijvbVPp726Z5JH8r/A4I?=
 =?us-ascii?Q?ufzdHQVX85QxPgPjjJ68eLUqI+mui4trpLcGj0Hd3pvz2002WRBAVHw/QXXJ?=
 =?us-ascii?Q?UGr/CnL6fjYSIA9ItQ/sHlA0SzIeYIKWujC+tZuv4iEofMz/fmm0WzJV7Na2?=
 =?us-ascii?Q?iQDeRHOdoWcJ4+NwqS+lRd3S6b6HfuGk6DLlIuP8kEScuSqu8qPCesgvlWL7?=
 =?us-ascii?Q?cly8IhiWtQkXQuU8cJnR3tnXrfN/R8za+9JoTjhP22Sm9Mb7g9WTOveSfvPY?=
 =?us-ascii?Q?U5wJC5RNsAXXK1t/2bv5DqItW/mDWSV/LSV5q0TfdTIKKLreSclDt7ElZi4R?=
 =?us-ascii?Q?6uRtmWfCjEpwuDFirNqwKpOav5KIGeK1nY5nEo+D/+Updqc5HFejdtijkokC?=
 =?us-ascii?Q?dwau1PpATxC73NIGyMmZy91fBIYUy/9ORgjIO6o0fgKdgdw5WwNPNMKHlFQo?=
 =?us-ascii?Q?QnebMqbnLvFcTaeYDZ1/X30kJYKChI5jOqCRI0fcfxiBtbKUMqZX3S/m2u4O?=
 =?us-ascii?Q?QFL78mAKgt7G8UTlcaHY29UWjoURCNSC7VL2beYS3PkKTvAydNQ99Sxi8ts9?=
 =?us-ascii?Q?SUOCdkOtur0OHJrciAjylF0RtsN3sHPt62yG6Xxslw3t5RW2YRacszkPgSEi?=
 =?us-ascii?Q?Rj4xDVrGanzt/KRpwj/B3Uh8KJqLa8zsw9OyykikEh5RTJyGX8qCOdlW9xhw?=
 =?us-ascii?Q?GH6mNAOH4D8vz70R+VHldDqW6N8ncOjQralcc4TjSBggKYo6r2SYljgLIib9?=
 =?us-ascii?Q?BXx5oRjx9qs6HsbFCn3A7LFKnpxe3HI+FdeGtkWZ00/XvIhLwuY2+sf0Yhd7?=
 =?us-ascii?Q?dBlI4dZ8Q3jIBqd9UX633G24p9rg2MVnnhDbjtMxKqjwEsq1kkVrFMMb3f2N?=
 =?us-ascii?Q?+s/pwoFKt9DudyxDVtURLoHYc3EHgDOVpl62CNr2dpgw+LRCGDY6VCVw+0CT?=
 =?us-ascii?Q?q/Qbn9iMAqKEd3x1LEXsoiBqAPHKOLL9u+hj7zkTBXoqs143wKeNwq0kVv/m?=
 =?us-ascii?Q?vZRwPPMtmM0HLOU3azK8FdSPCMtbcwlXjeXlMakqry/32uriD3q7KLzsX0zC?=
 =?us-ascii?Q?kQXX59EyerESLHCzdsfrZ96S96xdbdJtmjDRbxnb1148+c7+6YOypMzZKf6C?=
 =?us-ascii?Q?wA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	0YvffH9ahkPIgqULBIg/lDC1GxBWSTXbA4yala7esQAzfM9Ibkn3OkmeygAlkY/zpoq7pgKk2YX4ULT/Uu+dURWEHiAaxM6mRsptWXREwWXN8/8sst2iPWas1p228zVmI5dGC5ar7SH4JzThIFKOy+3nTuQLDese5nSlvdHd2zMHhQvCOllYoYmUNkmkDHonSdOHVrN8Kx8mG/7QkqbghjjiI0tLvr5OXeXF1s1xWSuPxtKRFRBBJOUssbPPUn9QUIozkqU1sjJ02PF0RQGk+YlEp7GZJ6oZ44vlGZ6sBqAvu9jg5JpyIx5Njx7mCZw5OZlUpwO+TyrPEFMEgio8jcQIyCf3Ng8wIByC5nefpaRnP5onuiyVC+QNlJMcjfcavL4jsCtVG47AudnzbYXnL8hNGQyarNjuqyaF4UZwO1x5ok5lLucyBWIwHYwkIkE9V58SmW61ehOvRckUHsd/x7RmrNQgeEqUW1aq9L7MFk3APjcW63FwPQNMnTLwRH1PQlU8cq11/7/RhLeAClbNd0gosYsB4OQ5bIJSQ2xt5PbKIcvzqg6txg8kQCqYv5jyL5DUWNckVexatchfZfVvhDFfTsAsGXLxX9UI/2PJjdQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dcc92aaa-32ba-405d-dbbd-08dc2ef45216
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 13:36:46.5024
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8b3kw7pkWF5LuWXInpbbIa+7+0WnM4qJSqiDvb2ve8yldfgSxe56hp2P+aEKrd9OHGn4qfua56dhpydMdorSDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4348
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-16_11,2024-02-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=992 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402160109
X-Proofpoint-GUID: Gry6V851AnLlOj2NQViyVCR5DMDA8CjM
X-Proofpoint-ORIG-GUID: Gry6V851AnLlOj2NQViyVCR5DMDA8CjM

On Thu, Feb 15, 2024 at 02:05:20PM -0800, Dai Ngo wrote:
> Currently GETATTR conflict with a write delegation is handled by
> recalling the delegation before replying to the GETATTR.
> 
> This patch series add supports for CB_GETATTR callback to get the latest
> change_info and size information of the file from the client that holds
> the delegation to reply to the GETATTR from the second client.
> 
> NOTE: this patch series is mostly the same as the previous patches which
> were backed out when un unrelated problem of NFSD server hang on reboot
> was reported.
> 
> The only difference is the wait_on_bit() in nfsd4_deleg_getattr_conflict was
> replaced with wait_on_bit_timeout() with 30ms timeout to avoid a potential
> DOS attack by exhausting NFSD kernel threads with GETATTR conflicts.
> 
> v2:
>   . update comments in nfsd4_deleg_getattr_conflict
> 
> v3:
>   . rebase with nfsd-next
> 
>  fs/nfsd/nfs4callback.c |  97 ++++++++++++++++++++++++++++++++++++-
>  fs/nfsd/nfs4state.c    | 115 ++++++++++++++++++++++++++++++++++++++++----
>  fs/nfsd/nfs4xdr.c      |  10 +++-
>  fs/nfsd/nfsd.h         |   1 +
>  fs/nfsd/state.h        |  24 ++++++++-
>  fs/nfsd/xdr4cb.h       |  18 +++++++
>  6 files changed, 251 insertions(+), 14 deletions(-)
> 

Applied to nfsd-next. Thanks for your efforts!

-- 
Chuck Lever