Received-SPF: pass (google.com: domain of linux-nfs+bounces-1992-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Aleksandr Burakov <a.burakov@rosalinux.ru>
To: huck Lever <chuck.lever@oracle.com>,
	Jeff Layton <jlayton@kernel.org>
Cc: Aleksandr Burakov <a.burakov@rosalinux.ru>,
	Neil Brown <neilb@suse.de>,
	Olga Kornievskaia <kolga@netapp.com>,
	Dai Ngo <Dai.Ngo@oracle.com>,
	Tom Talpey <tom@talpey.com>,
	linux-nfs@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	lvc-project@linuxtesting.org
Subject: [PATCH] nfsd: fix memory leak in __cld_pipe_inprogress_downcall()
Date: Fri, 16 Feb 2024 16:45:41 +0300
Message-Id: <20240216134541.31577-1-a.burakov@rosalinux.ru>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Dynamic memory, referenced by 'princhash.data' and 'name.data',=20
is allocated by calling function 'memdup_user' and lost=20
at __cld_pipe_inprogress_downcall() function return

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 11a60d159259 ("nfsd: add a "GetVersion" upcall for nfsdcld")
Signed-off-by: Aleksandr Burakov <a.burakov@rosalinux.ru>
---
 fs/nfsd/nfs4recover.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
index 2c060e0b1604..02663484782d 100644
--- a/fs/nfsd/nfs4recover.c
+++ b/fs/nfsd/nfs4recover.c
@@ -850,6 +850,8 @@ __cld_pipe_inprogress_downcall(const struct cld_msg_v=
2 __user *cmsg,
 			kfree(princhash.data);
 			return -EFAULT;
 		}
+		kfree(name.data);
+		kfree(princhash.data);
 		return nn->client_tracking_ops->msglen;
 	}
 	return -EFAULT;
--=20
2.25.1