Received-SPF: pass (google.com: domain of linux-nfs+bounces-2018-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 18 Feb 2024 11:45:23 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Roland Mainz <roland.mainz@nrubsig.org>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: "nfsd: inode locked twice during operation." errors ...
Message-ID: <ZdI0I8YV2Vir8f7g@manet.1015granger.net>
References: <CAKAoaQkeevOpxQPjH+KZt3fyYweLsrY-bhHsqvOpdVXuGYwqXA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKAoaQkeevOpxQPjH+KZt3fyYweLsrY-bhHsqvOpdVXuGYwqXA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Klr2alfgWym2o2fdbPrunsZ3kyDCA0rY6+/oOzlQbCUzKjXageSc3JnfHi9R?=
 =?us-ascii?Q?bKjnIgQgQVsoiz5NylIhOY3Ns+16cYw1CruA37kVPOYlzvL0oE0B5iQA86PM?=
 =?us-ascii?Q?lyppB5CFIw4bb6q2W/aoW/nHYVCCg/psjYlhg7NqhL66XPdwrdwAtGA14aYG?=
 =?us-ascii?Q?MN3NGRdYwaqT4/EhIUwtO5HUBadsuG09HTjg2oKBbfAIKiP/xBLByHLbRUT7?=
 =?us-ascii?Q?dB04SXRs5KfBVLJLxVa20TxUbFs2a++UYLGKrldaVsYRsOqzCSo8ZpnlX2/J?=
 =?us-ascii?Q?gPykNyHqNl5D5kdwQFak5ItfrGTkotiX2Xkg4Fcw59guL2XyVz1rs6B4qn8P?=
 =?us-ascii?Q?Qr9VrSrxcVfPeE+DF1/i/AdAuQ7sUHCEOJ9eThCbLvLQPXUePZw7N7kO6JH2?=
 =?us-ascii?Q?Bf3BQpbB/jaSF7rJnMvtQJnfYZrBJbg098IA+qjKVwz7cCELCMDNPq6KZ0Jl?=
 =?us-ascii?Q?H0bzTMX1pUTfHPAMOhtA8s/tI+tRiBevxQEIKtMcyzPGVz9ml7YAg4ofBwTT?=
 =?us-ascii?Q?98c6PXB1O7GQfr0CHH3YezYzuZzPOgN7l8shAEXQMZRbqA0KdRQy6SO/y5Ji?=
 =?us-ascii?Q?K4h3ToWLxpf+QLnLhOCuhezu2HQNHEsTaaYZ8vd2CrpmaUj69Sjj9txWA6mw?=
 =?us-ascii?Q?xdncOdgkMB9Oi9eoauHHNAxfDAd+ZeJXoJ/naPy+pCF02q0tYZklVEeLui6n?=
 =?us-ascii?Q?+RC6go3NhhGN9N+WmSDUg697i/2rKISAvx41UMLNcEtyfT+W0Fl+oWzh6Pik?=
 =?us-ascii?Q?z2zV170sZPErxZx3sOj1fc80T5usrhBeMHMYdac0Y4QjcMfy4jWwjR+ZjVqM?=
 =?us-ascii?Q?BCL8De9izHBj1YPi0r9S6QRjQntusHf1kM7ZebeIRzkyQUTQTrPC3RhViush?=
 =?us-ascii?Q?aOugSJl7dtKeD9o4lrq+J6XmOztyZz5TP6fsnlfNbgeDmbFqoxcOKd/aRSoT?=
 =?us-ascii?Q?/Si8qyAArgjLsoyEtOTUi2OmIRJMFdIdPEABHRlgZdGvrlGAtb3nsLjmoAsd?=
 =?us-ascii?Q?l+PdgkeWC6NPH1gulWKSHzQEmWOKo3PPqqLcvEJUdD7Paxl2oFu90dw507y7?=
 =?us-ascii?Q?uXuj3onjXlqpsl+rd9Z1bgUBAZd7086LRMXTjIbDxzC3hCeY8Onasll+k7es?=
 =?us-ascii?Q?M5arjZB/PWi2x30owbS3xNY5WF0kICMCGux+D4rXXmEAMNUkQ7+5SRFSWVgW?=
 =?us-ascii?Q?z3+npuG/+J3I7a+LTgOFO4Nqy+GvuEMHlLmQMixm3jhK4C+oY8l87oU/N9wx?=
 =?us-ascii?Q?HKeQUTjIyhuL1SNd9Iny+AVRqQzq50EYjIBKUui6Yp5BVEy1y4aQp6YLtrq4?=
 =?us-ascii?Q?0WCrphAeEMh48LHpKsgDQbzznnLSGTBoNgXJR6VohXMPUdqhzoyN6Vue9ZbS?=
 =?us-ascii?Q?dX4eBxFIUlsDosOl1LHl9TWym7yURVIyJgfSDr+H6q3Bc2JLD80OMsp6gAL5?=
 =?us-ascii?Q?DkgF0S4XfvgtsP9YJmKVGgZahbxWDNMU9idIGpa68KHNCTSg661f7oJwoteP?=
 =?us-ascii?Q?Ss2lYYLbNN0eXPsyTou64kyqckbGS1NLHdnevCPmNIGg2YcMoWzcBmkbcIee?=
 =?us-ascii?Q?otMPAHfMh8I6jlHWb/d4jhLCZv7KGdo1ol5ysX/n4lJ1EevaRpNQYYlYmlJT?=
 =?us-ascii?Q?jQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	UUMQf6y0o/Qml75yw31AfX1ecFiG+i10nd2Oxy5xJJiz6YzhBIf88VAJWwpKR6/x5ok8Rm3QaW+4Q7G8NZBTspfutKXoAETFzWuoRBFlcTswUxuElXchbdu/P4Qjiu/n++3Nr9hbVPUiMn2f6dATAiAu7SFoW8VPmDuaxYEFkqegH22LbZm0b23hk5PKRte71r0NAMIWoXI905ka/CB7hJlF1rlFS9yQGHslwd7AIvjpwEqcnHBIAXIA/hNexjKbgv5sEx+HrBX9hs5YahHkmD2BDG86Mo2is6jg/PXG6FFgaaSR+YraH3NhMwGYFGh8Duidn0qDQLETeXZmlO6wgqY/RLpV31hRzQSGzSvU3ZYTxUdwYusMmyiVc6KenS5hS22AfGQ4ppGD64uCnPggQgSQcy6PdCb+FDAeZ3gfH5tpFk+spneoqOm24+PfA2xvD0aOB6p/Z7JXb/oFbq/VQwhFAO/11h2aQ+1FYNzYe1LMSmHkAtPq/oxqgJ77cNDk2rjFiUWNcTa1zEinG8PxsY4iJLLlLdA2PJK+He0bV/0eusMZb08bFtuBHpSBRRwxCNAF4RTq2xMH0xCfn/hobsr3p7yZfqtC3LBY5GTaHoQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e6f2248-223d-4dea-6a34-08dc30a1053c
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2024 16:45:31.6508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MkuhQseC/AQaS48fuDavFg5hD1w9s5c+aioAi6X5fvqm0u78hgjZ1tAxe4BUpAHuQb5fhHkC8ConcKIGaIVkBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7359
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-18_15,2024-02-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0
 mlxlogscore=999 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402180130
X-Proofpoint-GUID: 5ox0jf1mfvfeCe900n3irGw4AxdKB29T
X-Proofpoint-ORIG-GUID: 5ox0jf1mfvfeCe900n3irGw4AxdKB29T

On Sun, Feb 18, 2024 at 01:00:33PM +0100, Roland Mainz wrote:
> Hi!
> 
> ----
> 
> I'm getting the following errors from nfsd in the kernel log on a regular basis:
> ---- snip ----
> [349278.877256] nfsd: inode locked twice during operation.
> [349279.599457] nfsd: inode locked twice during operation.
> [349280.302697] nfsd: inode locked twice during operation.
> [349280.803115] nfsd: inode locked twice during operation.
> ---- snip ----
> 
> nfsd runs on "Linux 5.10.0-22-rt-686-pae #1 SMP PREEMPT_RT Debian
> 5.10.178-3 (2023-04-22) i686 GNU/Linux", exported filesystem is btrfs
> on a SSD.
> NFSv4.1 client is the Windows ms-nfs41-client (git
> #e67a792c4249600164852cfc470ac0acdb9f043b) compiling gcc under Cygwin
> 3.5.0.
> 
> Is the nfsd issue known, and if "yes" is there a patch ?

I believe that warning message vanishes as a side-effect of this
series of commits:

7fe2a71dda34 NFSD: introduce struct nfsd_attrs
93adc1e391a7 NFSD: set attributes when creating symlinks
d6a97d3f589a NFSD: add security label to struct nfsd_attrs
c0cbe70742f4 NFSD: add posix ACLs to struct nfsd_attrs
927bfc5600cd NFSD: change nfsd_create()/nfsd_symlink() to unlock directory before returning.
b677c0c63a13 NFSD: always drop directory lock in nfsd_unlink()
e18bcb33bc5b NFSD: only call fh_unlock() once in nfsd_link()
19d008b46941 NFSD: reduce locking in nfsd_lookup()
debf16f0c671 NFSD: use explicit lock/unlock for directory ops
bb4d53d66e4b NFSD: use (un)lock_inode instead of fh_(un)lock for file operations
dd8dd403d7b2 NFSD: discard fh_locked flag and fh_lock/fh_unlock

plus this fix:

00801cd92d91 NFSD: fix regression with setting ACLs.

Any upstream Linux kernel after v6.0 should operate without that
warning. I don't see those commits in origin/linux-5.10.y.

-- 
Chuck Lever