Received-SPF: pass (google.com: domain of linux-nfs+bounces-2019-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sun, 18 Feb 2024 21:06:09 +0300
From: Fedor Pchelkin <pchelkin@ispras.ru>
To: Aleksandr Burakov <a.burakov@rosalinux.ru>
Cc: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>, 
	linux-nfs@vger.kernel.org, Neil Brown <neilb@suse.de>, Dai Ngo <Dai.Ngo@oracle.com>, 
	linux-kernel@vger.kernel.org, Tom Talpey <tom@talpey.com>, 
	Olga Kornievskaia <kolga@netapp.com>, lvc-project@linuxtesting.org
Subject: Re: [lvc-project] [PATCH] nfsd: fix memory leak in
 __cld_pipe_inprogress_downcall()
Message-ID: <d6ac2546-cf4e-43c3-bc41-b62a61141339-pchelkin@ispras.ru>
References: <20240216134541.31577-1-a.burakov@rosalinux.ru>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240216134541.31577-1-a.burakov@rosalinux.ru>

Hello Aleksandr,

On 24/02/16 04:45PM, Aleksandr Burakov wrote:
> Dynamic memory, referenced by 'princhash.data' and 'name.data', 
> is allocated by calling function 'memdup_user' and lost 
> at __cld_pipe_inprogress_downcall() function return

It is not actually lost. If nfs4_client_to_reclaim() fails and thus
returns NULL - this error case is already properly handled.

If nfs4_client_to_reclaim() succeeds then reference to the memory in
question is passed to crp->cr_name.data and crp->cr_princhash.data
correspondingly, and crp->cr_strhash entry is added to the list associated
with nfsd_net. In this case the memory is supposed to be freed by
nfs4_remove_reclaim_record(). See comment for nfs4_client_to_reclaim().

So I think the patch just introduces a double-free.

> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 11a60d159259 ("nfsd: add a "GetVersion" upcall for nfsdcld")
> Signed-off-by: Aleksandr Burakov <a.burakov@rosalinux.ru>
> ---
>  fs/nfsd/nfs4recover.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> index 2c060e0b1604..02663484782d 100644
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@ -850,6 +850,8 @@ __cld_pipe_inprogress_downcall(const struct cld_msg_v2 __user *cmsg,
>  			kfree(princhash.data);
>  			return -EFAULT;
>  		}
> +		kfree(name.data);
> +		kfree(princhash.data);
>  		return nn->client_tracking_ops->msglen;
>  	}
>  	return -EFAULT;
> -- 
> 2.25.1

--
Fedor