Received-SPF: pass (google.com: domain of linux-nfs+bounces-2026-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <CAKAoaQkeevOpxQPjH+KZt3fyYweLsrY-bhHsqvOpdVXuGYwqXA@mail.gmail.com>
 <ZdI0I8YV2Vir8f7g@manet.1015granger.net>
In-Reply-To: <ZdI0I8YV2Vir8f7g@manet.1015granger.net>
From: Roland Mainz <roland.mainz@nrubsig.org>
Date: Mon, 19 Feb 2024 04:02:15 +0100
Message-ID: <CAKAoaQ=CaBGSnoTK9GteCj=CWjMxiGcEhozCOuqu7-ygBeAHYQ@mail.gmail.com>
Subject: Re: "nfsd: inode locked twice during operation." errors ...
To: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 18, 2024 at 5:45=E2=80=AFPM Chuck Lever <chuck.lever@oracle.com=
> wrote:
> On Sun, Feb 18, 2024 at 01:00:33PM +0100, Roland Mainz wrote:
> > I'm getting the following errors from nfsd in the kernel log on a regul=
ar basis:
> > ---- snip ----
> > [349278.877256] nfsd: inode locked twice during operation.
> > [349279.599457] nfsd: inode locked twice during operation.
> > [349280.302697] nfsd: inode locked twice during operation.
> > [349280.803115] nfsd: inode locked twice during operation.
> > ---- snip ----
> >
> > nfsd runs on "Linux 5.10.0-22-rt-686-pae #1 SMP PREEMPT_RT Debian
> > 5.10.178-3 (2023-04-22) i686 GNU/Linux", exported filesystem is btrfs
> > on a SSD.
> > NFSv4.1 client is the Windows ms-nfs41-client (git
> > #e67a792c4249600164852cfc470ac0acdb9f043b) compiling gcc under Cygwin
> > 3.5.0.
> >
> > Is the nfsd issue known, and if "yes" is there a patch ?
>
> I believe that warning message vanishes as a side-effect of this
> series of commits:
>
> 7fe2a71dda34 NFSD: introduce struct nfsd_attrs
> 93adc1e391a7 NFSD: set attributes when creating symlinks
> d6a97d3f589a NFSD: add security label to struct nfsd_attrs
> c0cbe70742f4 NFSD: add posix ACLs to struct nfsd_attrs
> 927bfc5600cd NFSD: change nfsd_create()/nfsd_symlink() to unlock director=
y before returning.
> b677c0c63a13 NFSD: always drop directory lock in nfsd_unlink()
> e18bcb33bc5b NFSD: only call fh_unlock() once in nfsd_link()
> 19d008b46941 NFSD: reduce locking in nfsd_lookup()
> debf16f0c671 NFSD: use explicit lock/unlock for directory ops
> bb4d53d66e4b NFSD: use (un)lock_inode instead of fh_(un)lock for file ope=
rations
> dd8dd403d7b2 NFSD: discard fh_locked flag and fh_lock/fh_unlock
>
> plus this fix:
>
> 00801cd92d91 NFSD: fix regression with setting ACLs.

Ouch... ;-(
... so the patch at the bottom of
https://patchwork.kernel.org/project/linux-nfs/patch/533299E9.6010806@gmail=
.com/#8291331
is not sufficient, right ?

> Any upstream Linux kernel after v6.0 should operate without that
> warning. I don't see those commits in origin/linux-5.10.y.

Are the kernels in the Linux 6.6-stable branch "safe" as NFSv4.x for
NFSv4.1 client development ?

----

Bye,
Roland
--=20
  __ .  . __
 (o.\ \/ /.o) roland.mainz@nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /=3D=3D\ O\  TEL +49 641 3992797
 (;O/ \/ \O;)