Received-SPF: pass (google.com: domain of linux-nfs+bounces-2045-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fe95feb5-a2b7-456c-957c-2b50f1eaac77@oracle.com>
Date: Wed, 21 Feb 2024 15:52:26 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] NFSD: send OP_CB_RECALL_ANY to clients when number of
 delegations reaches its limit
Content-Language: en-US
To: Calum Mackay <calum.mackay@oracle.com>, chuck.lever@oracle.com,
        jlayton@kernel.org
Cc: linux-nfs@vger.kernel.org
References: <1708473508-19620-1-git-send-email-dai.ngo@oracle.com>
 <530d4fa6-f4f8-4981-b352-095c9d038f41@oracle.com>
From: dai.ngo@oracle.com
In-Reply-To: <530d4fa6-f4f8-4981-b352-095c9d038f41@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NWFEb0pseHhPZjY2TEFla3ZjMzFkTTdIWmk5bG1QNStWMEtBR1ljSXh6K292?=
 =?utf-8?B?aVpFOHRtdzQveFhRNXgrSG04UWJadWtJMUwrNWM3bHlOTXprUElhMlR1SFds?=
 =?utf-8?B?N1ZBWUcvdWl3MUFjT3V6dGJpbjdpTzhNZ213TFUyN2kvK0RRSEdyNmdHUFo0?=
 =?utf-8?B?TEdNV2lmTHhIdzA0UjZCNytOOW1jVTRERVUvSkxmdkRCMEpUTmVaUnBmeHRU?=
 =?utf-8?B?NW1Nb0F1eGJuQk0rdG1Hcy8xdlBEdE1kS2VWNzNxdWtrZ3padndIWC9pQUt0?=
 =?utf-8?B?UDE3cksyTGxOKzRNK1ZQWFd2TU9PUlR4MFVmb20zNStpTE9UVG1Sc3Y1UVpi?=
 =?utf-8?B?Z0FycWVnclNDMFFXQzFtR0ZyTXh2QUJhVlVjYm9SaU9tVjZSQklBUlozdUlp?=
 =?utf-8?B?S1BkN2piN0Fyd2pUUk9qYnRTMXlLSHFwejJlVU5wMHM4NzBSSnBXM0I0WTMy?=
 =?utf-8?B?Y0laVWdobzFEb3ZQaHF2cjJpN1JJcmhKR0cwTWpRc3QwTjVpd3pIbEl4clhU?=
 =?utf-8?B?Tld4eW5VOEdQQyt2OThuK2JQSWQzcGRQRGpOMy96NkZkQnl4TEUxeEFnQ2I0?=
 =?utf-8?B?cmVUZUZ6SGVFRE1zdkMwY1JKdURlTENNMlRUYkdiaEhONGt1d1oxbDVjWHhi?=
 =?utf-8?B?WHVQclNqaElWQ2ZISCtUem1QUGt1OC9BaEM5VXlUenVUdm9uUmxnbnVjTlBl?=
 =?utf-8?B?WUM1Nzc2UXQ3enJhZ2JPc3o1TERrVXJsbENxWlNiOW91Q0pQTjhac2hpVkhX?=
 =?utf-8?B?RlByYUVJbXo4R3Y2eXlKbzQ4d2lSSXJGUVQvZ3k4aHNQVDBJa2JwbTdlWTNU?=
 =?utf-8?B?T2RiTWlrWnF1RUlLR2ZnQVYrSzFRdUFKSlJINFc2ZWxmVFp2d3VmMDR2U2dP?=
 =?utf-8?B?TFJWejdMOW8wNEcvd2ljTUlRYzUzaVRwZys0QTNsVEJOeUxnMERNdERxZTc5?=
 =?utf-8?B?RGdGTjh3TmI4VW03dElYWG9CckVwaXJXNGNvMW9sOHl0cmRJZVVVa25lVnJ4?=
 =?utf-8?B?UC9EampsQTJ3emRkUlVNNk5jSGJxc3NKUXlnY29WN3M0akZUcjIzVWN1MFhW?=
 =?utf-8?B?eGR6aTJEN0NTNS9XRERtWG5pb045NEF5Mk9DZzM0enZPWFc1Y1FsQ1NRR0Q2?=
 =?utf-8?B?TnlvMk1iZDRGOTZ5bVAwc2Y4ZXFCUVVXbHhEZ0JjSWdHVkV2M3dNZkRKdDlZ?=
 =?utf-8?B?dmRXQUo5bXlXemRkeE8wSEFzVFFOeWM4cWE5blhDYzlHdHUrak8ycW84NU90?=
 =?utf-8?B?TWdCNEEzOTlidHY1WnlYZHROM3hYU2F1dHprcFNEeW93WFczMmJtcWhhaDRO?=
 =?utf-8?B?S0dSaDE3UzlnRW1ORTVQdUdpaU1yemI3bW9hSFJabzJxVk1KNFpOcXdTMkF4?=
 =?utf-8?B?dXFvRVFqUEp5bzFpNGlOWGp4UStVRkZPUEQxOU4xTTl3dTYzK3d4Y1ZURnY0?=
 =?utf-8?B?TVVtUm5LUFZVRHJDYkQ4TmpOV1JnOVRYVUVJUW9yUUZsM1ZkZTVrcFFlMURJ?=
 =?utf-8?B?TDNDTE12YVFJYlFGQy91elJMZjBHZHRmOVVId3lPbHJORUZEdy85T09nYVl0?=
 =?utf-8?B?UEcwTEZXdy90dEU2ZHZlQTUrWlFubGt3NHhKYmtNazdCWHc4UXpVN0JodzJU?=
 =?utf-8?B?Tkl4ekdZTjZLTzJxamNucHlmeFVPUWUxeDZkQVhEbllBYnRLdjFncXR2WWkr?=
 =?utf-8?B?REM1QTd0c0RSMEZrVU1aMURlNTA2UTJCdFRISTBOeGJYbmlUeVBHRy93QnFK?=
 =?utf-8?B?T0dhbkx1Z0RMcllVWlNGRUMzdzR4OGM4R1UwVXRTY0srWk9uVG9NV2JzZHFU?=
 =?utf-8?B?aXNhbnp1TDlGUU5wbkMwdEdTeFdOZlpFcXY1QXRCSDh6blkyU3hMaDgvOThS?=
 =?utf-8?B?bTFTNGVpc3p2MGxGWGpHWGsweW4zUklRRWJlcElPcFJSdmxDdTdHUlZRTUtw?=
 =?utf-8?B?SmJqOTBtV0MwOXNtUTQ2eGo5MWpMaHhMc1pmbm1MRWRQOVkrcitmejg3T1BP?=
 =?utf-8?B?QmhRM1BOcWw4RnpMU3o3N1R4L2N2Z2JSL2VDRnhVZWZDR1RGSXNhcWtCcUhD?=
 =?utf-8?B?SVloSkY1RUdMM3BiS2RkclJlYTVNdjRCdVFJSjhOMWFva2ViY3c5cDZ3cGkw?=
 =?utf-8?Q?xcoe5lUHSMG5B8pN1dtTogapf?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Khu6INUgUxqcJ2eMFe2qkgFJZbG7V9/llndEkOuneiH8skQWjk5mTpvZq98uKNJOfT0vVGhq2P3ZUNL9XbqDYzPgi7l6kGosUKdpZxpLISakqt1/UnTJyJaxPcOdBGwl+dV99dV1xMj1Vo37SP+w0gHVs9BBCVA8dVx1KgNFYuF+67gW0LZUlvEkAxQxZJW9KCahC5MieomeO75EQUGZ1yrNK84C2QTrJTw4+rk0R29L8GdE4C56qmQ46PHtpNYEhjKpPOG5Ziip5EQFORP+iZ/GTDaLU2H57apA2DhEqGnSjHZxWGjjmsE9bxCtTGDnvrRwQxityAMNSxht8KmN1ZUSUhU7OLphBiNIilHKRxnWSrttsXCgrubh9HqN9Hy+ZXmvRYN8nff8NJqJNqL4/UEAHCJ5s4q86FhFfJppI3TtRLPQWUILadCsFZZnRdeuWPx++V1V0jnVgkdMAE6McnYCPOIHoRr4vBLgZzPMnAvDtbpXipQSA2Dmea+bntuHD4FkPYnNoJsrX9idz2uwQg+HZTBzHWuqEWnHhMy2N3Y6VKKe1+fejPs49PH5SbRPDb97ZqnW2u5IaIpgULL2u7MSM7DFl8P3ORzutAfIMsk=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b8654bdb-66bc-47e5-3d41-08dc333828fc
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 23:52:28.0338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BsOtGfanFPm9dpWbr6NniScqQ5CxbSKiw+oFwcDqCk0qIcz8ks9ZatzPLtPJdHQA7jmUbLGPZnzEpqArMTtevA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6366
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-21_09,2024-02-21_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402210188
X-Proofpoint-ORIG-GUID: E-Lke4RO-pX0VMnawbh_qsoHmMd3yvCK
X-Proofpoint-GUID: E-Lke4RO-pX0VMnawbh_qsoHmMd3yvCK


On 2/21/24 2:55 PM, Calum Mackay wrote:
> hi Dai,
>
> On 20/02/2024 11:58 pm, Dai Ngo wrote:
>> The NFS server should ask clients to voluntarily return unused
>> delegations when the number of granted delegations reaches the
>> max_delegations. This is so that the server can continue to
>> hand out delegations for new requests.
>>
>> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
>> ---
>>   fs/nfsd/nfs4state.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
>> index fdc95bfbfbb6..a0bd6f6b994d 100644
>> --- a/fs/nfsd/nfs4state.c
>> +++ b/fs/nfsd/nfs4state.c
>> @@ -130,6 +130,7 @@ static const struct nfsd4_callback_ops 
>> nfsd4_cb_notify_lock_ops;
>>   static const struct nfsd4_callback_ops nfsd4_cb_getattr_ops;
>>     static struct workqueue_struct *laundry_wq;
>> +static void deleg_reaper(struct nfsd_net *nn);
>
> Nits: If this is actually needed (you seem to be calling it after it 
> is defined?), 

Yes, it's needed for a clean build:

fs/nfsd/nfs4state.c:6554:17: error: implicit declaration of function ‘deleg_reaper’ [-Werror=implicit-function-declaration]

> shouldn't it be with the other forward decls around lines 84–89?

I'll move it up in v2.

Thanks,
-Dai

>
> cheers,
> calum.
>
>>     int nfsd4_create_laundry_wq(void)
>>   {
>> @@ -6550,6 +6551,8 @@ nfs4_laundromat(struct nfsd_net *nn)
>>       /* service the server-to-server copy delayed unmount list */
>>       nfsd4_ssc_expire_umount(nn);
>>   #endif
>> +    if (atomic_long_read(&num_delegations) >= max_delegations)
>> +        deleg_reaper(nn);
>>   out:
>>       return max_t(time64_t, lt.new_timeo, NFSD_LAUNDROMAT_MINTIMEOUT);
>>   }
>
>