Received-SPF: pass (google.com: domain of linux-nfs+bounces-2053-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 22 Feb 2024 13:25:34 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
        linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
        Neil Brown <neilb@suse.de>, Olga Kornievskaia <kolga@netapp.com>,
        Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH] NFSD: Fix nfsd_clid_class use of __string_len() macro
Message-ID: <ZdeRnhXLhlXN4AqE@manet.1015granger.net>
References: <20240222122828.3d8d213c@gandalf.local.home>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240222122828.3d8d213c@gandalf.local.home>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?AWSdT4ylgRGqGTis6UMLXHIMyxaKcdNLFcML/xahF2DbKPyDx4vvrer6e151?=
 =?us-ascii?Q?yk+7t3z6AJ3RVB93Z/RR/wRALYxi85yRD7iv5jbQ7idcFTEe0G/MckAGffYa?=
 =?us-ascii?Q?mEyfFTZ346q6Zfzw+RdfZFYox3t++9TJch3p0ygbXuO7GYWFJufnuTIA8hSI?=
 =?us-ascii?Q?5swjQghYVvB8uJOssHVkKSbaAFmgyOgXZRxDMy8JZnrhlkukpgX0ZY96bYo7?=
 =?us-ascii?Q?k7FvYbScf+mVJcl7lCQkO+sMlYQTDnrNPyr8d0vLWSsQBEMUf83KN66RCYk+?=
 =?us-ascii?Q?8TFCkuGXVqW18ONY+fPp8qnDeUErHRKj3dsmxD4rnhwAYyBQ7wy3QZMt5/DU?=
 =?us-ascii?Q?E9Hn4zTPpBVO1WiNjdUnMtRVfKyCDVgfxkbSes6ydf/E0OgyQnJ4sVodrNH+?=
 =?us-ascii?Q?5PU0aZQnmc6QfU2M5nH/R9Q3ohCRkFw7+2/AKcj0sxRAGrSD8nHTT+cEYDbg?=
 =?us-ascii?Q?r6pa6ClOqJ2veXO2w2SPcjpMkqfdvhrXhgW2Q1ccEeoWd5qQ71gvMtNkkPzJ?=
 =?us-ascii?Q?mfaYjlvkfDSPy2AH28wW4Ifnr7BQaacXWh0LtLFVhk4ohqInc1EAoGMiQrus?=
 =?us-ascii?Q?uiPMltlAeR/nXXZUVEkMoUNkO7REMqzgeifyQWyPNHLZybPClWZ2tPsSbkps?=
 =?us-ascii?Q?WRvZrbp41nNyEqMZY9Df1GFsmu9/3OUPTxzkEVIgdOzsnLfiSFHIZLh0txqb?=
 =?us-ascii?Q?Nqka4HtF/9QpETQEqRdZ6/yf9hyqgcJC6RBrjJAz+L2/PxB28n2jIO9eiliz?=
 =?us-ascii?Q?gBd9rarW99zmwhkOCNpT9IK0hPYFpXp2iT/VZAjU7+43XE4apjXpRmIqMTI0?=
 =?us-ascii?Q?38bd9KlKLRyggVU0G8yQ9hkL3eTpIT+XvyZ8P6ixkwFgO1kY2eU9tnKVsDob?=
 =?us-ascii?Q?WaMz2oV/wyA4IiTt4D3hX8CbkCWrqwpUpLPdqiYya4inDtrPNPOj29zuFIZj?=
 =?us-ascii?Q?wTbmhXe3rl6ucHDQD1AtSWCeKC+LwlvRK8x7xFsirmuaPzxO1T89tyKwJ2Yb?=
 =?us-ascii?Q?qj6G5cVz5cgvDeOTd493EfRuZx3oIzOdC5emGEP9SjRFC7JeJTZ+TCdkzLUB?=
 =?us-ascii?Q?y/M705Yj8u4TQSObf3agqOxo4PtKCDnGJO2PYsDHjb7rc/sEG/zZnCv8ChHv?=
 =?us-ascii?Q?CEy/7H63CuPbHGBPvy9pg6glBWzZHTbal7UYN9UsemnyO5ryM9iNdzZyvKVI?=
 =?us-ascii?Q?nEubbmD3fczAgjEgjQSMrJNVFwQ020DbC0SorhVTLwfujg3N70B5TgpzaGke?=
 =?us-ascii?Q?iE0TA0q60p7BykTm455BltO8F4MyRtN4VFkSkGYABSrMJzN7qRqS+doo0KPG?=
 =?us-ascii?Q?25uUh3LGZuRMTa5/sl9DEvGhCJSoUJMX9lUBM3Q/IwSnWvpK362ztEBIj8fF?=
 =?us-ascii?Q?Mdpc0VVaoVyHdKNeG3pR/k4UR1+lVvX/iq+jtCrFFXIyrlpisTdIoIzvlwzR?=
 =?us-ascii?Q?Y8uJojrd3JOBqjFrvmdyiDnJUEgOsGBx166PUczDdcLjrKuAxsLo6RnjpO5R?=
 =?us-ascii?Q?5jA4UfwV/LnmAx40dXzDAnWQgB8U56rbPbavbNP91yivblTSOAJBzLDNdYhN?=
 =?us-ascii?Q?pMo3yBHG8OOHN7Rc2sCwU/3K2z5Z85IjcqxG9j4SEmc9V1fccZeIa7S5mncp?=
 =?us-ascii?Q?hw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	cX1jf2zEy6Tyn8AZWDMrNG3ZLxUBeu3SuEqun5Ua1kW3N50xdeb4OdRDmAQlhMsuZlji1i89sWQ0hjSNFeipwsOucy5HZytHeCnQ7Iuma+NDPZRKhRTzd8WbIdN2VD90My1CILi7p0rxm5nmTgPA+Ipe0iP0H4NzAnPKxBJGPtqZynMtqk4ORGGXzABVm+kPtvMPkzlRlUAFjiFcRrl35bUPs7hTIV8BMQBeEWiwHV3cM9t3Zjfwti2G3pGnbRK/W+isKgc3YVccNRPnN147ky93jzINE7KidhVrdhzJK8EzHDqv/WWPVaOvJriYKwgbpDCy8KQbGWIXkTP/l62m6b5L0djMx3HGL+SMsDb5ax95X486fIa++Pq1ClZ/XtBPHllGvL3eCNvJVbfrktqVShDvQ7a14uTHpHVgGk0M1TjyZbYYuFzdivxTVeA1C+jCy6vz65IpGtbKH41nkBjnDvO6Pn3ccXVzeGL4Ksze0anN6sZYIX1uNFVxEzBR9k3siyS65IqK1VFGu3b8odNenI+f13UA2mJqanBndsShcxzQ8fLEnHDSwT+fdpW6GhAMtY1b4apvfkx24eVAaR+lnpu3hr5uyJImrkNcaoyU0zE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16fcc3c9-86d5-4d52-9cf1-08dc33d3aaae
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 18:25:37.5508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bBmOdo5PYccnpba8QusZpUCPMUd3bwItN3YfvdS2+sRnVU4G5Sw/9evx8iQZnCe93dNeIUGHesFR+qQ+lTcong==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4450
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-22_14,2024-02-22_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402220144
X-Proofpoint-GUID: LqDO671s62jWOq-St45rkoRa2N_ukVK5
X-Proofpoint-ORIG-GUID: LqDO671s62jWOq-St45rkoRa2N_ukVK5

On Thu, Feb 22, 2024 at 12:28:28PM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
> 
> I'm working on restructuring the __string* macros so that it doesn't need
> to recalculate the string twice. That is, it will save it off when
> processing __string() and the __assign_str() will not need to do the work
> again as it currently does.
> 
> Currently __string_len(item, src, len) doesn't actually use "src", but my
> changes will require src to be correct as that is where the __assign_str()
> will get its value from.
> 
> The event class nfsd_clid_class has:
> 
>   __string_len(name, name, clp->cl_name.len)
> 
> But the second "name" does not exist and causes my changes to fail to
> build. That second parameter should be: clp->cl_name.data.
> 
> Fixes: d27b74a8675ca ("NFSD: Use new __string_len C macros for nfsd_clid_class")
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
>  fs/nfsd/trace.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h
> index d1e8cf079b0f..2cd57033791f 100644
> --- a/fs/nfsd/trace.h
> +++ b/fs/nfsd/trace.h
> @@ -843,7 +843,7 @@ DECLARE_EVENT_CLASS(nfsd_clid_class,
>  		__array(unsigned char, addr, sizeof(struct sockaddr_in6))
>  		__field(unsigned long, flavor)
>  		__array(unsigned char, verifier, NFS4_VERIFIER_SIZE)
> -		__string_len(name, name, clp->cl_name.len)
> +		__string_len(name, clp->cl_name.data, clp->cl_name.len)
>  	),
>  	TP_fast_assign(
>  		__entry->cl_boot = clp->cl_clientid.cl_boot;
> -- 
> 2.43.0
> 

Do you want me to take this through the nfsd tree, or would you like
an Ack from me so you can handle it as part of your clean up? Just
in case:

Acked-by: Chuck Lever <chuck.lever@oracle.com>

-- 
Chuck Lever