Received-SPF: pass (google.com: domain of linux-nfs+bounces-2063-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <0aed6cf2-17ae-45aa-b7ff-03da932ea4e0@quicinc.com>
Date: Fri, 23 Feb 2024 10:30:45 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [FYI][PATCH] tracing/treewide: Remove second parameter of
 __assign_str()
Content-Language: en-US
To: Steven Rostedt <rostedt@goodmis.org>, LKML <linux-kernel@vger.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>
CC: Masami Hiramatsu <mhiramat@kernel.org>,
        Mathieu Desnoyers
	<mathieu.desnoyers@efficios.com>,
        Linus Torvalds
	<torvalds@linux-foundation.org>,
        <linuxppc-dev@lists.ozlabs.org>, <kvm@vger.kernel.org>,
        <linux-block@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        <amd-gfx@lists.freedesktop.org>, <intel-gfx@lists.freedesktop.org>,
        <intel-xe@lists.freedesktop.org>, <linux-arm-msm@vger.kernel.org>,
        <freedreno@lists.freedesktop.org>, <virtualization@lists.linux.dev>,
        <linux-rdma@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        <iommu@lists.linux.dev>, <linux-tegra@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-hyperv@vger.kernel.org>,
        <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        <ath11k@lists.infradead.org>, <ath12k@lists.infradead.org>,
        <brcm80211@lists.linux.dev>, <brcm80211-dev-list.pdl@broadcom.com>,
        <linux-usb@vger.kernel.org>, <linux-bcachefs@vger.kernel.org>,
        <linux-nfs@vger.kernel.org>, <ocfs2-devel@lists.linux.dev>,
        <linux-cifs@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
        <linux-edac@vger.kernel.org>, <selinux@vger.kernel.org>,
        <linux-btrfs@vger.kernel.org>, <linux-erofs@lists.ozlabs.org>,
        <linux-f2fs-devel@lists.sourceforge.net>,
        <linux-hwmon@vger.kernel.org>, <io-uring@vger.kernel.org>,
        <linux-sound@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-wpan@vger.kernel.org>, <dev@openvswitch.org>,
        <linux-s390@vger.kernel.org>, <tipc-discussion@lists.sourceforge.net>,
        Julia
 Lawall <Julia.Lawall@inria.fr>
References: <20240223125634.2888c973@gandalf.local.home>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240223125634.2888c973@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 2/23/2024 9:56 AM, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
> 
> [
>    This is a treewide change. I will likely re-create this patch again in
>    the second week of the merge window of v6.9 and submit it then. Hoping
>    to keep the conflicts that it will cause to a minimum.
> ]
> 
> With the rework of how the __string() handles dynamic strings where it
> saves off the source string in field in the helper structure[1], the
> assignment of that value to the trace event field is stored in the helper
> value and does not need to be passed in again.

Just curious if this could be done piecemeal by first changing the
macros to be variadic macros which allows you to ignore the extra
argument. The callers could then be modified in their separate trees.
And then once all the callers have be merged, the macros could be
changed to no longer be variadic.