Received-SPF: pass (google.com: domain of linux-nfs+bounces-2138-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 1 Mar 2024 09:05:25 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: NeilBrown <neilb@suse.de>
Cc: Jeff Layton <jlayton@kernel.org>, linux-nfs@vger.kernel.org,
        Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <Dai.Ngo@oracle.com>,
        Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH 0/3] nfsd: fix dadlock in move_to_close_lru()
Message-ID: <ZeHgpS1fZveRg2bF@manet.1015granger.net>
References: <20240301000950.2306-1-neilb@suse.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240301000950.2306-1-neilb@suse.de>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?JDXr2hLgpOx8LDpghh6lvtUi84drMoYnezIvf86k3M2lGQLre8UJ699obM/B?=
 =?us-ascii?Q?m4TT3uVn2giF0u2z4TSvlx1+nLNCehc7YGLb1NFrY22Wd6nF/CxvN9aFhKox?=
 =?us-ascii?Q?aiUtRGLu9G32PcWlXxTfwiXe4RwsEIOhiBdn0Gf6d8XyU70ssnstxOAyunsc?=
 =?us-ascii?Q?2In6PXRm8QgvA3isTV35O86Z+NKtmRdEyLME5o1C3ZVm0d2d5VblKvk2L8JA?=
 =?us-ascii?Q?RmRelqWcIMBYlfYizBmD37i7tMsw+fHPeguNI5OzbTcLQkVHGy3ckG4slxNH?=
 =?us-ascii?Q?UA49XxloWw5oxZRtDzBIjH1uLHA+zKqLwFbYz0lagz9X4W5FQYMyXnfLsFF+?=
 =?us-ascii?Q?ee8np99QfnrXt6fTbsFzF6IE84+1AZj9mMpPjb0g5G5cNVyeAdtQFnhTi3kz?=
 =?us-ascii?Q?M5vfLzQZ3kOy+sqkcD33QTbftNU0SYdU/4tmcbmgZpv8lTcBtTGAbdFxFwxe?=
 =?us-ascii?Q?PGyTc59W4HQq+B7yqUYp6pn1YEVnbSfLwjLSV7VJuLm6Y8peBGHBljvjNpg5?=
 =?us-ascii?Q?vH8Dm/XP0dBKsxZa4KX3k01E8V5FUJT1f4adX6cpyVTsQs8NPi0NqYsb+lGA?=
 =?us-ascii?Q?A6+SFXcyebmr6gMQRawSvrQrIiuxSspVFf09Ek6yXoC2eFGpvrSdzh0yUMte?=
 =?us-ascii?Q?qOjBIE2XREy59I13iuMM353wJA0kTNGggYJM0GfgR8XziETjEopI8hZA5Snh?=
 =?us-ascii?Q?YzLLBkB+zSViQTnwoXGzYCFZpdzvcotFdtuoT76fmcFGFhxgFm7X+EluZpY6?=
 =?us-ascii?Q?uzCScpicRrZVHEI8ID2eT07EQPIKniQkRfZbBSmaOj5rdYlUYcMUgq6WnZ+j?=
 =?us-ascii?Q?SkRrE9sEgv8hfEQMfgJ28vqP5McIpjr0eQxgjX0pCnFwjIk1mwWlYFne0NJW?=
 =?us-ascii?Q?dwKIjl2owSaVXw+T6+s1DimBwrXHj8rIpBfn8xrkhMhw2IMiZ2I6p6LLO/J5?=
 =?us-ascii?Q?wUYyYW+9aAvfpO044BkbNHxVB+i/Gr2uh+GhfqgXpJrbK3/CpIQ8WJaNmVxR?=
 =?us-ascii?Q?Vn9176tNUa9yeXJfqHpunVEkDQuSFl/xpO7CuSGefDQO0zE78+ew3e0LciOD?=
 =?us-ascii?Q?hR7aEeIzGTRba6zrj73v9XoN0hj+1ThAaVYGGUzlnQhJ8h01CExYNvKkW8F+?=
 =?us-ascii?Q?OecqWK8zZYS++LT5TNhIB0h9LWF5BOZOkAlPEf1oKfYadR7+H42EJS0UY5Mh?=
 =?us-ascii?Q?xCWMDP7xLldekgE8ju7fIqZkZthRhNmz+nRKTXhTNO3sOXZT8nbfDoLHOnUB?=
 =?us-ascii?Q?35BUOy1GWe0xFjvvOyxAPnBVCkCOu3xe4yVx0B/83BW77CN3N7rfTtizQ/Q1?=
 =?us-ascii?Q?YtY4YqQJ36zQscweG7W/lrrc4WIqipn+0kKe0JgP5jJOXfut5xxNuacKMQ9C?=
 =?us-ascii?Q?beXf+ZKMFCHlsLFvdauO6j9eGCi/ecqPKZJRSwaxLOQ6snaX8HumfjHZ9orc?=
 =?us-ascii?Q?J2bFZFNmiLZI1Q3DPFxeuFFgPx1+Zcajx1MeyBARc7qZA5opJsFKYLP6Wi76?=
 =?us-ascii?Q?HehXsMLzubNYGQNIXVqp9TMJmhhLxoTx7a/BzqkqAbVKI7xc5nSoCzybw1sN?=
 =?us-ascii?Q?rqC8TlUy3wsidMPFVv+s6YMiwsXyXxdMu77wbPWKjN5HkeqfViLtuAl6aAAq?=
 =?us-ascii?Q?1g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	21FR5nF8VZjXsniezZCCn6xRDnKw6VEGObcYsQgA3XBKAdvdIsNsFkHZgmVPZBuN+fNPoyU06sdRaa6u72CsTQCU1AjCQwQzHqg7Ju6efQD/xMW4cGdIUNdB1v8uMVUbTzyHWw5ss1Hj+RvJIS7UlPhIyg+osTE9IkMPYVzNfCsYd798abRlRvo03kJvnST5+xBkRUGoFhdLRT901vLV7ilp5pU34bXIUd2cHPRRhlPTCPu0gjQrhK9VRFOY1ozslvnRcqxMOX2b/hlHfovoJFL4rjzzQpJDZXYA+KSSohCHc74e7O581V8uRtHYBOxSrCNy4cRJb5YN8FDVgn2/xxhAwvBYYT8ds30o6y/Af8IowrMSFb7VVoCg4HtIfZQAH3gLazYvIqYmlWo25wOhst4dO4VdxLp9KSlJjkUAENYYPAO0hjVMp6KaQHwGA1mWYHqBFZsoKPz/xVESR1ajY9XOW7EGsZrsR90yK+J1Xha9Da2+Flq3UkoMwe5pKsUNxKMucSolLuubQCgpOA+67BwsmUVsIkcKoo9PUWRxwxvKT993Oh8PaBog0K5lfhwn8Qr4q3dwNHlrtYKu13hC+QojL5nCRAGQg0AlKZJ4B+c=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55d4110f-beea-4bac-c169-08dc39f8a67b
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 14:05:28.9542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tOdbfuPgmjD1y0+aUUalK5UU1aTvYTEPls7VsPcJNxy4tBZt+qtdPyCD7L8s9ddB8PBKoiXrC6yzLoVijo5FUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4953
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-01_14,2024-03-01_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 mlxscore=0
 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=792
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2403010117
X-Proofpoint-ORIG-GUID: rYtf6GAFfzfl-RE_VnRVWl3elc9ya-Qt
X-Proofpoint-GUID: rYtf6GAFfzfl-RE_VnRVWl3elc9ya-Qt

On Fri, Mar 01, 2024 at 11:07:36AM +1100, NeilBrown wrote:
> This series is intended to replace 
>  98be4be88369 nfsd: drop st_mutex and rp_mutex before calling move_to_close_lru()
> in nfsd-next.

Hi Neil, I will drop that patch from nfsd-next now.


> As Jeff Layton oberved recently there is a problem with that patch.
> This series takes a different approach to the rp_mutex proble, replacing it with an
> atomic_t which has three states.  Details in the patch.
> 
> Thnaks,
> NeilBrown
> 
> 
>  [PATCH 1/3] nfsd: move nfsd4_cstate_assign_replay() earlier in open
>  [PATCH 2/3] nfsd: replace rp_mutex to avoid deadlock in
>  [PATCH 3/3] nfsd: drop st_mutex_mutex before calling

-- 
Chuck Lever