Received-SPF: pass (google.com: domain of linux-nfs+bounces-2169-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 4 Mar 2024 09:11:13 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: "jlayton@kernel.org" <jlayton@kernel.org>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] NFSD: send OP_CB_RECALL_ANY to clients when
 number of delegations reaches its limit
Message-ID: <ZeXWgYJUXeUU9lrL@klimt.1015granger.net>
References: <1709504582-8311-1-git-send-email-dai.ngo@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1709504582-8311-1-git-send-email-dai.ngo@oracle.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?sDJMhV2IMAquuaUY86lKzuqfifJu+IM7xlLEJXNz7nXsIrOoPrUhGBiV4jVC?=
 =?us-ascii?Q?IJU2iinckEcaT7SLzNlmvEEkuWXtkROad5drfxnja697EdriqB9yV9ZY52M8?=
 =?us-ascii?Q?3QZw2RMTdfY8HXsfLKPynp2AkAkgwx38S7/nqBd4YoxkGD4vfi6xlh7afUeR?=
 =?us-ascii?Q?6P8PeiL2MzM4bvh71GGtKuobrd1E6x02NyUeHysI/HZ4ovXvQSPVwRWNR1s7?=
 =?us-ascii?Q?/ZSt/m7RnUysEv4HS6WtBGNEW7arQ9lhcuKowUftj6mAAHxXHb+7QD91YUgv?=
 =?us-ascii?Q?Ps+6A4ei0vks9euyEgdmpNSB2soq6zLYxHopLFTHGFTwmfIGqExo2sguX5fO?=
 =?us-ascii?Q?/fIAdT80P/s0QYLYqxFu38DTa0SFAUAUWXJbW8X6LltNk5eDEz9ruf8RvOAI?=
 =?us-ascii?Q?m5ueIHCpwSN3emEzlmX4jXWUR+jRpLMhJ7aitDj01kBmivEEgZCQ3jzsYEmM?=
 =?us-ascii?Q?/CApQysFl2RkdiapAvi/jkQH9nx1rG8JrTNSdKVvWgmP/H8ZIQCNewb7ZSCN?=
 =?us-ascii?Q?6347TYPzPfaP61CQ0LU6eK9WgvL0Y+/HCMHeAI6lp9gfAbg4qBjO73p9/Kg3?=
 =?us-ascii?Q?Ps0bBVbsERZrFhiwMp2/uPX6kSff4CbtQM7CxwQmlY3oExFl9NEjzeOFhmYt?=
 =?us-ascii?Q?rOUO0Nwdh4wmQ7dAz+F76rGolohvQHIcdQjN6EPTnFb+Y0+wXo/A8TbLs1gm?=
 =?us-ascii?Q?LKWIH7dmAggLUNS/qVG5LUB5ZO+rHeVWKGFGLOr7bCQH/CankjCQMDDKRW83?=
 =?us-ascii?Q?jV8A87bdGVQw9zvZ/Gl6yi1Mq6XlWQTSBzYlJU6fkLPqSnjF0V9xigSDsBNo?=
 =?us-ascii?Q?gqpMf0ZlLJcmcvx0j2Yl6xaG8gqGdAtY1LiXhoaej00guIGov9XaLNLVpOVI?=
 =?us-ascii?Q?/JNg3rrrYaWY3evrgZ/KgyERjXq0KRJYV184qt+ZhhGndWQuytfbTbcYQWC2?=
 =?us-ascii?Q?InYHqX68I/jCNc+xfQje2hQXoLvmpiRG1f+aO/f8Y+lonarsnUB+u7N+l3dv?=
 =?us-ascii?Q?vlnPxVdZesXhc7JyNHkks1gcWxwSqK0Ba9JXdB2QuDRgzFaTPFq1z4URzjqY?=
 =?us-ascii?Q?D+vh1p2s9O26SwuXW0wjb0PoojNXn7u0RPVknR/+q1XMSfCmQT6PZoQzjGqD?=
 =?us-ascii?Q?Y15Ia1KX2Sj3iSGfygviYIdFhwS0pUdDyAPj47vs7HSlgeMSPrgwCSEhQzrI?=
 =?us-ascii?Q?0pJ12Jq8LcgbHsN0BWqYLnmBqk92tGUwP3S6rB1Y5S8N+u0RaMjGygT2+hWU?=
 =?us-ascii?Q?A4206voVGS/DmaEcOxLrpNwPgiyv1gSSLCd9dPJDFThDvZ8MWbOrVqns1E+4?=
 =?us-ascii?Q?ZfD/4ozomxpUwyOgEmbAkObXVNzFrNEpIbGc5fWF00M+H8PiDtQRlwUzUSUP?=
 =?us-ascii?Q?4lUI0mJj59bTd5HF0OqEKFe/2TjAOGMoVT1yXLfqQBdelYvdDbPVkTrFgVSM?=
 =?us-ascii?Q?CeZKRxwbLe1j5R6sXAows5UhzGOaIenCwZOz9JCl7i1FM7SHZgwiKLM+EAdW?=
 =?us-ascii?Q?dbElwTizk+I3XS3TbGw1wrndbM+14uWmjwOaxE/1UWHYk+x0C0/nv/yNJ6ve?=
 =?us-ascii?Q?0GIic1IPc0bU/9ymqah2Wf1pPn8RabJdj627frZ6TadaJTWeEKoUp9v2ABi2?=
 =?us-ascii?Q?ug=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	j5kNZ3Av6x1acmBgXEIjGqf8zH98vP1HTG0c3CSLJ3VVINnv+J8rCB8bKHQpsP3PHFXmnUugQ/ofo5SKTkYfThQ+RtSegyCfg9hYGdlSQaCO+51i5c6vSv2HXoNNHpWRDdesqOF9+iQ5J2jbG6pxoVixxSxL1/isRrqk7HUhqlioIR2E2j9Z6M8T4RnUfatoso61j5jWXpgq+KZRs9j9CU0fr6GU8eaIot4HO1eTWrV+SI4n/EhACZsgHMTvG+nYocVpB7wl0JOfjBh7SiizzqojaSkCzZCVPhlD234ROAWFz99rRHUeb8h6DAqou5zzFY0UWOeqNQJwD7GP9DOvgv8lswwKhxvW/vBbbgkrUhW3mAuV7Yqef9P5d52vJWrEdwJh0IrTYYsR1nYB5/oAJirkAK25KApVnyF3AWS3tk+JBUGd2c0EBRH3f6fEKzDt6br5ZA8KqkRra3qXXzGYSmlBgOMzFDWflQjtdInFrp/OJqiA4SAgnzEuJvp4krurUxREzmszdTQ6Smf6mhfP66lh1w6JAPSr6sYXrJi1ogbVE9BtbkNBPZ/wntQIoEzqPIlRX7FgdSY9RLnY3c4iBjWiW7kwADdiWAwA9olnMZY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b23c3257-7e16-4ce1-6394-08dc3c54f42a
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 14:11:15.1842
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zQM5oxNXk95Q9ztrRMQSbTpj1bCTe78XFCfPs7YtbldrBvHRbhX+KByvLPLho2qP20m43EeCKDHEc1P465LuLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4277
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-04_09,2024-03-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403040107
X-Proofpoint-GUID: UB2cGCZ6uXEdWIR_48t8qXxtJ3MbJ45E
X-Proofpoint-ORIG-GUID: UB2cGCZ6uXEdWIR_48t8qXxtJ3MbJ45E

On Sun, Mar 03, 2024 at 05:23:02PM -0500, Dai Ngo wrote:
> The NFS server should ask clients to voluntarily return unused
> delegations when the number of granted delegations reaches the
> max_delegations. This is so that the server can continue to
> grant delegations for new requests.
> 
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
>  fs/nfsd/nfs4state.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> v2: move declaration of deleg_reaper() up to other forward
>     declarations in the file.
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index fdc95bfbfbb6..961000261b3e 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -87,6 +87,7 @@ static void nfs4_free_ol_stateid(struct nfs4_stid *stid);
>  void nfsd4_end_grace(struct nfsd_net *nn);
>  static void _free_cpntf_state_locked(struct nfsd_net *nn, struct nfs4_cpntf_state *cps);
>  static void nfsd4_file_hash_remove(struct nfs4_file *fi);
> +static void deleg_reaper(struct nfsd_net *nn);
>  
>  /* Locking: */
>  
> @@ -6550,6 +6551,8 @@ nfs4_laundromat(struct nfsd_net *nn)
>  	/* service the server-to-server copy delayed unmount list */
>  	nfsd4_ssc_expire_umount(nn);
>  #endif
> +	if (atomic_long_read(&num_delegations) >= max_delegations)
> +		deleg_reaper(nn);
>  out:
>  	return max_t(time64_t, lt.new_timeo, NFSD_LAUNDROMAT_MINTIMEOUT);
>  }
> -- 
> 2.39.3
> 

Applied to nfsd-next. Thanks, Dai!

-- 
Chuck Lever