Received-SPF: pass (google.com: domain of linux-nfs+bounces-2181-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <c8e97bb6-7f0a-40a1-a52e-b5e6ad9d33cb@redhat.com>
Date: Mon, 4 Mar 2024 15:32:30 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/4 rpcbind] Supprt abstract addresses and disable
 broadcast
Content-Language: en-US
To: Petr Vorel <pvorel@suse.cz>
Cc: NeilBrown <neilb@suse.de>, linux-nfs@vger.kernel.org
References: <20240225235628.12473-1-neilb@suse.de>
 <b4b4d325-f15f-4fb3-a52c-c3f39d56018a@redhat.com>
 <20240304182931.GA3408054@pevik>
From: Steve Dickson <steved@redhat.com>
In-Reply-To: <20240304182931.GA3408054@pevik>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 3/4/24 1:29 PM, Petr Vorel wrote:
> Hi Neil, Steve,
> 
>> Hey Neil,
> 
>> My apologies on addressing this...
>> Too much PTO :-)
> 
>> On 2/25/24 6:53 PM, NeilBrown wrote:
>>> The first two patches here I wrote some years ago but never posted - sorry.
>>> The third and fourth allow rpcbind to work with an abstract AF_UNIX
>>> address as preferentially used by recent kernels.
> 
>>> NeilBrown
> 
> 
>>>    [PATCH 1/4] manpage: describe use of extra port for broadcast rpc
>>>    [PATCH 2/4] rpcbind: allow broadcast RPC to be disabled.
>> You realize that the broadcast code is configured out by default
>> ./configure  --help | grep rmt
>>    --enable-rmtcalls       Enables Remote Calls [default=no]
> 
>> So do we want to introduce a flag and man page section
>> for something that is off by default?
> 
> I would say man page does not harm.
> 
> If I'm not mistaken, it's disabled in openSUSE and Debian/Ubuntu, maybe
> disabling flag is really not needed.
As well as RHEL but not Fedora.

steved.

> 
> Kind regards,
> Petr
> 
>> steved.
>>>    [PATCH 3/4] Listen on an AF_UNIX abstract address if supported.
>>>    [PATCH 4/4] rpcinfo: try connecting using abstract address.
> 
>