Received: by 2002:a05:7208:13ce:b0:7f:395a:35b6 with SMTP id r14csp1274534rbe; Fri, 1 Mar 2024 09:07:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXDVMfxqvVOr8M0VoJu0C2efL0ca0zHF/3G4EM4LoVCW2+m7sMNBm6CpAvhZdCq3g9/mLG0xw7RBqq/aL/nbAZSaOB1HCh7xeRHLDX/kg== X-Google-Smtp-Source: AGHT+IEqCzKFVwC1Fvtu30y6qcyfYoR8zLxe7/TwKjJOIVKbh91s7DBtrsdSrWO84Ww8GQAEx76T X-Received: by 2002:a17:906:8d6:b0:a44:3056:1ed0 with SMTP id o22-20020a17090608d600b00a4430561ed0mr1747182eje.62.1709312823030; Fri, 01 Mar 2024 09:07:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709312823; cv=pass; d=google.com; s=arc-20160816; b=aRD9RLF/y6XXi8oWQI1lixUqbUq5V2urxh1TvCPzk/QUCcalZuAxzI06kRH1reZpq/ 10pf91F3+ItzRRiujAl1fDaWS/eUL07uXTTdNrQg0XfcdEVj7VUAJmE+43GTVJzQ7R+1 d8XJkXmzmtrv2kZYxQuN2Tc/pcNHtECu9V/8TYoQvDPDiZ564Qhho5kPWgpfhOjyfD+u Hj1AXla6DlnF3uMR83kQvkEi3wyUqGg7pT33UjEunh9T2xMtDom6N8z5h+d0bD98OpDx qE93t1A25AV6NDkY9Xw4g39HHdyAhI1536TlZPevH+QRMtrtLKnKCUs11dXbt+9kl65O 57ig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:to:from :dkim-signature; bh=HEq30T8zNRgXFzfgCXj/aGMoWyR3v1Uzp/vBUfafTAc=; fh=Uiz9I7dYrFDaVirUobae/oqR9u5Ik60x/apMbwOfg+c=; b=tESawPYSR55hI1h4afNCrRJqC/nIWHnrY/qPDVfQ2Jw6Abez902wYyaToQWAxxCRO9 5Zt978ZjZPfMs0QHaJYt9i213ElcZtZn03QxzTugElyasJarB5uggvhjFxauTsBTEKqi TZd5MJAm0Hk0a6PR+B9Qd/zVupg7oS3DHxWh7bQBy61b/UAUcezE4U0iB1C+NCdhdUh9 zaAdMT3LhRPuvLoKcCT2W4patVSFeUrbsejHjY49Hq3x+aeCKgr5Rfmb3KPrEcsfejC3 /nPdeOKRjs0lZ0IUeSSI7Tfk7Fw/CtEtP7/c6drzo2nU41rUIBBmDpeSrf3UFmdqjpcX Zt9w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=OdkMyky0; arc=pass (i=1 dkim=pass dkdomain=toxicpanda-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-nfs+bounces-2140-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2140-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ne33-20020a1709077ba100b00a4491dd5766si582890ejc.60.2024.03.01.09.07.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:07:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-2140-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=OdkMyky0; arc=pass (i=1 dkim=pass dkdomain=toxicpanda-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-nfs+bounces-2140-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2140-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B10441F29B24 for ; Fri, 1 Mar 2024 16:57:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D19C2570; Fri, 1 Mar 2024 16:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b="OdkMyky0" X-Original-To: linux-nfs@vger.kernel.org Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DE032A8D3 for ; Fri, 1 Mar 2024 16:50:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709311831; cv=none; b=pW2wrvnf7Pe/74vb/wbFvKm2fjTSUFjnarIFCGGGDP/jC18jloCV9y5fiu88tByU7BRoLABJimm6LCRL3loThD5Z4Dd5nUYRTmBLD1trNIXd+QPvNBVKDKVmKTzgWmzpEETNlb8Sur/mstV0XrRnDlf0EW65tAksPR3uHo/8358= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709311831; c=relaxed/simple; bh=vJUH/HqFQuEle4pRuhySVQp753SvqKULpIXAU4Rveak=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=kgabP2zflB6uMwKvhh7YM3zWuaqIZQ8Z99xhZzVthFA4kyrXUIjBm/TVFKsLWhA8H9thpRZES8Nx8k4IUS7SrBajnbBaNnRCz2yR/mPeDUjg207rtFXZNacPcWtRfMeaLMl4ma8YNli7Z8YvKeZN/7IFvu2DKH9KEo3beKr+bzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com; spf=none smtp.mailfrom=toxicpanda.com; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b=OdkMyky0; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=toxicpanda.com Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-788153bb79fso1734985a.0 for ; Fri, 01 Mar 2024 08:50:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1709311828; x=1709916628; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=HEq30T8zNRgXFzfgCXj/aGMoWyR3v1Uzp/vBUfafTAc=; b=OdkMyky0JOymGPk0k6uGTORWU1sgCgAp+qKAsriFUnWKq2RmqUODSBCVnSIKMluZDT G94ISpfuzMeKriUVZxupLf30b3qGbT7lOITx9mpeh4dPdJO78XREQDuGi5nXfDVBkIMi MxA5vNo3yMde2fhDVt9BN5jZjogSsu0c1HPt1cRa6SKUtvEA0SyKy3xlrzcEiPZAKv+Q yL1HU1zkLg18PSttjz3j7eggXqa0norXHEzVcn1e3Odz7CpsjLzHnlyNUuwav/lrAw3e /d4iPe5o7TP/r0++gedvXyyXR9OUQQn92hMQP4zhVHt+CptEDMosmwv0x9ow7/vVm8W5 +1Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709311828; x=1709916628; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HEq30T8zNRgXFzfgCXj/aGMoWyR3v1Uzp/vBUfafTAc=; b=tME1qsJrM53yYKPt1DAFkAcnFP4wWDEHNCNNL8+T7WtqLS73T84Y59l0jmuZ9koc8N PoTu9AeYQWEg2RIOMJ7PzqqfP/5TC7QtKSjRWXcjK+07ICBnJaOMrcZMkZNLOaVcaCB1 7BW48Jx1HrApJF0wRdHqb+HUAxFS4xqH1NttEfo11sX83B33sohTlVMn8Q9IPq+iiWkV qCqStkGdK5UgrMUTIoiIleKg+zHtD9cyssumjwpHyerdZiNuJHRp4kZCvOI/mGmcjEmv HaBkqW0jm97QYToOL9dkh6AcorrGndO7mIWjc1rUG9P6ViNGe/Xs8n6dG/dgTPdskMbt UPVg== X-Forwarded-Encrypted: i=1; AJvYcCVAxoGMKJN0MZtoxxDL0sDzeM2vK0uMMVHPdMfGI1/L/gW+W3I5Zdr6p4FHqQJrRAUOwS8iRVTmrRub9Q2aaP3pgdBXHTccqAYd X-Gm-Message-State: AOJu0Yz34OWvsFvNJhRg0jmVzjWvqYWdNp5gDoqY5PXzYs1Ny2v0M+zO ATE8R3b+M/65ayqOuc1e5hz1F2He1D3eX4hGWGnIESjDzU1fNPbCSwhSSdi4TnHkHVCmVdvnEz6 K X-Received: by 2002:a05:620a:1791:b0:788:46e:b1cb with SMTP id ay17-20020a05620a179100b00788046eb1cbmr6247211qkb.32.1709311828320; Fri, 01 Mar 2024 08:50:28 -0800 (PST) Received: from localhost (076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id m20-20020a05620a221400b00787ec0fc392sm1798290qkh.21.2024.03.01.08.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 08:50:27 -0800 (PST) From: Josef Bacik To: trond.myklebust@hammerspace.com, anna@kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH 0/2] nfs: fix UAF in direct writes Date: Fri, 1 Mar 2024 11:49:55 -0500 Message-ID: X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, Here are two patches to address a UAF we've been seeing in our stress testing with NFS internally. The first one is to clean up the accesses to the nfs_direct_req fields which is more a matter of correctness than an actual observed problem. The second patch is to address the problem itself. I've been running these patches on my stress test for a few hours now, I would appreciate feedback and review to see if this is the correct way to fix the problem. Thanks, Josef Josef Bacik (2): nfs: properly protect nfs_direct_req fields nfs: fix UAF in direct writes fs/nfs/direct.c | 18 +++++++++++++++--- fs/nfs/write.c | 2 +- include/linux/nfs_fs.h | 1 + 3 files changed, 17 insertions(+), 4 deletions(-) -- 2.43.0