Received-SPF: pass (google.com: domain of linux-nfs+bounces-2246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 8 Mar 2024 13:56:51 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: trondmy@gmail.com
Cc: Steve Dickson <SteveD@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] nfsd: allow more than 64 backlogged connections
Message-ID: <Zetfc_UEkl02Gu3N@manet.1015granger.net>
References: <20240308180223.2965601-1-trond.myklebust@hammerspace.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240308180223.2965601-1-trond.myklebust@hammerspace.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?GVccIE2AMfAXw+Dn1Timdbk99Q8+rmwtIEugezgj3WQMS3U+w6xh8jLuSthG?=
 =?us-ascii?Q?EIJdJFwSqWNfyFSvaC5QxOm37qOom6ZC2czm4NiyZzSxiw2W1O06DUfjVMI8?=
 =?us-ascii?Q?wKfOsweYi8S7cuzW06WQFlWJRn5Mb2i3oXOtJes3UysjcTz0UP81534Z4pZz?=
 =?us-ascii?Q?LHrDHn5n7I6gH24DxthT0TOpYjJONNFa+BeqMJwsyVigmopZNhFtUHinMV/A?=
 =?us-ascii?Q?ns6fkyqDOfI9BISHRi/+3VSTfwIFf179vZ+22BhC2g0fH1CsaQXjVm0DG+8r?=
 =?us-ascii?Q?VWHUj58keffprocO2TSWkh5J1Z0i44G9auumRi33M7uPj40zZeXWMBI6rJzi?=
 =?us-ascii?Q?xPmiAnYpeToxKwewd5wBdbfFyfYjpstuiIlF3kyVjHR46offJmShB6mkFgId?=
 =?us-ascii?Q?wKa3QoI4R+4/1mYGzIMjN4Rx4P7o3FYJ2CRZ7kWJHzkZ5HycTCX4I1CfDePm?=
 =?us-ascii?Q?mKWh+uAEY4hQXy6tZvS33XNf68YB509PnKGa/w6q53a4Q+XHV9xXLOwUeMxu?=
 =?us-ascii?Q?MnvWlv5FAb17FG9CNnHqFxDSOgM1Iw6WTZkz8SgbEIWGHxs1wCAdA1fK22JG?=
 =?us-ascii?Q?4HZcW2tjx/SYoKEpY0zDxnZTUJ4CAxQk5tivvcI04Z2pkEqUnMkrCvYsC7wU?=
 =?us-ascii?Q?FcZ0WFRadFkitdI7E5cqsXH9Ygfk2atMe8KhudiDUjWFbQUEER63PrCfbmbE?=
 =?us-ascii?Q?snZtZjbaOPJ7ONQDhpRYCuax9K37jtvTU9jYkcv0lcJF+tKVy5sJgam+PNW3?=
 =?us-ascii?Q?jtQ/1aahoS3GKjYcAhniWo/oFz3iaTZdYdwYj0kluhU07dnIqCqhcNQTwGDn?=
 =?us-ascii?Q?3u+3aiI/3I51Nqx9RMoJgdRxbRRIpzRuUglKq0j0fR9WDw9jfW2fPN1lBWFn?=
 =?us-ascii?Q?xR7Esw9gmRw9DUYD5xA8jhfvbtlHJ6mlYOmSZ4D1mujEgXrfb8PQZklgjfC6?=
 =?us-ascii?Q?5Dfxd66AwM73XaDL79N07ehtlczNOU9pEOneNomHvCUupogYlgJEAJchaC7q?=
 =?us-ascii?Q?I12dfOrkTEvsZUnQFVn+QQC43DBZTENrBcHkDsD6WSuOr+AgYbGUjtTAwDQD?=
 =?us-ascii?Q?cHnnFzqZDLVCR2iN00C3nU2FQSt++BcLKmF3dHdVLar+P+LKk6411w0LyIXs?=
 =?us-ascii?Q?kirNf/a0JQIaydcjnMhGyM2U4VPB+eDag9L/qX0D1v35q/A1CIpUpf0KRMwi?=
 =?us-ascii?Q?oCMercg0hb7o4QC01QpHswl2UeLIocM+TfGntszdb51AyJuLgQVEQjGR6EXt?=
 =?us-ascii?Q?wb3H3RzoKzfaRN75mh8s2KaXVbAaz4a2UQq2pwVq0btM7MVCBjJJmalYRXYd?=
 =?us-ascii?Q?kTQ0XTNed859Uv4j5YQxW05ow3mIkgPIRLXonuX/1kxORR3TYEHTGQyAihaL?=
 =?us-ascii?Q?2bxdJbNnD1N6a/c1pIiAYcDz48A17fNqxLjtI27IWqxghMHicLt4Vz2n2bPx?=
 =?us-ascii?Q?uNxXM3KxIZbBQ9DYq+NZYEK2b4ZdnIzBH/CzbhrVNJYtv6oNtijLT3WD0FoG?=
 =?us-ascii?Q?rmvTcf/zvBfFrw1QmbMUPhSlHH2KxGCNNr2l9ou4MmBpM3YGEqc5XnAEfsS6?=
 =?us-ascii?Q?10hWDpgAqms2WUhI73eneDv7HOtFZioUy2rZ4Scxyxd5Iz6Yn5zyuX350gp3?=
 =?us-ascii?Q?aA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	XzCZ+P8aLU/pm3nYw+JIcCpmesQlcCXIY/thgon4eC8XOhOxYqp3n5HcMjLCD9upmwFc1XpMcGIdkONhlDqX86PYDGZYc7u3quhStkRTSTiaZE2hJluKbjZX9N5bfSvD2aGpHPB8cptJYKMCBDfW5LokXav45diSFYEHGmk/pkT2dc2EtQjDvWqSbkcl89J9pnXqaGk2RkZ+hlGqX+pRVJI7600TEj63X2GMz7ikjWfc3yfpfXGzBcBtyhTIDNxGi/ovN+4th/GReP57f3rEYqDziMUvHF53eagePolG/Tj/3EmXKbnPJ5cZ9C924B0kXMZd0G/CuyhZ64YZCNaFAlB9VLPF0gE9vzgDn1rXjOa9uMvRxnAcBL4rWchSZnKtDAKUOKvDHV2/knvx85+f5+c4E5rIX0Jp9woBtG6Ov+t5URF5pxCJ4B14v+sXa2lLsQuYSWnT+CEXylTQWjwM/sYal+tzdc+EdrlhPbpUcyDkKVizz0pLVexf/4gYcpKi8SFSsHa//jlQ2HvkTigwljSyMLiHOIq7KAt09IMZlufqSWfzNsVJTwu6IezEyvmqaefaXjXx1XnTxlU0Bc8qTOCJJ4+Jh5hQg7aUmqUv1f8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 048a9039-94eb-4c17-d213-08dc3fa185c3
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 18:56:54.7211
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YLi6cTHMxnjIiT2t/E6Vc+eSFEZKDWrAz8OUbVLpAz1jGJb1VGF74Mfx9V+2w6H+QL5uYnPhzsoAT0KCVoemfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB7005
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-08_08,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403080151
X-Proofpoint-ORIG-GUID: ptgqbMn7cBKQ-cK49iC0aJS5VTJvSxok
X-Proofpoint-GUID: ptgqbMn7cBKQ-cK49iC0aJS5VTJvSxok

On Fri, Mar 08, 2024 at 01:02:23PM -0500, trondmy@gmail.com wrote:
> When creating a listener socket to be handed to /proc/fs/nfsd/portlist,
> we currently limit the number of backlogged connections to 64. Since
> that value was chosen in 2006, the scale at which data centres operate
> has changed significantly. Given a modern server with many thousands of
> clients, a limit of 64 connections can create bottlenecks, particularly
> at at boot time.
> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
> 
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> v2: Use SOMAXCONN instead of a value of -1.
> 
>  utils/nfsd/nfssvc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
> index 46452d972407..9650cecee986 100644
> --- a/utils/nfsd/nfssvc.c
> +++ b/utils/nfsd/nfssvc.c
> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const char *node, const char *port)
>  			rc = errno;
>  			goto error;
>  		}
> -		if (addr->ai_protocol == IPPROTO_TCP && listen(sockfd, 64)) {
> +		if (addr->ai_protocol == IPPROTO_TCP &&
> +		    listen(sockfd, SOMAXCONN)) {
>  			xlog(L_ERROR, "unable to create listening socket: "
>  				"errno %d (%m)", errno);
>  			rc = errno;
> -- 
> 2.44.0

Acked-by: Chuck Lever <chuck.lever@oracle.com>

-- 
Chuck Lever