Received-SPF: pass (google.com: domain of linux-nfs+bounces-2298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Feedback-ID: i197146af:Fastmail
Date: Fri, 15 Mar 2024 01:35:27 +0100
From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: Chuck Lever <chuck.lever@oracle.com>, git@vger.kernel.org,
	linux-nfs@vger.kernel.org
Subject: Re: t0032 fails on NFS mounts
Message-ID: <ZfOXz81cpGZvq6Pq@tanuki>
References: <ZfBwZTL9zqDsac5m@manet.1015granger.net>
 <20240313072052.GC125150@coredump.intra.peff.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kEkf0p8qSI8kbnth"
Content-Disposition: inline
In-Reply-To: <20240313072052.GC125150@coredump.intra.peff.net>


--kEkf0p8qSI8kbnth
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 13, 2024 at 03:20:52AM -0400, Jeff King wrote:
> +cc Patrick for reftable
>=20
> On Tue, Mar 12, 2024 at 11:10:29AM -0400, Chuck Lever wrote:
>=20
> > Unit test t0032 fails when run on an NFS mount:
> >=20
> > [vagrant@cel t]$ ./t0032-reftable-unittest.sh=20
> > not ok 1 - unittests
> > #=09
> > #		TMPDIR=3D$(pwd) && export TMPDIR &&
> > #		test-tool reftable
> > #=09
> > # failed 1 among 1 test(s)
> > 1..1
>=20
> The output for this test script is particularly unhelpful because it's
> not using our test harness at all, but just running a bunch of internal
> tests using a single program.
>=20
> Running with "-v" should give more details about what's failing.
>=20
> I set up a basic loopback server like:
>=20
>   mkdir /mnt/{server,client}
>   exportfs -o rw,sync 127.0.0.1:/mnt/server
>   mount -t nfs 127.0.0.1:/mnt/server /mnt/client
>=20
> and then ran:
>=20
>   ./t0032-reftable-unittest.sh --root=3D/mnt/client -v
>=20
> Looks like it fails at:
>=20
>   running test_reftable_stack_compaction_concurrent_clean
>   reftable/stack_test.c: 1063: failed assertion count_dir_entries(dir) =
=3D=3D 2
>   Aborted
>=20
> > v2.43.2 seems to work OK.
>=20
> For me, too. Bisecting shows the problem appearing in 4f36b8597c
> (reftable/stack: fix race in up-to-date check, 2024-01-18).
>=20
> -Peff
>=20
> PS That test seems to run ~20x slower on NFS versus directly on ext4.
>    I'd expect a little overhead, but that's quite a bit.

Unless somebody else beats me to it I'll investigate this next week when
I'm back in the office. Thanks for the report and for digging into this
issue!

Patrick

--kEkf0p8qSI8kbnth
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAmXzl8oACgkQVbJhu7ck
PpSL2g//WacKeoCja0fkBqNLavOycWG8HVXvhBGsmtUo3fc2g7nUbaFLtW/vbPoN
NPdx+cZa+Da2AtGLbaniY3NTM+/8m6BLd767Hme3N+ZeWgfLDaFIjttUPVB/VEsB
ao7NRZa3o2upCKX6sxgmqV2ppRRfbYMZO0FPR54vrSqWG9t24uYU9vyl+RLW2+f8
bE42ta1c5hcRSvbSUg2IyyPdokwsh/mdQEpN3h480p+/iLr2hhhzsi7a1QNit6qa
hKcqzcjWvbAj4qy35HliFQSJA2F/Gv4QD3bSWVXn3EXTpaMwIkD8PKeVk7ObXcmA
UNq0qolQXUD5NQbGiAeXOpepoiwpVTV/7mUup/z1p4neHEkFK52IpRFIymRCTGiX
sLitPQvbY6KyBuTivJEH49znZbAiL/YNK8snK0hqPviR3c/OlZSb55BT6Z9ooWep
2o9g873bAHBNuhuWJkXNOozsgYH4m4soYc4eoVJzoa6uUz+gOmG0vws/owCKeDfX
Tg2lsH1MSdyuVL1LBg1M4wLMW8dmBlIhvqVtvjT/oCnpFgORKpAAQpFBopVhrhBI
WodPUpZ7XdAUAvuTmxp8wtp/QIjngNthSn/K/YW1J9rjeocWxZbJFlS5vbEc3/b4
5STBHj71eiFWsmBsz3lkO/QAQ3ElJPl/5zTTMF2sA9ue8qkQ1EE=
=UGq0
-----END PGP SIGNATURE-----

--kEkf0p8qSI8kbnth--