Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp298817lqt; Mon, 18 Mar 2024 08:11:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWf9dpp7wK7AlqT9SN8pG3kqZuOS1jNrPGUcup168PzuUj3tzpomYC2Hikve5H37RMPf3tA8HWfT9UUuAWtmACrAceRyCwaz7/DnwcHAQ== X-Google-Smtp-Source: AGHT+IHgoxEMzhoWBwW+wQXrV6eGhH2VdWtdXYjCsdDoHfvpMYBpy7vNIcDFPg+5rJKSMPCi6eOc X-Received: by 2002:a05:651c:b21:b0:2d4:a74a:56f1 with SMTP id b33-20020a05651c0b2100b002d4a74a56f1mr2826289ljr.35.1710774675855; Mon, 18 Mar 2024 08:11:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710774675; cv=pass; d=google.com; s=arc-20160816; b=Nf1Qk8wPHGZTywo6Ktt47LfvYo5+K0HS8KE5ikz3vTK1KUkLELYuQp+acwWSxM0JHK LMquuzlzXfRuZf4kGa2LZXgzVKNH9/QmjWDrR43h2JH8JyYWd99Ft2+4tPQtlsUKtDbe E819rw22TyLofxrrbs7BloGe2vHgjyj7fBCBD3sLqWoF/1lGNx5/Oes5X32Mjk7DKhZK gC21sLYW4QGIMeuUQl/yhU7bXX4R/UK6TJOnOuc6cdluObgPnnxMvOwdwjGMh8LxHvpr vu+HkCK2MROHRUYb/jjrNKgHT7qkuqyQxosIqRF8WF+b6hreqOolpRKyPMUPXLr8o9RZ Xm9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:to:from :dkim-signature; bh=tc9nRWLZD0aDllGvcK6WcmcK7F36+buIaYlg8CfGE9w=; fh=X+EyhGLOnc20nszN9yx9kykhker0HdXxUgxJEqbBcDI=; b=kuMUAqlkLCwJ1YHWWXPUapsFYH0af5I9ClsJX7jgMAFQFHqrr1geauCSQ4dr5F1XpV pSovD1DGIjxk4wnJ3tvXu0wgJT/hzDQ3FCP6O065l+0HjO6Yc73B4HXbuCjT+WZ1D8Sc 13IjG+T14xUcAdzBr1Jefh8JCir5btMw/7I3fj8XI5StoV3zCkXLEbOGTsb+fzQ49pOj zK/5V3rY5ONO53el2FOxcKT45XHV9nWJXFIVprh4aYIh9OC3D2fBPV8n4X7hhuBVXdEf NbEmFQ6rduJ4+u/FX46Fpi6CwLLx2oK+L5hRLiSdKeoSkT8BdYGe2B5VTPpo/eNbK/EX hCIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=d1aNVn7q; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-nfs+bounces-2370-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2370-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h3-20020a056402280300b005687e76626dsi4542262ede.87.2024.03.18.08.11.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 08:11:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-2370-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=d1aNVn7q; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-nfs+bounces-2370-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2370-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8FA1F1F21916 for ; Mon, 18 Mar 2024 15:11:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 732B228DD6; Mon, 18 Mar 2024 15:11:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d1aNVn7q" X-Original-To: linux-nfs@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A54854EB50 for ; Mon, 18 Mar 2024 15:11:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710774666; cv=none; b=N9CTqU08iD/p58fY3M460WSWW/ghQQdCqO3kT/wQITyOfBr7T5ChSn5YvcOsAXby8LWVkY0zjeoRgF6Whko983FYKjoCcWIfJwX0RpeUQpWYxUnJfszHyUM0Qm8EniswWeTREKUBVWa+ae/w2Nrgh2r5/wgQtef4Ilu3P8IBgPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710774666; c=relaxed/simple; bh=LPtwYLTuqJc5BBsInh5pQG8uaHeNhPG49+HQ7eFv0g0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=bd90aNe8jDV/+/dvzEGrExjHQ42h+vBG9EAyAXoJMOOSKVBunRbJtM8Fq7PBYj3Uq/BJ9CdSD8v6p1l0o8kRbdo0AIBn/2AKsgO3aFm1CbZEgqfFUDPWzGZIEHxuBEHW7Sm4eHtUyynCjaANMMWEM6Ztum5GhWs5HAz8R2j1wAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=d1aNVn7q; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710774663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tc9nRWLZD0aDllGvcK6WcmcK7F36+buIaYlg8CfGE9w=; b=d1aNVn7qV8AV+jFlwgx/UBZxvU3fYgNbZV/JJMY2G/UTehRsQqaQuADiFCjI6joYLsa/So JXrceYLF27+cGoQw7OTo/pWmTR8yUutUU62AfxVzbnj+FlTJnrkhKLRDLrtdv/N346/j31 PwQ9PWZcT+Q9IEUQrEiVtw5eXhpaZ7I= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-31Bv8g_lPEulaFsjLjWVbQ-1; Mon, 18 Mar 2024 11:11:01 -0400 X-MC-Unique: 31Bv8g_lPEulaFsjLjWVbQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7C6C03C0D7BA for ; Mon, 18 Mar 2024 15:11:01 +0000 (UTC) Received: from bighat.boston.devel.redhat.com (bighat.boston.devel.redhat.com [10.19.60.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 68B92200AFA3 for ; Mon, 18 Mar 2024 15:11:01 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH] rpcb_clnt.c: memory leak in destroy_addr Date: Mon, 18 Mar 2024 11:11:01 -0400 Message-ID: <20240318151101.11043-1-steved@redhat.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 From: Herb Wartens Piece was dropped from original fix. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2225226 Signed-off-by: Steve Dickson --- src/rpcb_clnt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rpcb_clnt.c b/src/rpcb_clnt.c index 68fe69a..d909efc 100644 --- a/src/rpcb_clnt.c +++ b/src/rpcb_clnt.c @@ -121,6 +121,7 @@ destroy_addr(addr) free(addr->ac_taddr->buf); addr->ac_taddr->buf = NULL; } + free(addr->ac_taddr); addr->ac_taddr = NULL; } free(addr); -- 2.44.0