Received-SPF: pass (google.com: domain of linux-nfs+bounces-2380-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <621c64a8-6566-4c7c-be08-618b74e84c63@redhat.com>
Date: Mon, 18 Mar 2024 16:40:16 -0400
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] rpcb_clnt.c: memory leak in destroy_addr
Content-Language: en-US
From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20240318151101.11043-1-steved@redhat.com>
In-Reply-To: <20240318151101.11043-1-steved@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 3/18/24 11:11 AM, Steve Dickson wrote:
> From: Herb Wartens <wartens2@llnl.gov>
> 
> Piece was dropped from original fix.
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2225226
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... (tag: libtirpc-1-3-5-rc3)

steved.

> ---
>   src/rpcb_clnt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/rpcb_clnt.c b/src/rpcb_clnt.c
> index 68fe69a..d909efc 100644
> --- a/src/rpcb_clnt.c
> +++ b/src/rpcb_clnt.c
> @@ -121,6 +121,7 @@ destroy_addr(addr)
>   			free(addr->ac_taddr->buf);
>   			addr->ac_taddr->buf = NULL;
>   		}
> +		free(addr->ac_taddr);
>   		addr->ac_taddr = NULL;
>   	}
>   	free(addr);