Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp865106lqp; Thu, 21 Mar 2024 19:38:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUVJsPQWPQyoCPtgMOJ3pwCqciRhEosruS8zKtGyZiDYR3mu3wR+204KM1Md3D8qbsxo/WxPnZB3BnDqVavbBpe6CSw/mtaA9ek5V7n6w== X-Google-Smtp-Source: AGHT+IGzsC9MZ73Iby4jtyzASY4FeGuDzeQ++bMBqNVgVO267Cw1gL+SUfygYRVbsrP6x0di1rEZ X-Received: by 2002:a25:d657:0:b0:dd0:c2a:26f9 with SMTP id n84-20020a25d657000000b00dd00c2a26f9mr926645ybg.27.1711075088813; Thu, 21 Mar 2024 19:38:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711075088; cv=pass; d=google.com; s=arc-20160816; b=IDm3PJ0lIDIILDfGG8mob0bBMB8R3O2nyCYYhwe9cyON3skoi1mBaALfCzNwL/i7v/ UQsNkxgpiwf8m4VVXged/kBNKommmBAcdu1fk0AG1p3XheVnwYVI9qXrvGzKCMBLcmzS Fie4TvGbLwrup2L23zz0UrJGS48zN2AaXW2vyvMNo+GnL6iDWwj+8y5YEotd71MpZyxS KPYPm1qBGcchRC36y9tmvXrilq7/YOfNHFkUftkOpUDlRHsgvY6FuDSEUSl+tzCpZ9BI DYcPgWyr6mfjTYsts7oQzRSheJ1w0Inz+Z7lIdhBsKC2saN7VZj+/VGR/dxDBIvkH5yx Oi8A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=CFpVKJVJRfjSWuMbue/EbEUElZ2dHk7l7G3ViVHfJPk=; fh=fJeQ1waaiqvUFhz5hvDQHcXp5p1aHgZO9kA2ksJKl40=; b=gdZtBCkZc+v1BM0dRjIZG41Ag+kK4Mts6ehMWjNrq7YWDc2a0XfYqcJ3XVDaAHsSCD j4up76KgTUPA3wFFcLleQM5GMrX057QtEcIEYgsPBvwLgyLfHkVn+5DOX4ntG6GEiNP9 OR29sHVZup6avgspcNAe6OLcloY9FYeNC+XrIbC13SR+q5xaSjzj7oEMW0tLWp5Jqn9S Itq/rIWzeC4j3NqxavE9GRZHUsAE8fICSl4GInqJjiplt2gKROcSjAqQfMiaQA/mq7B/ NemTOM2OIqUQJ5NrvGtslLPy6D468LkZ+VEY53V+bXHPEYfyQQwle1kYhYzTUsJgt6qs d6Fg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=ELhrDAFM; arc=pass (i=1 dkim=pass dkdomain=linux.org.uk dmarc=pass fromdomain=zeniv.linux.org.uk); spf=pass (google.com: domain of linux-nfs+bounces-2441-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2441-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id i25-20020a632219000000b005d81ba6649esi997594pgi.891.2024.03.21.19.38.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 19:38:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-2441-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=ELhrDAFM; arc=pass (i=1 dkim=pass dkdomain=linux.org.uk dmarc=pass fromdomain=zeniv.linux.org.uk); spf=pass (google.com: domain of linux-nfs+bounces-2441-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2441-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 997DEB21942 for ; Fri, 22 Mar 2024 02:38:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C92E1A38C5; Fri, 22 Mar 2024 02:38:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="ELhrDAFM" X-Original-To: linux-nfs@vger.kernel.org Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C44F8387 for ; Fri, 22 Mar 2024 02:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711075083; cv=none; b=rW1EnNa7PTTunUxV78biAkxJf1Wvpu0v1ZA7OlVNGHOhfaRomr7JF/HWQaqxtRuUbzxVmc/S1WJBqxR1bc5jJV1c2rLcyPaj7Nh+fOprC5ORMyTkb5QhxEY7RzEzLuZKuI/rXj7KtTWXP++dzJ8DEEwvEYWuKYB54GxbrWfNnuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711075083; c=relaxed/simple; bh=0iPnfcSlC30Z/CszmZOSzCzy+hktL+N9CiLZOxmd2tI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qbz6xKyUbjfFQEtzGSU5no6wKChE6oda5QKMZVeZwj/ARwt+TRshS6MWJ32gZDimtgk0or9s94ETp531jmr/952MlgijlFVOtWQ4tJ2uemDS/SeyIVJW4WZTP3umKKrskPbyxfigTlDTcHYWPyA4E28B8qgT80EmuO0BaQf5gRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=ELhrDAFM; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CFpVKJVJRfjSWuMbue/EbEUElZ2dHk7l7G3ViVHfJPk=; b=ELhrDAFMoI2V+AwWxX1YPjUgfl YULDcLi12H4VO4+DBR07cg9+ytkUKHZ56JRrnMG6HMNL9jg3FzXpplvZp8ZuUZKO/U6ARZR+B0Ans YKsYinPt6W2a4jQHKolrErcnRcP/YZ9JWI8CWkcfuQM64fCuWc2iHNQBrGAB4cCxMJmOVkZH1o4Yv p44fi1+G2BW09bRthhGj8Zjm0YNkOMAqHX9FMxtBAPA2J/W0bIqyfO69wQPjSYsY+hg8/AVcSIv50 Z6drcgLgX9ewXWciuWAdGS/A6/gkCrm6ApCUHuD+9kkAaokamhZ+GLJeUcgLCkF5SElDKiJshuizD MeBlXCsg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1rnUn5-00EDmH-1U; Fri, 22 Mar 2024 02:37:55 +0000 Date: Fri, 22 Mar 2024 02:37:55 +0000 From: Al Viro To: Jan Kara Cc: Chuck Lever , Christian Brauner , linux-nfs@vger.kernel.org, Jeff Layton Subject: Re: [PATCH] nfsd: Fix error cleanup path in nfsd_rename() Message-ID: <20240322023755.GL538574@ZenIV> References: <20240318163209.26493-1-jack@suse.cz> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240318163209.26493-1-jack@suse.cz> Sender: Al Viro On Mon, Mar 18, 2024 at 05:32:09PM +0100, Jan Kara wrote: > Commit a8b0026847b8 ("rename(): avoid a deadlock in the case of parents > having no common ancestor") added an error bail out path. However this > path does not drop the remount protection that has been acquired. Fix > the cleanup path to properly drop the remount protection. > > Fixes: a8b0026847b8 ("rename(): avoid a deadlock in the case of parents having no common ancestor") > Signed-off-by: Jan Kara Acked-by: Al Viro Sorry, my fault.